Skip to content

Conversation

@yaakovschectman
Copy link
Contributor

Reverts #149383 as it caused failure for mac framework_tests_impeller.

@yaakovschectman yaakovschectman added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 11, 2024
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 11, 2024
@yaakovschectman yaakovschectman merged commit 14df7be into master Jun 11, 2024
@yaakovschectman yaakovschectman deleted the revert-149383-flutter/api/example/Add-tests-for-scaffold-drawer-and-end-drawer branch June 11, 2024 15:14
ValentinVignal added a commit to ValentinVignal/flutter that referenced this pull request Jun 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 11, 2024
flutter/flutter@32081aa...14df7be

2024-06-11 [email protected] Revert "Add tests for scaffold drawer and end drawer" (flutter/flutter#150045)
2024-06-11 [email protected] Add tests for scaffold drawer and end drawer (flutter/flutter#149383)
2024-06-11 [email protected] Add high-contrast theme (flutter/flutter#149779)
2024-06-11 [email protected] Manual Pub Roll (flutter/flutter#150025)
2024-06-10 [email protected] [docs] Per-platform desktop triage instructions (flutter/flutter#150019)
2024-06-10 [email protected] Fix copy-paste-o in MethodChannel.invokeListMethod doc (flutter/flutter#149976)
2024-06-10 [email protected] Unpin `camera_android` and remove its only usage (flutter/flutter#150017)
2024-06-10 [email protected] Fixes a bug where NavigatorState.pop does not consider any possible sâ�¦ (flutter/flutter#150014)
2024-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: [CupertinoActionSheet] Match colors to native (#149568) (#150015)" (flutter/flutter#150021)
2024-06-10 [email protected] Reland: [CupertinoActionSheet] Match colors to native (#149568) (flutter/flutter#150015)
2024-06-10 [email protected] Temporarily run Mac_arm64 framework_tests_misc on only Mac-13 (flutter/flutter#150009)
2024-06-10 [email protected] Fixes TextField hinttext in a11y_assessment (flutter/flutter#150007)
2024-06-10 [email protected] Use const bool.fromEnvironment("dart.tool.dart2wasm") to detect dart2wasm (flutter/flutter#149996)
2024-06-10 [email protected] Roll Packages from 8a2c4e4 to e95fe4a (3 revisions) (flutter/flutter#149997)
2024-06-10 [email protected] [web] Notify engine of handled PointerScrollEvents. (flutter/flutter#145500)
2024-06-10 [email protected] Cut no-longer-accurate microtask reference in finalizeTree doc (flutter/flutter#149941)
2024-06-10 [email protected] Update hasTrailingSpaces (flutter/flutter#149698)
2024-06-10 [email protected] [web] Change `--web-renderer` default from `auto` to `canvaskit` (flutter/flutter#149773)
2024-06-10 [email protected] Retain the toString method for subclasses of Key in profile/release mode (flutter/flutter#149926)
2024-06-10 [email protected] Remove package:platform from issue template (flutter/flutter#149995)
2024-06-10 [email protected] Revert "[CupertinoActionSheet] Match colors to native (#149568)" (flutter/flutter#149998)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Jun 12, 2024
)

This relands commit 14df7be.

Contributes to #130459

Needs #149851 to be fixed before getting merged
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants