Skip to content

Reverts "Fix SegmentedButton clipping when drawing segments (#149739)" #149927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 7, 2024
Merged

Reverts "Fix SegmentedButton clipping when drawing segments (#149739)" #149927

auto-submit merged 1 commit into from
Jun 7, 2024

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Jun 7, 2024

Reverts: #149739

Initiated by: QuncCccccc

Reason for reverting: the newly-added unit test might cause the red tree

Original PR Author: TahaTesser

Reviewed By: {QuncCccccc}

This change reverts the following previous change:
fixes SegmentedButton doesn't clip properly when one of the segments has ColorFiltered

Code sample

expand to view the code sample 
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: SegmentedButton<int>(
            segments: const <ButtonSegment<int>>[
              ButtonSegment<int>(
                value: 0,
                label: ColorFiltered(
                  colorFilter:
                      ColorFilter.mode(Colors.amber, BlendMode.colorBurn),
                  child: Text('Option 1'),
                ),
              ),
              ButtonSegment<int>(
                value: 1,
                label: Text('Option 2'),
              ),
            ],
            onSelectionChanged: (Set<int> selected) {},
            selected: const <int>{0},
          ),
        ),
      ),
    );
  }
}

Before

before

After

after

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jun 7, 2024
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 7, 2024
@auto-submit auto-submit bot merged commit b5697a0 into master Jun 7, 2024
@auto-submit auto-submit bot deleted the revert_fc19ecfc585ae19e2bb74161749e296bd1bddcdb branch June 7, 2024 19:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2024
@engine-flutter-autoroll
b5697a0 Reverts "Fix SegmentedButton clipping when drawing segments…
a8b78c5 
… (#149739)" (flutter/flutter#149927)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2024
@engine-flutter-autoroll
b5697a0 Reverts "Fix SegmentedButton clipping when drawing segments…
4f7d797 
… (#149739)" (flutter/flutter#149927)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2024
@engine-flutter-autoroll
b5697a0 Reverts "Fix SegmentedButton clipping when drawing segments…
bf13f1f 
… (#149739)" (flutter/flutter#149927)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2024
@engine-flutter-autoroll
b5697a0 Reverts "Fix SegmentedButton clipping when drawing segments…
0086e5d 
… (#149739)" (flutter/flutter#149927)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 10, 2024
@engine-flutter-autoroll
Roll Flutter from fc19ecf to 32081aa (9 revisions) (#6896)
842e2db 
flutter/flutter@fc19ecf...32081aa

2024-06-08 [email protected] [CupertinoActionSheet] Match colors to native (flutter/flutter#149568)
2024-06-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 1cdbebee1901 to 45cf05f7a580 (10 revisions) (#149944)" (flutter/flutter#149960)
2024-06-08 [email protected] Roll Flutter Engine from 1cdbebee1901 to 45cf05f7a580 (10 revisions) (flutter/flutter#149944)
2024-06-07 [email protected] Refactor `getRootWidgetSummaryTree` tests in `widget_inspector_test.dart` (flutter/flutter#149930)
2024-06-07 [email protected] Remove zanderso from TESTOWNERS (flutter/flutter#149935)
2024-06-07 [email protected] PinnedHeaderSliver (flutter/flutter#143196)
2024-06-07 [email protected] Fix test case in "getRootWidgetSummaryTree" test (flutter/flutter#149923)
2024-06-07 [email protected] Revert "Identify and re-throw our dependency checking errors in `flutter.groovy` (#149609)" (flutter/flutter#149918)
2024-06-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix `SegmentedButton` clipping when drawing segments (#149739)" (flutter/flutter#149927)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
b5697a0 Reverts "Fix SegmentedButton clipping when drawing segments…
0b67720 
… (#149739)" (flutter/flutter#149927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@QuncCccccc QuncCccccc

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SegmentedButton doesn't clip properly when one of the segments has ColorFiltered

2 participants

@fluttergithubbot @QuncCccccc