-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[CP] Point kotlin message in gradle_errors.dart towards new place
#149881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP] Point kotlin message in gradle_errors.dart towards new place
#149881
Conversation
…templates define the kotlin version (#145936) Fixes #144454 For reference, after formatting it looks like: ``` â��â�� Flutter Fix â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â�� â�� [!] Your project requires a newer version of the Kotlin Gradle plugin. â�� â�� Find the latest version on https://kotlinlang.org/docs/releases.html#release-details, then update the â�� â�� version number of the plugin with id "org.jetbrains.kotlin.android" in the plugins block of â�� â�� /Users/mackall/development/BugTesting/ELIMINATEME/blah/android/settings.gradle. â�� â�� â�� â�� Alternatively (if your project was created before Flutter 3.19), update â�� â�� /Users/mackall/development/BugTesting/ELIMINATEME/blah/android/build.gradle â�� â�� ext.kotlin_version = '<latest-version>' â�� â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â�� ```
|
@reidbaker I'm leaning towards rejecting this as not being critical enough to warrant cherrypicking, unless you disagree. WDYT? |
|
I'm sorry for interjecting, but I would argue this is an important fix that needed to be merge. It shows the responsibility and respect to other people's time. I'm not familiar to Flutter's merging process myself, but I see this wouldn't hurt even though it's not critical. It just so sad that for this past months, people are misguided when they shouldn't be since we already have this fix that hasn't landed in stable. I apologize if I'm getting ahead of myself by making this request clearer. But I find the rejection reason nor whether there is any clear timeline of this fix to be merged to stable if this cherry pick request is going to be rejected hasn't made clear yet. |
|
@christopherfujino I think the pick is safe enough, as to critical enough, I think migrations have the most value on the following release of the same type like stable to stable. I cant remember what the update patch schedule is but my answer is that if we were shipping a patch then I would lean towards taking this CP but I would not ask that we do a release solely for this CP. |
Thanks for the context |
|
auto label is removed for flutter/flutter/149881, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
Cherry pick request of #145936 to stable
Update Flutter Fix log on how to update Kotlin Gradle Plugin that was introduced in Flutter 3.19.x
Closes #149856