Skip to content

Conversation

@brainwo
Copy link

@brainwo brainwo commented Jun 7, 2024

Cherry pick request of #145936 to stable

Update Flutter Fix log on how to update Kotlin Gradle Plugin that was introduced in Flutter 3.19.x

Closes #149856

…templates define the kotlin version (#145936)

Fixes #144454

For reference, after formatting it looks like:
```
�� Flutter Fix �������������������������������������������������������������������������������������������
� [!] Your project requires a newer version of the Kotlin Gradle plugin.                                 �
� Find the latest version on https://kotlinlang.org/docs/releases.html#release-details, then update the  �
� version number of the plugin with id "org.jetbrains.kotlin.android" in the plugins block of            �
� /Users/mackall/development/BugTesting/ELIMINATEME/blah/android/settings.gradle.                        �
�                                                                                                        �
� Alternatively (if your project was created before Flutter 3.19), update                                �
� /Users/mackall/development/BugTesting/ELIMINATEME/blah/android/build.gradle                            �
� ext.kotlin_version = '<latest-version>'                                                                �
����������������������������������������������������������������������������������������������������������
```
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 7, 2024
@christopherfujino
Copy link
Contributor

@reidbaker I'm leaning towards rejecting this as not being critical enough to warrant cherrypicking, unless you disagree. WDYT?

@brainwo
Copy link
Author

brainwo commented Jun 14, 2024

I'm sorry for interjecting, but I would argue this is an important fix that needed to be merge. It shows the responsibility and respect to other people's time.

I'm not familiar to Flutter's merging process myself, but I see this wouldn't hurt even though it's not critical.

It just so sad that for this past months, people are misguided when they shouldn't be since we already have this fix that hasn't landed in stable.

I apologize if I'm getting ahead of myself by making this request clearer. But I find the rejection reason nor whether there is any clear timeline of this fix to be merged to stable if this cherry pick request is going to be rejected hasn't made clear yet.

@reidbaker
Copy link
Contributor

reidbaker commented Jun 17, 2024

@christopherfujino I think the pick is safe enough, as to critical enough, I think migrations have the most value on the following release of the same type like stable to stable. I cant remember what the update patch schedule is but my answer is that if we were shipping a patch then I would lean towards taking this CP but I would not ask that we do a release solely for this CP.

@christopherfujino
Copy link
Contributor

@christopherfujino I think the pick is safe enough, as to critical enough, I think migrations have the most value on the following release of the same type like stable to stable. I cant remember what the update patch schedule is but my answer is that if we were shipping a patch then I would lean towards taking this CP but I would not ask that we do a release solely for this CP.

Thanks for the context

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 1, 2024

auto label is removed for flutter/flutter/149881, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2024
@itsjustkevin itsjustkevin self-requested a review July 1, 2024 19:43
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2024
@auto-submit auto-submit bot merged commit 855aab9 into flutter:flutter-3.22-candidate.0 Jul 1, 2024
@brainwo brainwo deleted the cp_flutter-3.22_flutter-fix-kotlin branch July 4, 2024 08:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants