Skip to content

closes #issue136763, changed a command to generate gradle error message according to platform #149877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 11 commits into from
Jun 12, 2024
Merged

closes #issue136763, changed a command to generate gradle error message according to platform #149877

auto-submit merged 11 commits into from
Jun 12, 2024

Conversation

@D-extremity
Copy link
Contributor

@D-extremity D-extremity commented Jun 7, 2024

Currently, the error message displayed to regenerate the lockfiles gives a Unix-like command ./gradlew, which will be incorrect for Windows environments. This PR uses globals.platform.isWindows to give the appropriate command.

closes #136763

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 7, 2024
@D-extremity D-extremity force-pushed the issue__136763_first branch 3 times, most recently from 240ae41 to ed65b09 Compare June 7, 2024 19:35
@D-extremity
Copy link
Contributor Author

D-extremity commented Jun 7, 2024

@christopherfujino sir please review it whenever you get time.

@D-extremity D-extremity force-pushed the issue__136763_first branch 3 times, most recently from 89193a6 to 9eb2ecf Compare June 8, 2024 17:42
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 8, 2024

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149877 at sha 9eb2ecf

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 8, 2024
@D-extremity
Copy link
Contributor Author

D-extremity commented Jun 9, 2024

@Piinks please review it whenever is feasible for you.

Piinks
Piinks reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @D-extremity welcome, thanks for sending a PR. Unfortunately I am probably not the best person to review it. Perhaps @reidbaker?

reidbaker
reidbaker reviewed Jun 10, 2024
View reviewed changes
reidbaker
reidbaker reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for your contribution. Some minor nits

@reidbaker reidbaker requested review from Piinks and removed request for Piinks June 10, 2024 17:30
reidbaker
reidbaker approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve % comments

Piinks
Piinks approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reidbaker
reidbaker reviewed Jun 10, 2024
View reviewed changes
reidbaker
reidbaker requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/flutter_tools/lib/src/android/gradle_errors.dart test should not need to be modified.

@D-extremity D-extremity requested a review from reidbaker June 10, 2024 20:11
reidbaker
reidbaker reviewed Jun 10, 2024
View reviewed changes
@D-extremity D-extremity requested a review from reidbaker June 10, 2024 20:31
Satyam Srivastav added 2 commits June 11, 2024 02:30
@D-extremity
fixes #issue136763, changed a command to generate gradle error messag…
280e1b8 
…e according to platform

added missing newline at end of the file

added eod to fix linux analyze failure

ci.validation failure test to pass

canvaskti error fixed
@D-extremity
Renamed generateCommand to generatedGradleCommand
8d50e39
@D-extremity D-extremity requested a review from andrewkolos June 11, 2024 07:04
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 11, 2024

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149877 at sha 76ceb75

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 11, 2024

auto label is removed for flutter/flutter/149877, due to - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@D-extremity D-extremity requested a review from reidbaker June 11, 2024 16:02
@D-extremity
Copy link
Contributor Author

D-extremity commented Jun 11, 2024

@reidbaker please add auto submit label again as earlier cases were failed .

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2024
@auto-submit auto-submit bot merged commit c5e5e0c into flutter:master Jun 12, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
c5e5e0c closes #issue136763, changed a command to generate gradle err…
d0e4e33 
…or message according to platform (flutter/flutter#149877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
c5e5e0c closes #issue136763, changed a command to generate gradle err…
483b8ad 
…or message according to platform (flutter/flutter#149877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
c5e5e0c closes #issue136763, changed a command to generate gradle err…
428dbb7 
…or message according to platform (flutter/flutter#149877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
c5e5e0c closes #issue136763, changed a command to generate gradle err…
83c298b 
…or message according to platform (flutter/flutter#149877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
c5e5e0c closes #issue136763, changed a command to generate gradle err…
9bc44b8 
…or message according to platform (flutter/flutter#149877)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
c5e5e0c closes #issue136763, changed a command to generate gradle err…
d79d30a 
…or message according to platform (flutter/flutter#149877)
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@D-extremity @victorsanni
closes #issue136763, changed a command to generate gradle error messa…
fed07ff 
…ge according to platform (flutter#149877)

Currently, the error message displayed to regenerate the lockfiles gives a Unix-like command ./gradlew, which will be incorrect for Windows environments. This PR uses globals.platform.isWindows to give the appropriate command.

closes flutter#136763
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@D-extremity @victorsanni
closes #issue136763, changed a command to generate gradle error messa…
bcc6d3f 
…ge according to platform (flutter#149877)

Currently, the error message displayed to regenerate the lockfiles gives a Unix-like command ./gradlew, which will be incorrect for Windows environments. This PR uses globals.platform.isWindows to give the appropriate command.

closes flutter#136763
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
c5e5e0c closes #issue136763, changed a command to generate gradle err…
5c97841 
…or message according to platform (flutter/flutter#149877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@Piinks Piinks Piinks approved these changes

@andrewkolos andrewkolos Awaiting requested review from andrewkolos

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Most error messages in gradle_errors.dart assume a unix like path separator/environment

4 participants

@D-extremity @reidbaker @andrewkolos @Piinks