Skip to content

Conversation

@aam
Copy link
Member

@aam aam commented Feb 28, 2018

This is to fix #14931.

@aam aam requested a review from mraleph February 28, 2018 19:28
@mraleph
Copy link
Member

mraleph commented Feb 28, 2018

is linking platform in required? In my tests just removing --incremental was enough.

@aam
Copy link
Member Author

aam commented Feb 28, 2018

@mraleph wrote

is linking platform in required? In my tests just removing --incremental was enough.

Yes, per what I see just removing incrementalCompilerByteStorePath: '' option still produces kernel file with empty methods in _Object&ListMixin^^#T0 class.

@aam aam merged commit 9a9aed1 into flutter:master Feb 28, 2018
@mraleph
Copy link
Member

mraleph commented Feb 28, 2018

I am now really concerned that we might have this problem in hot-reload scenario. We need to test this. Also lets try to work with FE team to ensure that we have a way to produce partial Kernel files during testing to avoid overhead.

@aam
Copy link
Member Author

aam commented Feb 28, 2018

This PR is certainly just a workaround to unblock current implementation of flutter test --preview-dart-2. Besides concerns about hot reload, we will need working incremental compiler to have flutter test --preview-dart-2 reuse frontend compiler for multiple tests (#14728).

@aam aam deleted the test-dont-use-incremental branch February 28, 2018 21:04
@aam
Copy link
Member Author

aam commented Feb 28, 2018

Also lets try to work with FE team to ensure that we have a way to produce partial Kernel files during testing to avoid overhead.

I'm in the middle of moving frontend_server to the dart sdk(main stumbling block is the fact that flutter frontend_server has flutter-specific widget inspector kernel transformation hardcoded, which I don't want to copy over to dart sdk), that should help with that a little.

DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter test loads test forever in --preview-dart-2

3 participants