Make CupertinoTextField respect decoration color when disabled
#149774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorsanni
changed the title
CupertinoTextField respect decoration color when disabled
github-actions
bot
added
a: text input
| final BoxDecoration? effectiveDecoration = (widget._textFieldType == _TextFieldType.bordered | ||
| ? widget.decoration?.copyWith( | ||
| border: resolvedBorder, | ||
| color: enabled ? decorationColor |
Contributor
There was a problem hiding this comment.
Maybe we should check if this color is a WidgetStateColor similar to how we've done elsewhere for MaterialStateColor in the past: https://api.flutter.dev/flutter/material/TimePickerThemeData/dayPeriodColor.html.
Then they could customize it for all states easier. It'd need to be called out in the documentation.
Contributor
Author
There was a problem hiding this comment.
From what I can find, CupertinoTextField only has a state for when it is enabled or disabled. I can't find information on any other states (hovering, pressed, focused, etc). So would this be relevant in this case?
It might be worthwhile to create another PR to introduce widget states to CupertinoTextField, at which point this might be more relevant.
Contributor
There was a problem hiding this comment.
The cupertino library AFAIK uses CupertinoDynamicColor which is a similar system but with potentially different input (resolveWith parameters).
LongCatIsLooong
approved these changes
Jun 13, 2024
victorsanni
added
the
autosubmit
victorsanni
added a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…tter#149774) flutter#83531 contains complaints that this default disabled color can no longer be overridden by setting a color of the `decoration` property. This regression was introduced by flutter#78058, which was itself made to fix an issue where the color of the decoration was always used even when disabled. Currently, when the text field is disabled, its color is set to a default disabled color. This PR makes it so that if a decoration is set when the text field is disabled, its color is used instead of the default disabled color. Fixes flutter#83531
victorsanni
added a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…tter#149774) flutter#83531 contains complaints that this default disabled color can no longer be overridden by setting a color of the `decoration` property. This regression was introduced by flutter#78058, which was itself made to fix an issue where the color of the decoration was always used even when disabled. Currently, when the text field is disabled, its color is set to a default disabled color. This PR makes it so that if a decoration is set when the text field is disabled, its color is used instead of the default disabled color. Fixes flutter#83531
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 15, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 15, 2024
flutter/flutter@349ec71...5187cab 2024-06-15 [email protected] Roll Flutter Engine from 8167dffd1914 to 9779c273aac3 (21 revisions) (flutter/flutter#150290) 2024-06-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix flaky complex_layout_scroll_perf__memory test (#150287)" (flutter/flutter#150293) 2024-06-15 [email protected] Fix flaky complex_layout_scroll_perf__memory test (flutter/flutter#150287) 2024-06-14 [email protected] Make `CupertinoTextField` respect decoration color when disabled (flutter/flutter#149774) 2024-06-14 [email protected] Add transparent color to Cupertino colors (flutter/flutter#150149) 2024-06-14 [email protected] Roll pub packages (flutter/flutter#150267) 2024-06-14 [email protected] Roll Packages from 7805455 to dd04ab1 (4 revisions) (flutter/flutter#150264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#83531 contains complaints that this default disabled color can no longer be overridden by setting a color of the
decorationproperty. This regression was introduced by #78058, which was itself made to fix an issue where the color of the decoration was always used even when disabled.Currently, when the text field is disabled, its color is set to a default disabled color. This PR makes it so that if a decoration is set when the text field is disabled, its color is used instead of the default disabled color.
Uses the sentinel value
_kDefaultRoundedBorderDecorationto set the disabled color only if the user does not pass in a decoration.Fixes #83531
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.