Fix DropdownMenu can be focused and updated when disabled #149737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
bleroux
force-pushed
the
fix_dropdown_menu_can_be_focused_and_updated_when_disabled
branch
from
b122799 to
23a24f6
Compare
QuncCccccc
approved these changes
Jun 11, 2024
Contributor
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM:) Thanks for the fix!
QuncCccccc
added
the
autosubmit
bleroux
removed
the
autosubmit
Contributor
Author
bleroux
force-pushed
the
fix_dropdown_menu_can_be_focused_and_updated_when_disabled
branch
from
23a24f6 to
abbd4c5
Compare
bleroux
added
the
autosubmit
bleroux
deleted the
fix_dropdown_menu_can_be_focused_and_updated_when_disabled
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2024
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…9737) ## Description This PRs fixes `DropdownMenu` behaviors when disabled. Before this PR the `DropdownMenu` value can be changed when `DropdownMenu.enabled` was false because the inner `IconButton` was not disabled so it can get focus (for instance using tab key). After this PR, the inner `TextField` and the inner `IconButton` are disabled when `DropdownMenu.enabled` is false. ## Related Issue Fixes flutter#149598. ## Tests Updates 1 test. Adds 1 test.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…9737) ## Description This PRs fixes `DropdownMenu` behaviors when disabled. Before this PR the `DropdownMenu` value can be changed when `DropdownMenu.enabled` was false because the inner `IconButton` was not disabled so it can get focus (for instance using tab key). After this PR, the inner `TextField` and the inner `IconButton` are disabled when `DropdownMenu.enabled` is false. ## Related Issue Fixes flutter#149598. ## Tests Updates 1 test. Adds 1 test.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs fixes
DropdownMenubehaviors when disabled.Before this PR the
DropdownMenuvalue can be changed whenDropdownMenu.enabledwas false because the innerIconButtonwas not disabled so it can get focus (for instance using tab key).After this PR, the inner
TextFieldand the innerIconButtonare disabled whenDropdownMenu.enabledis false.Related Issue
Fixes #149598.
Tests
Updates 1 test.
Adds 1 test.