Adds the ability to move the caret by tapping #1496
Conversation
|
(Requires flutter/engine#2327) |
There was a problem hiding this comment.
does the keyboard tell the editable string?
There was a problem hiding this comment.
I think we should organise the keyboard handle and the editable string such that you tell the same object what the new selection is regardless of whether a keyboard is attached.
There was a problem hiding this comment.
Ok, I think I know what the problem really is. It's that we have the keyboard logic in the Material layer instead of in widgets/editable.dart. But we can fix that in a later patch.
There was a problem hiding this comment.
Yeah, we need to reorganize this code a bit. There's another problem where the EditableString does't know how to tell the render object to repaint when the selection changes. Currently we wait for the cursor to blink. I can look at this in the next patch.
|
lgtm |
Now the text input control knows how to move the caret when you tap inside the string. There's still some rough edges to polish up, but this patch is the first step. Fixes flutter#108
Adds the ability to move the caret by tapping
2 participants
Now the text input control knows how to move the caret when you tap
inside the string. There's still some rough edges to polish up, but this
patch is the first step.
Fixes #108