[Reland] - Enable `explicitChildNodes` for the `AlertDialog` content #149597

TahaTesser · 2024-06-03T15:08:46Z

Relands #149130
(With no change for now, waiting for actual Google testing results to make any changes if needed)

fixes AlertDialog content semantics merged

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      // showSemanticsDebugger: true,
      home: Scaffold(
        body: SafeArea(
          child: Center(
            child: Column(
              mainAxisAlignment: MainAxisAlignment.spaceEvenly,
              children: <Widget>[
                const Column(
                  mainAxisAlignment: MainAxisAlignment.center,
                  children: <Widget>[
                    Text('Some text'),
                    Text('More text'),
                  ],
                ),
                Builder(builder: (BuildContext context) {
                  return ElevatedButton(
                    onPressed: () {
                      showDialog<void>(
                        context: context,
                        builder: (BuildContext context) {
                          return AlertDialog(
                            title: const Text('Dialog Title'),
                            content: const Column(
                              children: <Widget>[
                                Text('Some text'),
                                Text('More text'),
                              ],
                            ),
                            actions: <Widget>[
                              TextButton(
                                onPressed: () {
                                  Navigator.of(context).pop();
                                },
                                child: const Text('Close'),
                              ),
                            ],
                          );
                        },
                      );
                    },
                    child: const Text('Open Dialog'),
                  );
                }),
              ],
            ),
          ),
        ),
      ),
    );
  }
}

Before vs After

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

TahaTesser · 2024-06-05T13:57:23Z

@goderbauer
This was reverted when Google testing didn't run on the original PR and it was merged, see #149130 (comment)

Filed this reland without changes to find the cause for failures, if any.

goderbauer · 2024-06-05T16:33:26Z

I requested a "Google testing" run. Let's see.

TahaTesser · 2024-06-06T12:20:34Z

@goderbauer
Looks like it is indeed failing. Is this a breaking change? Should we introduce a bool for this in the AlertDialog?

justinmc

I've rerun the Google tests since I think the force push lost the previous results and I couldn't see why it failed.

justinmc · 2024-06-26T22:41:25Z

@TahaTesser Can you push another merge commit to kick the tests? I think there is an unrelated failure happening in the Google tests today.

TahaTesser · 2024-07-01T14:24:32Z

@justinmc Thanks for the update! Apologies for delayed action as i have been out of office.

I just pushed a commit, however it looks like there are some unrelated infra issues failing sone tests in multiple PRs.

TahaTesser · 2024-07-02T14:48:51Z

@justinmc
Looks like the google testing is passing now!

Piinks · 2024-07-03T18:14:26Z

(Flyby comment from triage): We should check that the Google testing is a full test run not just the sampling sicne this was reverted before.

TahaTesser · 2024-07-08T07:18:46Z

(Flyby comment from triage): We should check that the Google testing is a full test run not just the sampling sicne this was reverted before.

That sounds like a good idea!

Kick tests Kick tests Kick tests Kick tests Roll pub packages (#151129) This PR was generated by `flutter update-packages --force-upgrade`. Kick tests Kick tests Kick tests Kick tests Kick tests Kick tests

justinmc

LGTM 👍

…content (flutter/flutter#149597)

…lutter#149597) Fixes the semantics of AlertDialog.

…content (flutter/flutter#149597)

flutter/flutter@fafd67d...5103d75 2024-07-09 [email protected] [tool] Remove some usages of deprecated usage package (flutter/flutter#151359) 2024-07-09 [email protected] Write the package config location to the test bootstrap. (flutter/flutter#150440) 2024-07-09 [email protected] [deps] Roll dart-lang/native packages (flutter/flutter#151403) 2024-07-08 [email protected] [tool] make `testUsingContext` provide a `Stdio` (with `hasTerminal` unset) override by default (flutter/flutter#151357) 2024-07-08 [email protected] Make `FittedBox` not throw when child has zero size. (flutter/flutter#150430) 2024-07-08 [email protected] Update `DataTable` documentation (flutter/flutter#151356) 2024-07-08 [email protected] `MaterialState` â�� `WidgetState` in documentation (flutter/flutter#151376) 2024-07-08 [email protected] [ios]A typical news app benchmark with bottom ad banner (flutter/flutter#150991) 2024-07-08 [email protected] Re-enable `SemanticsAction.focus` matchers (flutter/flutter#150990) 2024-07-08 [email protected] Added SliverFloatingHeader.snapMode (flutter/flutter#151289) 2024-07-08 [email protected] Factor out deprecated names in example code (flutter/flutter#151374) 2024-07-08 [email protected] Add cedric vanden bosch to authors (flutter/flutter#151313) 2024-07-08 [email protected] Roll Packages from 97bad7e to 14341d1 (5 revisions) (flutter/flutter#151417) 2024-07-08 [email protected] Update doc-import to primary configured import, _goldens_io.dart (flutter/flutter#151390) 2024-07-08 [email protected] [Reland] - Enable `explicitChildNodes` for the `AlertDialog` content (flutter/flutter#149597) 2024-07-08 [email protected] Add tests for material_state_border_side.0_test.dart (flutter/flutter#151089) 2024-07-08 [email protected] Roll Flutter Engine from ca79a56a66d7 to 69075e7e87d4 (1 revision) (flutter/flutter#151393) 2024-07-08 [email protected] Add tests for action_listener.0.dart (flutter/flutter#150606) 2024-07-07 [email protected] Roll Flutter Engine from 5ca3b856ee5a to ca79a56a66d7 (1 revision) (flutter/flutter#151387) 2024-07-06 [email protected] Roll Flutter Engine from 3600ec613a00 to 5ca3b856ee5a (1 revision) (flutter/flutter#151378) 2024-07-06 [email protected] Roll Flutter Engine from d1ebc5fde630 to 3600ec613a00 (1 revision) (flutter/flutter#151377) 2024-07-06 [email protected] Roll Flutter Engine from e6b09697df1a to d1ebc5fde630 (1 revision) (flutter/flutter#151362) 2024-07-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.3 to 4.3.4 (flutter/flutter#151354) 2024-07-05 [email protected] Roll Flutter Engine from 4ee09d3b7f3b to e6b09697df1a (2 revisions) (flutter/flutter#151352) 2024-07-05 [email protected] Add tests for color_filtered.0.dart example. (flutter/flutter#151064) 2024-07-05 [email protected] de-duplicate code in analyze.dart (flutter/flutter#151279) 2024-07-05 [email protected] Roll Packages from 754de19 to 97bad7e (1 revision) (flutter/flutter#151350) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 3, 2024

TahaTesser marked this pull request as ready for review June 3, 2024 15:09

TahaTesser requested a review from goderbauer June 5, 2024 13:55

TahaTesser force-pushed the reland-149130 branch from e2b8ad3 to aee2dd3 Compare June 12, 2024 06:26

justinmc reviewed Jun 17, 2024

View reviewed changes

TahaTesser requested a review from justinmc June 20, 2024 14:23

TahaTesser force-pushed the reland-149130 branch from 5e8b26b to 524bda6 Compare July 1, 2024 10:00

TahaTesser force-pushed the reland-149130 branch from 524bda6 to ebf408b Compare July 2, 2024 11:46

TahaTesser removed the framework flutter/packages/flutter repository. See also f: labels. label Jul 8, 2024

[Reland] - Enable explicitChildNodes for the AlertDialog content

bccf70c

Kick tests Kick tests Kick tests Kick tests Roll pub packages (#151129) This PR was generated by `flutter update-packages --force-upgrade`. Kick tests Kick tests Kick tests Kick tests Kick tests Kick tests

TahaTesser force-pushed the reland-149130 branch from b998ed0 to bccf70c Compare July 8, 2024 13:23

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 8, 2024

Kick tests

0bbd5ba

justinmc approved these changes Jul 8, 2024

View reviewed changes

justinmc merged commit f080102 into flutter:master Jul 8, 2024

engine-flutter-autoroll mentioned this pull request Jul 8, 2024

Roll Flutter from fafd67d34d68 to f0801023506f (13 revisions) flutter/packages#7075

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2024

f080102 [Reland] - Enable explicitChildNodes for the AlertDialog …

480279e

…content (flutter/flutter#149597)

engine-flutter-autoroll mentioned this pull request Jul 8, 2024

Roll Flutter from fafd67d34d68 to 0a4f1a7e556e (16 revisions) flutter/packages#7076

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2024

f080102 [Reland] - Enable explicitChildNodes for the AlertDialog …

906f0e3

…content (flutter/flutter#149597)

TahaTesser deleted the reland-149130 branch July 8, 2024 18:50

victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jul 8, 2024

[Reland] - Enable explicitChildNodes for the AlertDialog content (f…

01cb450

…lutter#149597) Fixes the semantics of AlertDialog.

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter from fafd67d34d68 to 9ab8b6e15043 (25 revisions) flutter/packages#7082

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024

f080102 [Reland] - Enable explicitChildNodes for the AlertDialog …

2b9f588

…content (flutter/flutter#149597)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter from fafd67d34d68 to 5ebc993dffe8 (26 revisions) flutter/packages#7083

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024

f080102 [Reland] - Enable explicitChildNodes for the AlertDialog …

0f6045d

…content (flutter/flutter#149597)

engine-flutter-autoroll mentioned this pull request Jul 9, 2024

Roll Flutter from fafd67d34d68 to 5103d7574361 (27 revisions) flutter/packages#7084

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2024

f080102 [Reland] - Enable explicitChildNodes for the AlertDialog …

814b1d5

…content (flutter/flutter#149597)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Reland] - Enable `explicitChildNodes` for the `AlertDialog` content #149597

[Reland] - Enable `explicitChildNodes` for the `AlertDialog` content #149597

Uh oh!

TahaTesser commented Jun 3, 2024 •

edited

Loading

Uh oh!

TahaTesser commented Jun 5, 2024

Uh oh!

goderbauer commented Jun 5, 2024

Uh oh!

TahaTesser commented Jun 6, 2024 •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

justinmc commented Jun 26, 2024

Uh oh!

TahaTesser commented Jul 1, 2024

Uh oh!

TahaTesser commented Jul 2, 2024

Uh oh!

Piinks commented Jul 3, 2024

Uh oh!

TahaTesser commented Jul 8, 2024

Uh oh!

justinmc left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Reland] - Enable explicitChildNodes for the AlertDialog content #149597

[Reland] - Enable explicitChildNodes for the AlertDialog content #149597

Uh oh!

Conversation

TahaTesser commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Relands #149130 (With no change for now, waiting for actual Google testing results to make any changes if needed)

Code sample

Before vs After

Pre-launch Checklist

Uh oh!

TahaTesser commented Jun 5, 2024

Uh oh!

goderbauer commented Jun 5, 2024

Uh oh!

TahaTesser commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Jun 26, 2024

Uh oh!

TahaTesser commented Jul 1, 2024

Uh oh!

TahaTesser commented Jul 2, 2024

Uh oh!

Piinks commented Jul 3, 2024

Uh oh!

TahaTesser commented Jul 8, 2024

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Reland] - Enable `explicitChildNodes` for the `AlertDialog` content #149597

[Reland] - Enable `explicitChildNodes` for the `AlertDialog` content #149597

TahaTesser commented Jun 3, 2024 •

edited

Loading

Relands #149130
(With no change for now, waiting for actual Google testing results to make any changes if needed)

TahaTesser commented Jun 6, 2024 •

edited

Loading