Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149571 at sha 52f9fda597afacacd3db9006e966d1389d4382ba

@Renzo-Olivares This is a partial reland (containing only the color change). I have no clue about the golden changes on CI?. Locally the golden changes makes sense (the squares representing the hint text are fully part of the diff because the color is not the same). But on CI, it looks like the characters are not at the same position.

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149571 at sha 28faaeb58c3f63d5116a544fa70ff5056b5a0174

@bleroux thanks for putting this together. I'll look closer at the golden changes and see what's going on with the CI.

Hi @bleroux, I couldn't find anything out of the ordinary with this PR, but I can confirm I'm also experiencing the same behavior as you when running the tests locally. Can you try pushing an empty commit without a force push to see if Gold does better with that. It sometimes gets confused when doing a force push, right now it has all the force pushes as the same patch set.

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149571 at sha 24dc9e9246b02192c743e6fca62e8fb8546bf283

Looks like that did not work. Can you try rebasing onto master in case an engine change has updated text positioning. You should probably wait until after this issue is closed #149674 before rebasing so you don't run into any failures.

I rebased but the tree is broken and there are unrelated test failures. I will try again when CI will be in better shape.

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149571 at sha 253bb6a5a2f157b53e496598be0c68130b08fe94

#149674 is resolved so I've restarted the failing CI checks

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149571 at sha 1b458e3

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149571 at sha 4c4e210

@Renzo-Olivares @Piinks I filed #149797 as an experiment to see how it impact golden, the diff seems to be ok for it.

Here I'm still trying to figure out if the diff are valid because they looks very weird.
For instance the first one seems to compare a macos screenshot to a linux-browser one.

Maybe there is something wrong with this simple change (such as the color change leaking in some way), but if it was the case I would expect a similar diff on all platforms.

Just noticed that in the golden diff that leads to the revert, the value for 'impeller' line is not the same (swiftshader vs empty).
See https://flutter-gold.skia.org/detail?grouping=name%3Dmaterial.m3_input_decorator.outline_icon_label.rtl%26source_type%3Dflutter&digest=0ebe1c484196c24b21ab16fc22738bab

We chatted offline a bit about this, Gold does not compare images according to the parameter set. It compares to the closet approved image, since there can be many.

Since this Pr has gotten into a weird state and hit almost every known gold issue, I would recommend opening a new PR, or moving forward with #149797.

Closing and I will open a new one.