Web fix odd alignment of SelectionArea Text when it's a child of a Column #149552

LimaneGaya · 2024-06-02T15:58:13Z

Fixes weird behaviour of SelectionArea when text is insite a Column or TabBarView

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
#148934 #149426

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-06-02T15:58:17Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Piinks

Hi @LimaneGaya welcome! Thanks for contributing. This will need a test to verify the expected behavior - and to make sure we don't regress it in the future!

LimaneGaya · 2024-06-04T10:34:47Z

Hi @Piinks thank you for reviewing my PR, does this look okay? for the test i was not sure how to do it but that was the only property that changed from working well and not. Please let me know if i can improve anything.

justinmc

@Renzo-Olivares Do you have any context on this or is this a web thing?

@LimaneGaya You have an analyzer failure, can you take a look at that in the CI checks below?

justinmc · 2024-06-06T21:41:44Z

packages/flutter/test/widgets/selectable_region_test.dart

    skip: kIsWeb, // [intended] Web uses its native context menu.
  );

+


Nit: Too many newlines here.

Thank you @justinmc for reviewing, i deleted those empty spaces.

Renzo-Olivares · 2024-06-07T18:05:04Z

packages/flutter/test/widgets/selectable_region_test.dart

    skip: kIsWeb, // [intended] Web uses its native context menu.
  );

+  testWidgets('Ensure consistent layout of SelectionArea children between platforms', (WidgetTester tester) async {


This test passes on the latest master, so I think it should probably be more involved. I think making tests similar to the code samples in the related issues is a good place to start. Mainly the test should verify that the previously broken behavior is no longer broken. I think for this issue #148934 it is sufficient to verify that the Text widgets all begin at the same x axis Offset.

Renzo-Olivares · 2024-06-07T18:09:07Z

packages/flutter/lib/src/widgets/_platform_selectable_region_context_menu_web.dart

+      // Setting fit to StackFit.passthrough will prevent the child from misaligning on web
+      // and be consist with other platforms.
+      fit: StackFit.passthrough,
      alignment: Alignment.center,


I'm not entirely sure about the origins of why we set the alignment to Alignment.center here. I tried removing it and didn't notice any glaring issues. cc @chunhtai if you had any context on this.

Renzo-Olivares · 2024-06-07T18:10:37Z

packages/flutter/lib/src/widgets/_platform_selectable_region_context_menu_web.dart

  Widget build(BuildContext context) {
    return Stack(
+      // Setting fit to StackFit.passthrough will prevent the child from misaligning on web
+      // and be consist with other platforms.


nit: consist -> consistent.

This PR was generated by `flutter update-packages --force-upgrade`.

…149865) flutter/engine@5a0a499...fea8e51 2024-06-06 [email protected] Roll Dart SDK from 8e05acb354f5 to ed2b917b266d (1 revision) (flutter/engine#53262) 2024-06-06 [email protected] [Impeller] Round out extreme angles between curve polyline segments. (flutter/engine#53210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…149867) flutter/engine@fea8e51...5d5e0ee 2024-06-06 [email protected] Roll Skia from c1aae20f1c82 to a42ff08f2b2e (1 revision) (flutter/engine#53263) 2024-06-06 [email protected] Reland "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering #53072" (flutter/engine#53256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…149870) flutter/engine@5d5e0ee...47b15df 2024-06-07 [email protected] Roll Dart SDK from ed2b917b266d to 41acb19a67b5 (1 revision) (flutter/engine#53266) 2024-06-07 [email protected] Roll Skia from a42ff08f2b2e to b3aedcf27979 (1 revision) (flutter/engine#53265) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…149871) flutter/engine@47b15df...087feab 2024-06-07 [email protected] Roll Skia from b3aedcf27979 to a7ee8897c66e (1 revision) (flutter/engine#53267) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Applies 02d5286 to MacOS. I'm hoping this will fix: * #148955

Contributes to #130459 It adds a test for - `examples/api/lib/material/floating_action_button_location/standard_fab_location.0.dart`

Contributes to #130459 It adds a test for - `examples/api/lib/material/dropdown_menu/dropdown_menu.1.dart`

Work towards flutter/devtools#7894 The Flutter DevTools team is working on a new Widget Inspector. As part of this work, we need to make adjusts to the widget inspector service API. This PR simply re-factors the `widget_inspector_test` in preparation for this work, to make it easier for us to modify the tests / add new tests. Although this PR is large (`widget_inspector_test` is over 5000 lines!!), it does not change any of the current test logic. Instead it: - Moves test cases that were prefixed with "WidgetInspectorService" into the pre-existing group named "WidgetInspectorService" - Moves tests cases in that group which were skipped with `!WidgetInspectorService.instance.isWidgetCreationTracked() // [intended] Test requires --track-widget-creation flag` into a group called "Requires flag --track-widget-creation" - Adds two helper functions, `pumpWidgetTreeWithABC` and `findElementABC` and uses them in all test cases that were duplicating the same widget set-up.

…149875) flutter/engine@087feab...98e9393 2024-06-07 [email protected] Roll Skia from a7ee8897c66e to 376b88815099 (1 revision) (flutter/engine#53268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…149899) flutter/engine@98e9393...1cdbebe 2024-06-07 [email protected] Roll Dart SDK from accb5c25c42a to 7b239d7f4578 (1 revision) (flutter/engine#53272) 2024-06-07 [email protected] Roll Skia from d2e17d341305 to e36110f8b451 (1 revision) (flutter/engine#53271) 2024-06-07 [email protected] Roll Skia from 376b88815099 to d2e17d341305 (2 revisions) (flutter/engine#53270) 2024-06-07 [email protected] Roll Dart SDK from 41acb19a67b5 to accb5c25c42a (1 revision) (flutter/engine#53269) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…149693)

Part of #148085

…art` (#149930)

…149944) flutter/engine@1cdbebe...45cf05f 2024-06-07 [email protected] [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 [email protected] Update Chrome to 125. (flutter/engine#53282) 2024-06-07 [email protected] Roll Dart SDK from 4b693b16eec1 to d4f17e0bf28b (1 revision) (flutter/engine#53283) 2024-06-07 [email protected] Fixes a few issues in flutter_js (flutter/engine#53231) 2024-06-07 [email protected] Roll Fuchsia Linux SDK from aVohW_hnfDaE0smBX... to zpBZmUB_JC5AjG-f4... (flutter/engine#53279) 2024-06-07 [email protected] Roll Dart SDK from 7b239d7f4578 to 4b693b16eec1 (1 revision) (flutter/engine#53277) 2024-06-07 [email protected] Roll Skia from b7f51dfcc342 to ad3c9f203f4e (1 revision) (flutter/engine#53276) 2024-06-07 [email protected] Roll Skia from 5fc83884a619 to b7f51dfcc342 (4 revisions) (flutter/engine#53275) 2024-06-07 [email protected] Revert "Widen CPU affinity set." (flutter/engine#53274) 2024-06-07 [email protected] Roll Skia from e36110f8b451 to 5fc83884a619 (1 revision) (flutter/engine#53273) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aVohW_hnfDaE to zpBZmUB_JC5A If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…visions) (#149944)" (#149960) Reverts: #149944 Initiated by: jason-simmons Reason for reverting: Regression affecting `integration_test/test/web_extension_test.dart` ``` PathNotFoundException: Cannot open file, path = '/chromium/canvaskit.wasm' (OS Error: No such file or directory, errno = 2) ``` (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745735238400976001/+/u/run_test.dart_for_web_long_running_tests_shard_and_subshard_1_5/stdout) It looks like the p Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@1cdbebe...45cf05f 2024-06-07 [email protected] [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 [email protected] Update Chrome to 125. (flutter/engine#53282) 2024-06-07 [email protected] Roll Dart SDK from 4b693b16eec1 to d4f17e0bf28b (1 revision) (flutter/engine#53283) 2024-06-07 [email protected] Fixes a few issues in flutter_js (flutter/engine#53231) 2024-06-07 [email protected] Roll Fuchsia Linux SDK from aVohW_hnfDaE0smBX... to zpBZmUB_JC5AjG-f4... (flutter/engine#53279) 2024-06-07 [email protected] Roll Dart SDK from 7b239d7f4578 to 4b693b16eec1 (1 revision) (flutter/engine#53277) 2024-06-07 [email protected] Roll Skia from b7f51dfcc342 to ad3c9f203f4e (1 revision) (flutter/engine#53276) 2024-06-07 [email protected] Roll Skia from 5fc83884a619 to b7f51dfcc342 (4 revisions) (flutter/engine#53275) 2024-06-07 [email protected] Revert "Widen CPU affinity set." (flutter/engine#53274) 2024-06-07 [email protected] Roll Skia from e36110f8b451 to 5fc83884a619 (1 revision) (flutter/engine#53273) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aVohW_hnfDaE to zpBZmUB_JC5A If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR matches the various colors of `CupertinoActionSheet` more closely with the native one. The following colors are changed. * Sheet background color * Pressed button color * Cancel button color * Pressed cancel button color * Divider color * Content text color The resulting colors match with native one with deviation of at most 1 (in terms of 0~255 RGB). The following are comparison (left to right: Native, Flutter after PR, Flutter current) <img width="1295" alt="image" src="https://github.com/flutter/flutter/assets/1596656/3703a4a8-a856-42b1-9395-a6e14b1881ca"> <img width="1268" alt="image" src="https://github.com/flutter/flutter/assets/1596656/1eb9964e-41f1-414a-99ae-0a2e7da8d3fd"> _Note: The divider thickness is adjusted to `1/dpr` instead of 0.3 in both Flutter version to make them look more native, as will be proposed in #149636 ### Derivation All the colors are derived through color picker and calculation. The algorithm is as followed: * Assume all colors are translucent grey colors, i.e. having the same value `x` for R, G, and B, with an alpha `a`. * Given the barrier color is `x_B1=0` when the background is black, and `x_B2=204` when the background is white. * Pick the target color `x_t1` when the background is black, and `x_t2` when the background is white * Solve the following equations for `x` and `a` ``` a * x + (1-a) * x_B1 = x_t1 a * x + (1-a) * x_B2 = x_t2 a = 1 - (x_t1 - x_t2) / (x_B1 - x_B2) x = (x_t1 - (1-a) * x_B1) / a ``` These equations use a linear model for color composition, which might not be exact, but is close enough for an accuracy of (1/255). The full table is as follows: <img width="1091" alt="image" src="https://github.com/flutter/flutter/assets/1596656/0fb76291-c3cc-4bb5-aefa-03ac6ac9bf1f"> * The first two columns are colors picked from XCode. * The 3~4 columns are the colors picked from the current Flutter. Notice the deviation, which is sometimes drastic. * The 5~6 columns are the colors picked from Flutter after this PR. The deviation is at most 1. * The last few columns are calculation. * There are two rows whose calculation is based on adjusted numbers, since the original results are not accurate enough, possibly due to the linear composition. During the calculation, I assumed these colors vary between light and dark modes, but it turns out that both modes use the same set of colors. ### Screenshots

…9998) This reverts commit 32081aa. Reason for revert: Appears to be failing tests in tree ``` 01:48 +2991 ~18: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/action_sheet_test.dart: Taps on a button can be slided to other buttons â��â��â�¡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â�� The following SkiaException was thrown while running async test code: Skia Gold received an unapproved image in post-submit testing. Golden file images in flutter/flutter are triaged in pre-submit during code review for the given PR. Visit https://flutter-gold.skia.org/ to view and approve the image(s), or revert the associated change. For more information, visit the wiki: https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter Debug information for Gold -------------------------------- stdout: Given image with hash 601f421e3bb643f437cc12395de96152 for test cupertino.cupertinoActionSheet.press-drag Expectation for test: ce8ef79c146857d162663b1161fd6d5c (positive) Expectation for test: 3bb57a8782f67836c6ad3ece7f00729a (positive) Expectation for test: 3f8c592774caf3c760fbbd318a7dc5af (positive) Expectation for test: 61863f38217aa3349c239eeb49b84930 (positive) Expectation for test: 98af16e9b7eb3fb810b44c74bb18ffb9 (positive) Untriaged or negative image: https://flutter-gold.skia.org//detail?grouping=name%3Dcupertino.cupertinoActionSheet.press-drag%26source_type%3Dflutter&digest=601f421e3bb643f437cc12395de96152 stderr: Test: cupertino.cupertinoActionSheet.press-drag FAIL result-state.json: No result file found. ```

Package is being transferred to the `dart-lang` github org: #141808

…ode (#149926) toString methods are removed in AOT builds by the optimization in #144763 This PR disables that for Key subclasses because some applications rely on the previous behavior. Fixes #148983

…9773) - When `--web-renderer` is omitted, keep the value `null` until it later materializes to either `canvaskit` or `skwasm`. - No more hardcoded defaults anywhere. We use `WebRendererMode.defaultForJs/defaultForWasm` instead. - When in `--wasm` mode, the JS fallback is now `canvaskit` instead of `auto`. - Add test for defaulting to `skwasm` when `--wasm` is enabled. Fixes #149826

This PR addresses an issue with TextPainter's caret position calculation for text containing full-width spaces. Currently, the caret position is not accurately calculated for strings with full-width spaces. To resolve this, the following changes have been made: Corrected the logic for caret position calculation when full-width spaces are present in the text. Added and updated test cases to ensure accurate caret position calculation. These changes ensure that the caret position for text with full-width spaces is computed correctly. This issue was introduced by the commit [a0a854a](a0a854a). Related Issue: [#149099](#149099)

These listeners were removed in b564b4c (#9143).

Notifies the engine when `PointerSignalEvents` have been ignored by the framework, through the `ui.PointerData.respond` method. This allows the web to "preventDefault" (or not) on `wheel` events. ## Issues * Fixes (partially): #139263 ## Tests * Added tests to ensure `respond` is called at the right time, with the right value. ## Demo * https://dit-multiview-scroll.web.app <details> <summary> ## Previous versions </summary> 1. Modified `PointerScrollEvent`, not shippable. 2. Modified when events were handled, instead of the opposite. </details>

flutter/packages@8a2c4e4...e95fe4a 2024-06-07 [email protected] Manual roll Flutter from 4608a89 to fc19ecf (38 revisions) (flutter/packages#6890) 2024-06-07 [email protected] [pigeon] Fix handling of null class args in C++ (flutter/packages#6881) 2024-06-07 [email protected] [video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 (flutter/packages#6535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…wasm (#149996) Dart2Wasm doesn't officially support `dart:ffi` (only a small sketchy subset needed in flutter web engine). We have seen user reporting issues where existing packages don't work with dart2wasm due to using `dart.library.ffi` in `bool.fromEnvironment` or in conditional imports and it doing the wrong thing. So we're going to make `dart.library.ffi` `false` in the compiler. We therefore update the code to detect whether it runs under wasm via a new `dart.tool.dart2wasm` environment variable. This is a preparation for the change in dart2wasm which will start making `const bool.fromEnvironment('dart.library.ffi')` return `false` instead of `true`.

b/317131589

Temporary solution for #150008.

#150037) Currently, when text is placed inside a SelectionArea widget that's nested within a Column widget, it results in misalignment, causing the text to appear centered instead of aligned as intended. This was originally #149552 but had issues with my branch. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Fixes #148934 Fixes #121053 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

flutter#150037) Currently, when text is placed inside a SelectionArea widget that's nested within a Column widget, it results in misalignment, causing the text to appear centered instead of aligned as intended. This was originally flutter#149552 but had issues with my branch. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Fixes flutter#148934 Fixes flutter#121053 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

fix web odd alignment of SelectionArea when it's a child of a Column

333a7e9

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jun 2, 2024

Piinks reviewed Jun 3, 2024

View reviewed changes

LimaneGaya added 3 commits June 3, 2024 23:52

added test

e99cedd

added comment

9dc7123

Merge branch 'master' into fix148934

57ca5e1

goderbauer requested a review from Renzo-Olivares June 4, 2024 22:05

justinmc reviewed Jun 6, 2024

View reviewed changes

LimaneGaya added 2 commits June 7, 2024 00:49

deleted new lines and trailing spaces

af9f073

Merge branch 'master' into fix148934

2d39c3e

Renzo-Olivares reviewed Jun 7, 2024

View reviewed changes

flutter-pub-roller-bot and others added 14 commits June 10, 2024 21:41

Roll pub packages (#149864)

6bfecc9

This PR was generated by `flutter update-packages --force-upgrade`.

[native_assets] Fix framework name deduplication (#149761)

ff15dd2

Applies 02d5286 to MacOS. I'm hoping this will fix: * #148955

Add test for standard_fab_location.0.dart (#149225)

e9e0341

Contributes to #130459 It adds a test for - `examples/api/lib/material/floating_action_button_location/standard_fab_location.0.dart`

Add test for dropdown_menu.1.dart (#149547)

59c896d

Contributes to #130459 It adds a test for - `examples/api/lib/material/dropdown_menu/dropdown_menu.1.dart`

Prepare images for tests individually to enable clean up of cache. (#…

0a2d301

…149693)

Shift consistently passing tests on mokey to prod (#149902)

f5e8440

Part of #148085

elliette and others added 16 commits June 10, 2024 21:41

Refactor getRootWidgetSummaryTree tests in `widget_inspector_test.d…

2c69b15

…art` (#149930)

Remove package:platform from issue template (#149995)

cd0595a

Package is being transferred to the `dart-lang` github org: #141808

Retain the toString method for subclasses of Key in profile/release m…

34a0324

…ode (#149926) toString methods are removed in AOT builds by the optimization in #144763 This PR disables that for Key subclasses because some applications rely on the previous behavior. Fixes #148983

Cut no-longer-accurate microtask reference in finalizeTree doc (#149941)

44c56c3

These listeners were removed in b564b4c (#9143).

Fixes TextField hinttext in a11y_assessment (#150007)

50beb97

b/317131589

Temporarily run Mac_arm64 framework_tests_misc on only Mac-13 (#150009)

d006f9c

Temporary solution for #150008.

LimaneGaya closed this Jun 10, 2024

LimaneGaya deleted the fix148934 branch June 10, 2024 20:56

LimaneGaya mentioned this pull request Jun 11, 2024

made SelectionArea alignment consistent between web and other platform #150037

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Web fix odd alignment of SelectionArea Text when it's a child of a Column #149552

Web fix odd alignment of SelectionArea Text when it's a child of a Column #149552

Uh oh!

LimaneGaya commented Jun 2, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jun 2, 2024

Uh oh!

Piinks left a comment

Uh oh!

LimaneGaya commented Jun 4, 2024

Uh oh!

justinmc left a comment •

edited

Loading

Uh oh!

justinmc Jun 6, 2024

Uh oh!

LimaneGaya Jun 7, 2024

Uh oh!

Renzo-Olivares Jun 7, 2024

Uh oh!

Renzo-Olivares Jun 7, 2024

Uh oh!

Renzo-Olivares Jun 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		skip: kIsWeb, // [intended] Web uses its native context menu.
		);

Web fix odd alignment of SelectionArea Text when it's a child of a Column #149552

Web fix odd alignment of SelectionArea Text when it's a child of a Column #149552

Uh oh!

Conversation

LimaneGaya commented Jun 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jun 2, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

LimaneGaya commented Jun 4, 2024

Uh oh!

justinmc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

LimaneGaya Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

LimaneGaya commented Jun 2, 2024 •

edited

Loading

justinmc left a comment •

edited

Loading