Update old wiki links #149544

Piinks · 2024-06-01T23:46:18Z

Part of #145009

Finishes updating links in the repo that pointed to the old wiki

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

.github/ISSUE_TEMPLATE/7_cherry_pick.yml

.github/ISSUE_TEMPLATE/8_design_doc.yml

.github/PR_TEMPLATE/PULL_REQUEST_CP_TEMPLATE.md

.github/workflows/easy-cp.yml

dev/conductor/core/lib/src/globals.dart

dev/integration_tests/web_e2e_tests/README.md

dev/tools/update_icons.dart

docs/contributing/testing/Writing-a-golden-file-test-for-package-flutter.md

packages/flutter_tools/test/general.shard/project_test.dart

packages/flutter_tools/test/commands.shard/permeable/create_test.dart

packages/flutter_tools/pubspec.yaml

packages/flutter/test/painting/decoration_image_lerp_test.dart

packages/flutter/pubspec.yaml

packages/flutter/lib/src/material/icons.dart

packages/analysis_options.yaml

dev/bots/test/analyze-test-input/root/packages/foo/bad_repository_links.dart

…ory_links.dart

stuartmorgan-g

LGTM, but one question about main vs master.

stuartmorgan-g · 2024-06-03T15:27:37Z

.github/ISSUE_TEMPLATE/7_cherry_pick.yml

      description: >-
        Explain this CP in less than 80 characters that is accessible to most Flutter developers
-        See https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices for examples
+        See https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md for examples


Do we really want to link to main everywhere? Don't edits still have to be made to master, making it harder to edit if we link to main?

Yeah, this really annoyed me. I feel like if we put main, we're more likely to get PRs opened against main.
However, our analyzer script (only in flutter/flutter) enforces using main and does not allow master.

When I first put up this PR is was all master, and then I changed it to main to make CI happy. We don't do it that other repos. It feels like a footgun for contributors. 🤷

Weird! Hopefully our bot that changes branch targets will auto-fix that when people open PRs.

However, our analyzer script (only in flutter/flutter) enforces using main and does not allow master.

Can we change the script instead?

However, our analyzer script (only in flutter/flutter) enforces using main and does not allow master.

Can we change the script instead?

Oh can we? It looks like it's fairly recent, added in #146882 as part of #121564. But if that issue is not actively being worked on, maybe we can revert this analyzer bit.

There is already quite a list of exempt repos.. because they don't have a main branch.

flutter/dev/bots/analyze.dart

Lines 1303 to 1320 in a92318d

const Set<String> repoExceptions = <String>{

'bdero/flutter-gpu-examples',

'chromium/chromium',

'clojure/clojure',

'dart-lang/test', // TODO(guidezpl): remove when https://github.com/dart-lang/test/issues/2209 is closed

'dart-lang/webdev',

'eseidelGoogle/bezier_perf',

'flutter/devtools', // TODO(guidezpl): remove when https://github.com/flutter/devtools/issues/7551 is closed

'flutter/flutter_gallery_assets', // TODO(guidezpl): remove when subtask in https://github.com/flutter/flutter/issues/121564 is complete

'flutter/flutter-intellij', // TODO(guidezpl): remove when https://github.com/flutter/flutter-intellij/issues/7342 is closed

'flutter/platform_tests', // TODO(guidezpl): remove when subtask in https://github.com/flutter/flutter/issues/121564 is complete

'flutter/web_installers',

'glfw/glfw',

'GoogleCloudPlatform/artifact-registry-maven-tools',

'material-components/material-components-android', // TODO(guidezpl): remove when https://github.com/material-components/material-components-android/issues/4144 is closed

'torvalds/linux',

'tpn/winsdk-10',

};

Lemme take a look

Added 'flutter/flutter' with a TODO and link to the tracking issue, which is currently unassigned

Circling back on this, I won't change all of the instance of main in this PR, since that will put us in a mixed state with all the other main links we previously enforced. I'll send another PR that switches all instances back to master if that is what we'd like to do.

CONTRIBUTING.md

auto-submit · 2024-06-17T16:32:23Z

auto label is removed for flutter/flutter/149544, due to - The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

dev/bots/analyze.dart

auto-submit · 2024-06-17T17:13:49Z

auto label is removed for flutter/flutter/149544, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter/flutter@5187cab...ccf3abe 2024-06-17 [email protected] Roll Flutter Engine from 2218a4566765 to 5989f0215fed (9 revisions) (flutter/flutter#150373) 2024-06-17 [email protected] Update API docs footer (flutter/flutter#150347) 2024-06-17 [email protected] Update old wiki links (flutter/flutter#149544) 2024-06-17 [email protected] Fix flaky complex_layout_scroll_perf__memory & flutter_gallery__memory_nav (flutter/flutter#150368) 2024-06-17 [email protected] Roll Packages from dd04ab1 to 711b4ac (3 revisions) (flutter/flutter#150359) 2024-06-17 [email protected] Roll Flutter Engine from 9779c273aac3 to 2218a4566765 (3 revisions) (flutter/flutter#150298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Update old wiki links

2156275

Piinks requested a review from christopherfujino as a code owner June 1, 2024 23:46

Piinks commented Jun 2, 2024

View reviewed changes

Apply suggestions from code review

4598af7

Piinks commented Jun 2, 2024

View reviewed changes

Piinks added 2 commits June 2, 2024 13:46

Update packages/analysis_options.yaml

f8c593d

Updates

c17cd78

Piinks commented Jun 2, 2024

View reviewed changes

dev/bots/test/analyze-test-input/root/packages/foo/bad_repository_links.dart Outdated Show resolved Hide resolved

Update dev/bots/test/analyze-test-input/root/packages/foo/bad_reposit…

db69eca

…ory_links.dart

This comment was marked as outdated.

Sign in to view

flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 2, 2024

Piinks removed the will affect goldens Changes to golden files label Jun 2, 2024

stuartmorgan-g approved these changes Jun 3, 2024

View reviewed changes

add flutter/flutter to master branch allowlist

cccd91e

Piinks mentioned this pull request Jun 6, 2024

[Proposal] Relocate and Rename Changelog to CHANGELOG.md in Flutter/Flutter Repository #149815

Closed

Piinks commented Jun 17, 2024

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

Piinks added 2 commits June 17, 2024 11:20

Apply suggestions from code review

1afd2f0

Merge branch 'master' into wikiLinks

343e4be

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

Piinks commented Jun 17, 2024

View reviewed changes

dev/bots/analyze.dart Outdated Show resolved Hide resolved

Update dev/bots/analyze.dart

a630544

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

auto-submit bot merged commit 62586dc into flutter:master Jun 17, 2024

engine-flutter-autoroll mentioned this pull request Jun 17, 2024

Roll Flutter from 5187cab7bdd4 to 62586dc09dcb (4 revisions) flutter/packages#6939

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2024

62586dc Update old wiki links (flutter/flutter#149544)

8042325

engine-flutter-autoroll mentioned this pull request Jun 17, 2024

Roll Flutter from 5187cab7bdd4 to ccf3abe94047 (6 revisions) flutter/packages#6940

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2024

62586dc Update old wiki links (flutter/flutter#149544)

2b73fe2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

62586dc Update old wiki links (flutter/flutter#149544)

f95c8c2

	const Set<String> repoExceptions = <String>{
	'bdero/flutter-gpu-examples',
	'chromium/chromium',
	'clojure/clojure',
	'dart-lang/test', // TODO(guidezpl): remove when https://github.com/dart-lang/test/issues/2209 is closed
	'dart-lang/webdev',
	'eseidelGoogle/bezier_perf',
	'flutter/devtools', // TODO(guidezpl): remove when https://github.com/flutter/devtools/issues/7551 is closed
	'flutter/flutter_gallery_assets', // TODO(guidezpl): remove when subtask in https://github.com/flutter/flutter/issues/121564 is complete
	'flutter/flutter-intellij', // TODO(guidezpl): remove when https://github.com/flutter/flutter-intellij/issues/7342 is closed
	'flutter/platform_tests', // TODO(guidezpl): remove when subtask in https://github.com/flutter/flutter/issues/121564 is complete
	'flutter/web_installers',
	'glfw/glfw',
	'GoogleCloudPlatform/artifact-registry-maven-tools',
	'material-components/material-components-android', // TODO(guidezpl): remove when https://github.com/material-components/material-components-android/issues/4144 is closed
	'torvalds/linux',
	'tpn/winsdk-10',
	};

Update old wiki links #149544

Update old wiki links #149544

Uh oh!

Conversation

Piinks commented Jun 1, 2024

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submit bot commented Jun 17, 2024

Uh oh!

Uh oh!

auto-submit bot commented Jun 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants