Add tests for scaffold drawer and end drawer #149383

ValentinVignal · 2024-05-31T03:53:23Z

Contributes to #130459

It adds a test for

examples/api/lib/material/scaffold/scaffold.drawer.0.dart
examples/api/lib/material/scaffold/scaffold.end_drawer.0.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux

LGTM with some formatting nits to correct.
Thanks for the contribution!

bleroux · 2024-06-05T12:06:29Z

examples/api/test/material/scaffold/scaffold.end_drawer.0_test.dart

Suggested change

expect(tester.getCenter(

find.byType(Drawer)).dx,

greaterThan(400), reason: 'The drawer should be on the right side of the screen',

);

expect(

tester.getCenter(find.byType(Drawer)).dx,

greaterThan(400),

reason: 'The drawer should be on the right side of the screen',

);

bleroux · 2024-06-05T12:07:27Z

examples/api/test/material/scaffold/scaffold.end_drawer.0_test.dart

Suggested change

expect(tester.getCenter(

find.byType(EndDrawerButton)).dx,

greaterThan(400), reason: 'The drawer button should be on the right side of the app bar',

);

expect(

tester.getCenter(find.byType(EndDrawerButton)).dx,

greaterThan(400),

reason: 'The drawer button should be on the right side of the app bar',

);

bleroux · 2024-06-05T12:08:22Z

examples/api/test/material/scaffold/scaffold.drawer.0_test.dart

Suggested change

expect(tester.getCenter(

find.byType(Drawer)).dx,

lessThan(400), reason: 'The drawer should be on the left side of the screen',

);

expect(

tester.getCenter(find.byType(Drawer)).dx,

lessThan(400),

reason: 'The drawer should be on the left side of the screen',

);

bleroux · 2024-06-05T12:08:55Z

examples/api/test/material/scaffold/scaffold.drawer.0_test.dart

Suggested change

expect(tester.getCenter(

find.byType(DrawerButton)).dx,

lessThan(400), reason: 'The drawer button should be on the left side of the app bar',

);

expect(

tester.getCenter(find.byType(DrawerButton)).dx,

lessThan(400),

reason: 'The drawer button should be on the left side of the app bar',

);

bleroux · 2024-06-05T12:09:13Z

examples/api/test/material/scaffold/scaffold.drawer.0_test.dart

Suggested change

// Closes the drawer by tapping outside the drawer

// Closes the drawer by tapping outside the drawer.

bleroux · 2024-06-05T12:10:15Z

examples/api/test/material/scaffold/scaffold.end_drawer.0_test.dart

Suggested change

// Closes the drawer by tapping outside the drawer

// Closes the drawer by tapping outside the drawer.

TahaTesser · 2024-06-06T07:48:45Z

examples/api/test/material/scaffold/scaffold.drawer.0_test.dart

+    );
+    expect(find.text('This is the Drawer'), findsOne);
+
+    // Closes the drawer by tapping the button inside the drawer.


Suggested change

// Closes the drawer by tapping the button inside the drawer.

// Close the drawer by tapping the button inside the drawer.

TahaTesser · 2024-06-06T07:48:52Z

examples/api/test/material/scaffold/scaffold.drawer.0_test.dart

+
+    expect(find.byType(Drawer), findsNothing);
+
+    // Opens the drawer by tapping the drawer button in the app bar.


Suggested change

// Opens the drawer by tapping the drawer button in the app bar.

// Open the drawer by tapping the drawer button in the app bar.

TahaTesser · 2024-06-06T07:49:13Z

examples/api/test/material/scaffold/scaffold.drawer.0_test.dart

+    expect(find.byType(Drawer), findsOne);
+    expect(find.text('This is the Drawer'), findsOne);
+
+    // Closes the drawer by tapping outside the drawer.


Suggested change

// Closes the drawer by tapping outside the drawer.

// Close the drawer by tapping outside the drawer.

TahaTesser · 2024-06-06T07:49:22Z

examples/api/test/material/scaffold/scaffold.end_drawer.0_test.dart

+
+    expect(find.byType(Drawer), findsNothing);
+
+    // Opens the drawer by tapping the button at the center of the screen.


Suggested change

// Opens the drawer by tapping the button at the center of the screen.

// Open the drawer by tapping the button at the center of the screen.

TahaTesser · 2024-06-06T07:49:29Z

examples/api/test/material/scaffold/scaffold.end_drawer.0_test.dart

+    );
+    expect(find.text('This is the Drawer'), findsOne);
+
+    // Closes the drawer by tapping the button inside the drawer.


Suggested change

// Closes the drawer by tapping the button inside the drawer.

// Close the drawer by tapping the button inside the drawer.

TahaTesser · 2024-06-06T07:49:33Z

examples/api/test/material/scaffold/scaffold.end_drawer.0_test.dart

+
+    expect(find.byType(Drawer), findsNothing);
+
+    // Opens the drawer by tapping the drawer button in the app bar.


Suggested change

// Opens the drawer by tapping the drawer button in the app bar.

// Open the drawer by tapping the drawer button in the app bar.

TahaTesser · 2024-06-06T07:49:42Z

examples/api/test/material/scaffold/scaffold.end_drawer.0_test.dart

+    expect(find.byType(Drawer), findsOne);
+    expect(find.text('This is the Drawer'), findsOne);
+
+    // Closes the drawer by tapping outside the drawer.


Suggested change

// Closes the drawer by tapping outside the drawer.

// Close the drawer by tapping outside the drawer.

flutter-dashboard · 2024-06-06T07:53:00Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #149383 at sha 40ef7ab

…-drawer-and-end-drawer

TahaTesser

LGTM

This reverts commit aad70e5.

…#149383)

Reverts #149383 as it caused failure for mac framework_tests_impeller.

bleroux · 2024-06-11T15:19:24Z

@ValentinVignal This was reverted due to an infra failure.
Nothing wrong with your PR, but there is a bad infra failure since last week.
Thank you to file this PR again and, before landing it, we will wait for #149851 to be fixed.

ValentinVignal · 2024-06-11T15:37:59Z

Sure, I'll do that

ValentinVignal · 2024-06-11T15:40:18Z

Here it is @bleroux #150047

…#149383)

flutter/flutter@32081aa...14df7be 2024-06-11 [email protected] Revert "Add tests for scaffold drawer and end drawer" (flutter/flutter#150045) 2024-06-11 [email protected] Add tests for scaffold drawer and end drawer (flutter/flutter#149383) 2024-06-11 [email protected] Add high-contrast theme (flutter/flutter#149779) 2024-06-11 [email protected] Manual Pub Roll (flutter/flutter#150025) 2024-06-10 [email protected] [docs] Per-platform desktop triage instructions (flutter/flutter#150019) 2024-06-10 [email protected] Fix copy-paste-o in MethodChannel.invokeListMethod doc (flutter/flutter#149976) 2024-06-10 [email protected] Unpin `camera_android` and remove its only usage (flutter/flutter#150017) 2024-06-10 [email protected] Fixes a bug where NavigatorState.pop does not consider any possible sâ�¦ (flutter/flutter#150014) 2024-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: [CupertinoActionSheet] Match colors to native (#149568) (#150015)" (flutter/flutter#150021) 2024-06-10 [email protected] Reland: [CupertinoActionSheet] Match colors to native (#149568) (flutter/flutter#150015) 2024-06-10 [email protected] Temporarily run Mac_arm64 framework_tests_misc on only Mac-13 (flutter/flutter#150009) 2024-06-10 [email protected] Fixes TextField hinttext in a11y_assessment (flutter/flutter#150007) 2024-06-10 [email protected] Use const bool.fromEnvironment("dart.tool.dart2wasm") to detect dart2wasm (flutter/flutter#149996) 2024-06-10 [email protected] Roll Packages from 8a2c4e4 to e95fe4a (3 revisions) (flutter/flutter#149997) 2024-06-10 [email protected] [web] Notify engine of handled PointerScrollEvents. (flutter/flutter#145500) 2024-06-10 [email protected] Cut no-longer-accurate microtask reference in finalizeTree doc (flutter/flutter#149941) 2024-06-10 [email protected] Update hasTrailingSpaces (flutter/flutter#149698) 2024-06-10 [email protected] [web] Change `--web-renderer` default from `auto` to `canvaskit` (flutter/flutter#149773) 2024-06-10 [email protected] Retain the toString method for subclasses of Key in profile/release mode (flutter/flutter#149926) 2024-06-10 [email protected] Remove package:platform from issue template (flutter/flutter#149995) 2024-06-10 [email protected] Revert "[CupertinoActionSheet] Match colors to native (#149568)" (flutter/flutter#149998) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…#149383)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 31, 2024

goderbauer requested review from TahaTesser and bleroux June 4, 2024 22:05

bleroux approved these changes Jun 5, 2024

View reviewed changes

ValentinVignal added 2 commits June 6, 2024 09:12

test: Add test for scaffold drawer and end drawer

cfd59a4

style: Format code and comments

40ef7ab

bleroux force-pushed the flutter/api/example/Add-tests-for-scaffold-drawer-and-end-drawer branch from 60feecf to 40ef7ab Compare June 6, 2024 07:12

TahaTesser requested changes Jun 6, 2024

View reviewed changes

flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 6, 2024

ValentinVignal and others added 2 commits June 6, 2024 15:56

style: Remove extra 's'

ffe811b

Merge branch 'master' into flutter/api/example/Add-tests-for-scaffold…

af516df

…-drawer-and-end-drawer

ValentinVignal requested a review from TahaTesser June 10, 2024 10:01

TahaTesser approved these changes Jun 10, 2024

View reviewed changes

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2024

auto-submit bot merged commit aad70e5 into flutter:master Jun 11, 2024

yaakovschectman added a commit that referenced this pull request Jun 11, 2024

Revert "Add tests for scaffold drawer and end drawer (#149383)"

5c93637

This reverts commit aad70e5.

yaakovschectman mentioned this pull request Jun 11, 2024

Revert "Add tests for scaffold drawer and end drawer" #150045

Merged

engine-flutter-autoroll mentioned this pull request Jun 11, 2024

Roll Flutter from 32081aab69f8 to aad70e5cdb8e (20 revisions) flutter/packages#6906

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2024

aad70e5 Add tests for scaffold drawer and end drawer (flutter/flutter…

b8c3a3e

…#149383)

yaakovschectman added a commit that referenced this pull request Jun 11, 2024

Revert "Add tests for scaffold drawer and end drawer" (#150045)

14df7be

Reverts #149383 as it caused failure for mac framework_tests_impeller.

engine-flutter-autoroll mentioned this pull request Jun 11, 2024

Roll Flutter from 32081aab69f8 to 14df7be3f947 (21 revisions) flutter/packages#6907

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2024

aad70e5 Add tests for scaffold drawer and end drawer (flutter/flutter…

70db429

…#149383)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

aad70e5 Add tests for scaffold drawer and end drawer (flutter/flutter…

fb9459e

…#149383)

-    expect(tester.getCenter(
-      find.byType(Drawer)).dx,
-      greaterThan(400), reason: 'The drawer should be on the right side of the screen',
-    );
+    expect(
+      tester.getCenter(find.byType(Drawer)).dx,
+      greaterThan(400),
+      reason: 'The drawer should be on the right side of the screen',
+    );

-    expect(tester.getCenter(
-      find.byType(EndDrawerButton)).dx,
-      greaterThan(400), reason: 'The drawer button should be on the right side of the app bar',
-    );
+    expect(
+      tester.getCenter(find.byType(EndDrawerButton)).dx,
+      greaterThan(400),
+      reason: 'The drawer button should be on the right side of the app bar',
+    );

-    expect(tester.getCenter(
-      find.byType(DrawerButton)).dx,
-      lessThan(400), reason: 'The drawer button should be on the left side of the app bar',
-    );
+    expect(
+      tester.getCenter(find.byType(DrawerButton)).dx,
+      lessThan(400),
+      reason: 'The drawer button should be on the left side of the app bar',
+    );

	// Closes the drawer by tapping outside the drawer
	// Closes the drawer by tapping outside the drawer.

	// Closes the drawer by tapping the button inside the drawer.
	// Close the drawer by tapping the button inside the drawer.


		expect(find.byType(Drawer), findsNothing);

		// Opens the drawer by tapping the drawer button in the app bar.

	// Opens the drawer by tapping the drawer button in the app bar.
	// Open the drawer by tapping the drawer button in the app bar.

	// Closes the drawer by tapping outside the drawer.
	// Close the drawer by tapping outside the drawer.


		expect(find.byType(Drawer), findsNothing);

		// Opens the drawer by tapping the button at the center of the screen.

	// Opens the drawer by tapping the button at the center of the screen.
	// Open the drawer by tapping the button at the center of the screen.

Add tests for scaffold drawer and end drawer #149383

Add tests for scaffold drawer and end drawer #149383

Uh oh!

Conversation

ValentinVignal commented May 31, 2024

Pre-launch Checklist

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Jun 6, 2024

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux commented Jun 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ValentinVignal commented Jun 11, 2024

Uh oh!

ValentinVignal commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bleroux commented Jun 11, 2024 •

edited

Loading