Skip to content

Wire up SemanticsAction.focus to the framework #149374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
May 31, 2024
Merged

Wire up SemanticsAction.focus to the framework #149374

auto-submit merged 3 commits into from
May 31, 2024

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented May 31, 2024 •
edited
Loading

Wire up SemanticsAction.focus to Semantics and CustomPaint. Reenable respective tests, and add focus tests to them.

Contributes to a fix for #83809

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels May 31, 2024
@yjbanov yjbanov changed the title Restore semantics action tests Wire up SemanticsAction.focus to the framework May 31, 2024
@yjbanov yjbanov marked this pull request as ready for review May 31, 2024 16:45
@yjbanov yjbanov mentioned this pull request May 31, 2024
Closed
gspencergoog
gspencergoog approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Seems pretty straightforward.

chunhtai
chunhtai approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov yjbanov added the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2024
@auto-submit auto-submit bot merged commit 6193615 into flutter:master May 31, 2024
@yjbanov yjbanov mentioned this pull request May 31, 2024
Closed
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@yjbanov @victorsanni
Wire up SemanticsAction.focus to the framework (flutter#149374)
9c22642 
Wire up `SemanticsAction.focus` to `Semantics` and `CustomPaint`. Reenable respective tests, and add `focus` tests to them.

Contributes to a fix for flutter#83809
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
cc719e7 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
245f399 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
812f33e 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
f742e28 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
4a2fd13 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
3e75176 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
f42be71 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
69a00bb 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
4606358 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
a955dd8 
…er#149374)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
9336443 
…er#149374)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
6193615 Wire up SemanticsAction.focus to the framework (flutter/flutt…
801a579 
…er#149374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@chunhtai chunhtai chunhtai approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yjbanov @gspencergoog @chunhtai