Skip to content

Make the pub roller bot re-generate gradle lockfiles #149355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Aug 26, 2024
Merged

Make the pub roller bot re-generate gradle lockfiles #149355

auto-submit merged 5 commits into from
Aug 26, 2024

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented May 30, 2024 •
edited
Loading

Fixes #142475

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@andrewkolos andrewkolos mentioned this pull request Jun 18, 2024
Closed
@goderbauer
Copy link
Member

goderbauer commented Aug 13, 2024

(triage): I spoke to @gmackall last week and he says this is still on his radar.

@goderbauer goderbauer mentioned this pull request Aug 22, 2024
Merged
@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 23, 2024

@gmackall FYI, I updated this branch. Turned into somewhat of a yak shave, but I updated generate_gradle_lockfiles.dart to no longer require the android directories via stdin (since that would have been awkward to pipe from the packages_autoroller.dart script) and just taught it to discover these all itself.

@gmackall
Copy link
Member Author

gmackall commented Aug 23, 2024

@gmackall FYI, I updated this branch. Turned into somewhat of a yak shave, but I updated generate_gradle_lockfiles.dart to no longer require the android directories via stdin (since that would have been awkward to pipe from the packages_autoroller.dart script) and just taught it to discover these all itself.

Wow, thanks for taking the time to do that! This looks great to me, but I can't technically approve because it is my PR

@gmackall gmackall marked this pull request as ready for review August 23, 2024 19:42
christopherfujino
christopherfujino approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2024
@auto-submit auto-submit bot merged commit 7362d07 into flutter:master Aug 26, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
bdc108c 
…/flutter#149355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
2231bf8 
…/flutter#149355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
f3c1e5b 
…/flutter#149355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
3f00140 
…/flutter#149355)
@christopherfujino christopherfujino mentioned this pull request Aug 27, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
615628a 
…/flutter#149355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
262d8d4 
…/flutter#149355)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 27, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
8f34ec3 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
c1ced78 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
e3ea83b 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
abab4e4 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
7c02d9f 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
138b8a3 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
2da94f8 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
a5c3b64 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
55bf60f 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
74b92ed 
…/flutter#149355)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@gmackall @Buchimi
Make the pub roller bot re-generate gradle lockfiles (flutter#149355)
29ea9e8 
Fixes flutter#142475
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
60c029c 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
b2c8167 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
17789ba 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
5635cae 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
ab9b577 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
118ef53 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
00327c9 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
1164fd6 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
2db2115 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
7632872 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
35b2d1d 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
c59e3b9 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
2f0ce81 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
27d7082 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
16a0fe2 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
4cd72fc 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
ab798af 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
ae282a6 
…/flutter#149355)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
7362d07 Make the pub roller bot re-generate gradle lockfiles (flutter…
a83054d 
…/flutter#149355)
@gmackall gmackall mentioned this pull request Nov 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

generate_gradle_lockfiles is not run on CI

3 participants

@gmackall @goderbauer @christopherfujino