Adding a default case to unblock engine roll. #149353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
zanderso
approved these changes
May 30, 2024
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
LGTM w/ issue filed for follow-up
yjbanov
approved these changes
May 30, 2024
| case SemanticsAction.showOnScreen: | ||
| case SemanticsAction.tap: | ||
| semanticsOwner.performAction(expectedId, action); | ||
| // Add the default case temporarily to unblock engine roll. |
Contributor
There was a problem hiding this comment.
Can you please make these TODOs in the style I did here? https://github.com/flutter/flutter/pull/149274/files
It will make it easier for me to undo later.
| case SemanticsAction.showOnScreen: | ||
| case SemanticsAction.tap: | ||
| semanticsOwner.performAction(expectedId, action); | ||
| // Add the default case temporarily to unblock engine roll. |
Contributor
Author
|
Force-merging to unblock the engine roll. |
yjbanov
added a commit
to yjbanov/flutter
that referenced
this pull request
May 31, 2024
This reverts commit 557a959.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #149274