[CP-stable] Add frame number and widget location map service extension #149345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…48702) This helps us add widget rebuild counts to the DevTools performance page: flutter/devtools#4564
Author
|
@kenzieschmoll please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
the
framework
Contributor
|
@mossmana fyi. |
Member
|
@itsjustkevin I saw the CP for DevTools 2.36.0 was approved and the CL was merged: #149345. This Flutter CP is a requirement for DevTools 2.36.0 to work properly - is this CP going to be included as well? |
Contributor
|
@kenzieschmoll I didn't add it as it did not yet have an approval, let's get this updated and merged. |
itsjustkevin
approved these changes
Jun 5, 2024
christopherfujino
changed the title
itsjustkevin
added
cp: approved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
DevTools release 2.36.0: https://dart-review.googlesource.com/c/sdk/+/368762
Changelog Description:
This change adds a service extension that DevTools uses to support a "Track widget build counts" feature. This feature is first included in DevTools 2.36.0.
Impact Description:
This service extension is required for DevTools 2.36.0, which needs to be cherry-picked into the Dart SDK. This beta release of DevTools missed the code cutoff because we were targeting the date listed on go/dash-team-releases (5/29). Since the beta release went out early, we missed the cut off and need to cherry-pick.
Since this DevTools release depended on the changes from #148702, we also need to cherry pick those changes into the flutter beta channel.
Workaround:
No. This is required for DevTools 2.36.0 to work properly: https://dart-review.googlesource.com/c/sdk/+/368762.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
With this change, a flutter app connecting to DevTools 2.36.0 (already on the Dart SDK main branch and trying to CP into the Dart SDK beta branch) will be able to use the "Track widget build counts" feature in DevTools.