Manual pub roll w/ gradle lockfile regeneration #149342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
gmackall
commented
May 30, 2024
Member
Author
There was a problem hiding this comment.
cc @christopherfujino if you have any pointers, I think you encountered this (changes to these stock strings that fail analysis) in the past in #145564, and said you "fixed analysis and checked it in" but I don't know what that means in this context
Contributor
There was a problem hiding this comment.
I think I gave up on this because it turned into a yak shave. I would recommend just reverting the diffs to three dart files here as a workaround.
I believe @andrewkolos has a PR open that would fix this, although as I recall this is a subtly tricky problem to solve.
Member
Author
There was a problem hiding this comment.
Sounds good, I'll revert
Contributor
There was a problem hiding this comment.
(FYI) I filed #149386 and will be trying to resolve this.
Closed
andrewkolos
added
the
autosubmit
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
Manual recreation of flutter#148911 Entire PR is just the output of ``` flutter update-packages --force-upgrade ``` followed by (run from the root of the flutter repo) ``` find . -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart --no-gradle-generation --no-exclusion ```
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
Closed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual recreation of #148911
Entire PR is just the output of
followed by (run from the root of the flutter repo)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.