-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Reverts "Enable explicitChildNodes for the AlertDialog content (#149130)"
#149333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 1 commit into
master
from
revert_6a0e0bfdc5f86c84b3499dfb0943418588f3b6c0
May 30, 2024
Merged
Reverts "Enable explicitChildNodes for the AlertDialog content (#149130)"
#149333
auto-submit
merged 1 commit into
master
from
revert_6a0e0bfdc5f86c84b3499dfb0943418588f3b6c0
May 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
approved these changes
May 30, 2024
Piinks
reviewed
May 30, 2024
Contributor
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM post hoc
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 30, 2024
…ntent (#149130)" (flutter/flutter#149333)
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149130)" (flutter#149333) Reverts: flutter#149130 Initiated by: Piinks Reason for reverting: Google testing did not run on this PR and multiple semantics screen shots from internal testing look incorrect. Original PR Author: TahaTesser Reviewed By: {goderbauer} This change reverts the following previous change: fixes [AlertDialog content semantics merged](flutter#147574) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, // showSemanticsDebugger: true, home: Scaffold( body: SafeArea( child: Center( child: Column( mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: <Widget>[ const Column( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ Text('Some text'), Text('More text'), ], ), Builder(builder: (BuildContext context) { return ElevatedButton( onPressed: () { showDialog<void>( context: context, builder: (BuildContext context) { return AlertDialog( title: const Text('Dialog Title'), content: const Column( children: <Widget>[ Text('Some text'), Text('More text'), ], ), actions: <Widget>[ TextButton( onPressed: () { Navigator.of(context).pop(); }, child: const Text('Close'), ), ], ); }, ); }, child: const Text('Open Dialog'), ); }), ], ), ), ), ), ); } } ``` </details> ### Before vs After  
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
…ntent (#149130)" (flutter/flutter#149333)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
…ntent (#149130)" (flutter/flutter#149333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
revert of
Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #149130
Initiated by: Piinks
Reason for reverting: Google testing did not run on this PR and multiple semantics screen shots from internal testing look incorrect.
Original PR Author: TahaTesser
Reviewed By: {goderbauer}
This change reverts the following previous change:
fixes AlertDialog content semantics merged
Code sample
expand to view the code sample
Before vs After
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.