Skip to content

Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) #149263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 30, 2024
Merged

Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) #149263

auto-submit merged 2 commits into from
May 30, 2024

Conversation

@engine-flutter-autoroll
Copy link
Contributor

@engine-flutter-autoroll engine-flutter-autoroll commented May 29, 2024

Manual roll requested by [email protected]

flutter/engine@60968ee...8d5d14a

2024-05-29 [email protected] Manual roll Dart SDK from 641d61332238 to ef405fbe3917 (12 revisions) (flutter/engine#53089)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label May 29, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented May 29, 2024

auto label is removed for flutter/flutter/149263, due to - The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac channels_integration_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac web_tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_impeller has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux web_benchmarks_html has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux realm_checker has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux run_debug_test_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux plugin_test_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux plugin_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_plugin_light_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_plugin_fat_apk_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_java8_compile_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux gradle_desugar_classes_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux fuchsia_precache has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux_android_emu android views has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux test_ownership has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels May 29, 2024
@zanderso zanderso mentioned this pull request May 29, 2024
Closed
@eyebrowsoffire eyebrowsoffire force-pushed the flutter-engine-flutter-autoroll-fcbd6935-a5f1-4dc2-88fd-288333ab0407-1717005392 branch from 3f46828 to b910093 Compare May 29, 2024 22:47
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@jonahwilliams
Copy link
Contributor

jonahwilliams commented May 29, 2024

Adding autosubmit so this moves along...

@auto-submit auto-submit bot merged commit 697d99f into flutter:master May 30, 2024
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 30, 2024
@hello-coder-xu
Merge branch 'master' into feature/grid_delegate_add_assert
456ca38 
* master: (115 commits)
  Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) (flutter#149291)
  disable Impeller on external texture test. (flutter#149292)
  Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) (flutter#149290)
  Update 3.22.1 release notes to include missing fix. (flutter#148999)
  Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) (flutter#149263)
  Reverts "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149279)
  Unskip expression evaluation test (flutter#149253)
  temporarily disable SemanticsAction tests to unblock engine change (flutter#149274)
  Adds benchmark for rrect_blur. (flutter#149261)
  Prevent LayoutBuilder from rebuilding more than once (flutter#147856)
  Add test for inherited_theme.0.dart (flutter#149120)
  Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS (flutter#145246)
  _ModalScopeStatus as InheritedModel (flutter#149022)
  Add test for radio.toggleable.0.dart (flutter#149153)
  Add a sentinel value for `TextStyle.height` (flutter#149049)
  Remove dynamic_layouts from issue template (flutter#149252)
  Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) (flutter#149255)
  Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) (flutter#149249)
  Roll Packages from a933c30 to 31d3329 (6 revisions) (flutter#149246)
  Clean leak in editable_text_test.dart. (flutter#149223)
  ...
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 30, 2024
@hello-coder-xu
Merge branch 'master' into fix/slider_text_null_error
47d4adf 
* master: (115 commits)
  Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) (flutter#149291)
  disable Impeller on external texture test. (flutter#149292)
  Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) (flutter#149290)
  Update 3.22.1 release notes to include missing fix. (flutter#148999)
  Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) (flutter#149263)
  Reverts "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149279)
  Unskip expression evaluation test (flutter#149253)
  temporarily disable SemanticsAction tests to unblock engine change (flutter#149274)
  Adds benchmark for rrect_blur. (flutter#149261)
  Prevent LayoutBuilder from rebuilding more than once (flutter#147856)
  Add test for inherited_theme.0.dart (flutter#149120)
  Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS (flutter#145246)
  _ModalScopeStatus as InheritedModel (flutter#149022)
  Add test for radio.toggleable.0.dart (flutter#149153)
  Add a sentinel value for `TextStyle.height` (flutter#149049)
  Remove dynamic_layouts from issue template (flutter#149252)
  Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) (flutter#149255)
  Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) (flutter#149249)
  Roll Packages from a933c30 to 31d3329 (6 revisions) (flutter#149246)
  Clean leak in editable_text_test.dart. (flutter#149223)
  ...
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024
@engine-flutter-autoroll
697d99f Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 …
39f2679 
…(1 revision) (flutter/flutter#149263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024
@engine-flutter-autoroll
697d99f Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 …
66918ef 
…(1 revision) (flutter/flutter#149263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024
@engine-flutter-autoroll
697d99f Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 …
7b088de 
…(1 revision) (flutter/flutter#149263)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 30, 2024
@engine-flutter-autoroll
697d99f Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 …
91cc414 
…(1 revision) (flutter/flutter#149263)
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@engine-flutter-autoroll @victorsanni
Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revis…
e46163b 
…ion) (flutter#149263)

Manual roll requested by [email protected]

flutter/engine@60968ee...8d5d14a

2024-05-29 [email protected] Manual roll Dart SDK from 641d61332238 to ef405fbe3917 (12 revisions) (flutter/engine#53089)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 1, 2024
@engine-flutter-autoroll
Roll Flutter from c85fa6a to 7eebe29 (26 revisions) (#6836)
11e192a 
flutter/flutter@c85fa6a...7eebe29

2024-05-30 [email protected] Roll Packages from 31d3329 to 910fabb (11 revisions) (flutter/flutter#149321)
2024-05-30 [email protected] Roll Flutter Engine from fb64b9a4e6f2 to 2fedfd3cc6e5 (2 revisions) (flutter/flutter#149320)
2024-05-30 [email protected] Fix `Slider` throws an error when `_labelPainter` text is null (flutter/flutter#148462)
2024-05-30 [email protected] Roll Flutter Engine from 5500c1a3969a to fb64b9a4e6f2 (1 revision) (flutter/flutter#149307)
2024-05-30 [email protected] Enable `explicitChildNodes` for the `AlertDialog` content (flutter/flutter#149130)
2024-05-30 [email protected] Roll Flutter Engine from 0c95e85dfbf4 to 5500c1a3969a (1 revision) (flutter/flutter#149304)
2024-05-30 [email protected] Roll Flutter Engine from 19707e811b60 to 0c95e85dfbf4 (1 revision) (flutter/flutter#149300)
2024-05-30 [email protected] Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) (flutter/flutter#149291)
2024-05-30 [email protected] disable Impeller on external texture test. (flutter/flutter#149292)
2024-05-30 [email protected] Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) (flutter/flutter#149290)
2024-05-30 [email protected] Update 3.22.1 release notes to include missing fix. (flutter/flutter#148999)
2024-05-30 [email protected] Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) (flutter/flutter#149263)
2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Prevent LayoutBuilder from rebuilding more than once (#147856)" (flutter/flutter#149279)
2024-05-29 [email protected] Unskip expression evaluation test (flutter/flutter#149253)
2024-05-29 [email protected] temporarily disable SemanticsAction tests to unblock engine change (flutter/flutter#149274)
2024-05-29 [email protected] Adds benchmark for rrect_blur. (flutter/flutter#149261)
2024-05-29 [email protected] Prevent LayoutBuilder from rebuilding more than once (flutter/flutter#147856)
2024-05-29 [email protected] Add test for inherited_theme.0.dart (flutter/flutter#149120)
2024-05-29 [email protected] Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS (flutter/flutter#145246)
2024-05-29 [email protected] _ModalScopeStatus as InheritedModel (flutter/flutter#149022)
2024-05-29 [email protected] Add test for radio.toggleable.0.dart (flutter/flutter#149153)
2024-05-29 [email protected] Add a sentinel value for `TextStyle.height` (flutter/flutter#149049)
2024-05-29 [email protected] Remove dynamic_layouts from issue template (flutter/flutter#149252)
2024-05-29 [email protected] Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) (flutter/flutter#149255)
2024-05-29 [email protected] Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) (flutter/flutter#149249)
2024-05-29 [email protected] Roll Packages from a933c30 to 31d3329 (6 revisions) (flutter/flutter#149246)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
697d99f Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 …
1c1d95c 
…(1 revision) (flutter/flutter#149263)
@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-fcbd6935-a5f1-4dc2-88fd-288333ab0407-1717005392 branch June 5, 2024 18:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
697d99f Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 …
06c7d89 
…(1 revision) (flutter/flutter#149263)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@engine-flutter-autoroll @jonahwilliams @fluttergithubbot @eyebrowsoffire