Skip to content

Clean leak in editable_text_test.dart. #149223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
May 29, 2024
Merged

Clean leak in editable_text_test.dart. #149223

auto-submit merged 1 commit into from
May 29, 2024

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented May 29, 2024

Introduced by #149042

Screenshot 2024-05-28 at 6 25 22 PM

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 29, 2024
@polina-c polina-c requested a review from justinmc May 29, 2024 01:26
@polina-c polina-c added a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker autosubmit Merge PR when tree becomes green via auto submit App labels May 29, 2024
justinmc
justinmc approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for catching as always.

@auto-submit auto-submit bot merged commit c85fa6a into flutter:master May 29, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 29, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024
@engine-flutter-autoroll
c85fa6a Clean leak in editable_text_test.dart. (flutter/flutter#149223)
ae03596
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 29, 2024
@engine-flutter-autoroll
Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (#6829)
82a811f 
flutter/flutter@a1a33e6...c85fa6a

2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223)
2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180)
2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220)
2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568)
2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224)
2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470)
2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767)
2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207)
2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594)
2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062)
2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199)
2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198)
2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161)
2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079)
2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006)
2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042)
2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184)
2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169)
2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150)
2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@polina-c polina-c deleted the clean-test branch May 29, 2024 17:31
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 30, 2024
@hello-coder-xu
Merge branch 'master' into feature/grid_delegate_add_assert
456ca38 
* master: (115 commits)
  Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) (flutter#149291)
  disable Impeller on external texture test. (flutter#149292)
  Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) (flutter#149290)
  Update 3.22.1 release notes to include missing fix. (flutter#148999)
  Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) (flutter#149263)
  Reverts "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149279)
  Unskip expression evaluation test (flutter#149253)
  temporarily disable SemanticsAction tests to unblock engine change (flutter#149274)
  Adds benchmark for rrect_blur. (flutter#149261)
  Prevent LayoutBuilder from rebuilding more than once (flutter#147856)
  Add test for inherited_theme.0.dart (flutter#149120)
  Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS (flutter#145246)
  _ModalScopeStatus as InheritedModel (flutter#149022)
  Add test for radio.toggleable.0.dart (flutter#149153)
  Add a sentinel value for `TextStyle.height` (flutter#149049)
  Remove dynamic_layouts from issue template (flutter#149252)
  Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) (flutter#149255)
  Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) (flutter#149249)
  Roll Packages from a933c30 to 31d3329 (6 revisions) (flutter#149246)
  Clean leak in editable_text_test.dart. (flutter#149223)
  ...
hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request May 30, 2024
@hello-coder-xu
Merge branch 'master' into fix/slider_text_null_error
47d4adf 
* master: (115 commits)
  Roll Flutter Engine from 4adf453b6d68 to 19707e811b60 (1 revision) (flutter#149291)
  disable Impeller on external texture test. (flutter#149292)
  Roll Flutter Engine from 8d5d14a1db95 to 4adf453b6d68 (12 revisions) (flutter#149290)
  Update 3.22.1 release notes to include missing fix. (flutter#148999)
  Manual roll Flutter Engine from 60968ee3bde7 to 8d5d14a1db95 (1 revision) (flutter#149263)
  Reverts "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149279)
  Unskip expression evaluation test (flutter#149253)
  temporarily disable SemanticsAction tests to unblock engine change (flutter#149274)
  Adds benchmark for rrect_blur. (flutter#149261)
  Prevent LayoutBuilder from rebuilding more than once (flutter#147856)
  Add test for inherited_theme.0.dart (flutter#149120)
  Update progress_indicator.dart to indicate the adaptive option is for both macOS and iOS (flutter#145246)
  _ModalScopeStatus as InheritedModel (flutter#149022)
  Add test for radio.toggleable.0.dart (flutter#149153)
  Add a sentinel value for `TextStyle.height` (flutter#149049)
  Remove dynamic_layouts from issue template (flutter#149252)
  Roll Flutter Engine from 30aa720d4999 to 60968ee3bde7 (1 revision) (flutter#149255)
  Roll Flutter Engine from b26e1b023cdb to 30aa720d4999 (7 revisions) (flutter#149249)
  Roll Packages from a933c30 to 31d3329 (6 revisions) (flutter#149246)
  Clean leak in editable_text_test.dart. (flutter#149223)
  ...
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@polina-c @victorsanni
Clean leak in editable_text_test.dart. (flutter#149223)
d155604 
Introduced by flutter#149042

<img width="145" alt="Screenshot 2024-05-28 at 6 25 22�PM" src="https://github.com/flutter/flutter/assets/12115586/5eb32012-b1c4-4188-8e9b-a6631483960c">
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
c85fa6a Clean leak in editable_text_test.dart. (flutter/flutter#149223)
00db3ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @justinmc