Change `android_plugin_new_output_dir_test.dart` test description #149198

gmackall · 2024-05-28T18:51:16Z

Changes the test description to what I understand it is testing.

Context at https://discord.com/channels/608014603317936148/846507907876257822/1245077048599515157.

cc @chunfengyao as the original author, as I see you are still active on Github 🙂

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loic-sharma · 2024-05-28T23:03:22Z

Landing this on red to force retry a postsubmit test that I don't have permissions to retry manually. See https://discord.com/channels/608014603317936148/1245129481124053164/1245149408916672592 for context.

chunfengyao · 2024-05-29T03:13:18Z

If someone modifies the output back to '${HOME}/.pub/hosted/${plugin_name}/build/.' in a new pull request, they will see the message 'Plugins should use individualized build directories based on their name.' as an error. will It confuse the author, should the message be 'Plugins should use individualized build directories based on their name.',or this one:'Error: Plugins are now required to use individualized build directories. Please pay attention to it.'?

the test()function will print the message when test failed. probably, the mesage should show why test is failed for users.

…tion (flutter/flutter#149198)

flutter/flutter@a1a33e6...c85fa6a 2024-05-29 [email protected] Clean leak in editable_text_test.dart. (flutter/flutter#149223) 2024-05-29 [email protected] Add tests for animated_switcher.0.dart API example. (flutter/flutter#149180) 2024-05-29 [email protected] Manual roll Flutter Engine from d0323905fc2f to b26e1b023cdb (16 revisions) (flutter/flutter#149220) 2024-05-29 [email protected] Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null (flutter/flutter#148568) 2024-05-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149224) 2024-05-29 [email protected] sliverGridDelegate mainAxisExtent add assert (flutter/flutter#148470) 2024-05-29 [email protected] Fix `SearchAnchor` suggestions not refreshing after long API call (flutter/flutter#148767) 2024-05-28 [email protected] Add link to golden file test docs in the framework gardener guide (flutter/flutter#149207) 2024-05-28 [email protected] Remove opt out for CurvedAnimation. (flutter/flutter#147594) 2024-05-28 [email protected] Fix the RenderFlex.computeDryBaseline implementation to match computeDistanceToActualBaseline (flutter/flutter#149062) 2024-05-28 [email protected] Clean leaky test. (flutter/flutter#149199) 2024-05-28 [email protected] Change `android_plugin_new_output_dir_test.dart` test description (flutter/flutter#149198) 2024-05-28 [email protected] fix M2 InputDecorator suffix icon doesn't turn red on error (flutter/flutter#149161) 2024-05-28 [email protected] Add selectionOverlayBuilder in CupertinoDatePicker and CupertinoTimerâ�¦ (flutter/flutter#143079) 2024-05-28 [email protected] Mouse onEnter and onExit now support hovering stylus (flutter/flutter#149006) 2024-05-28 [email protected] Remove `TextEditingController` private member access (flutter/flutter#149042) 2024-05-28 [email protected] Roll Packages from b7bcb4b to a933c30 (1 revision) (flutter/flutter#149184) 2024-05-28 [email protected] Roll Flutter Engine from b1751088c7e9 to d0323905fc2f (2 revisions) (flutter/flutter#149169) 2024-05-28 [email protected] [tool] Use kebabCase directly (flutter/flutter#149150) 2024-05-28 [email protected] [wiki migration] Leftover wiki pages and links (flutter/flutter#148989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

gmackall · 2024-05-29T18:44:45Z

If someone modifies the output back to '${HOME}/.pub/hosted/${plugin_name}/build/.' in a new pull request, they will see the message 'Plugins should use individualized build directories based on their name.' as an error. will It confuse the author, should the message be 'Plugins should use individualized build directories based on their name.',or this one:'Error: Plugins are now required to use individualized build directories. Please pay attention to it.'?

the test()function will print the message when test failed. probably, the mesage should show why test is failed for users.

The names of tests in this repository are generally given based on what the test tests, not based on an error message that should be thrown when the test fails, so I don't think this will be confusing - it is implicit that the error is that the behavior expected in the title of the test is not currently happening, because the test is failing.

e.g. passing one file works, build succeeds with api 33 features

@chunfengyao

…utter#149198) Changes the test description to what I understand it is testing. Context at https://discord.com/channels/608014603317936148/846507907876257822/1245077048599515157. cc @chunfengyao as the original author, as I see you are still active on Github ð��

…tion (flutter/flutter#149198)

Gray Mackall added 2 commits May 28, 2024 11:49

change test description

cf2fd3a

more info

4c6eef8

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 28, 2024

gmackall marked this pull request as ready for review May 28, 2024 18:52

gmackall requested a review from a team May 28, 2024 18:53

reidbaker approved these changes May 28, 2024

View reviewed changes

yaakovschectman approved these changes May 28, 2024

View reviewed changes

loic-sharma added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels May 28, 2024

auto-submit bot merged commit df64ca0 into flutter:master May 28, 2024

christopherfujino mentioned this pull request May 28, 2024

Release builds can make the (master channel) Flutter build dashboard tree red #149219

Open

engine-flutter-autoroll mentioned this pull request May 29, 2024

Roll Flutter from a1a33e63b911 to 60d32e45346e (19 revisions) flutter/packages#6828

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024

df64ca0 Change android_plugin_new_output_dir_test.dart test descrip…

7835677

…tion (flutter/flutter#149198)

engine-flutter-autoroll mentioned this pull request May 29, 2024

Roll Flutter from a1a33e63b911 to c85fa6abf4ff (20 revisions) flutter/packages#6829

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 29, 2024

df64ca0 Change android_plugin_new_output_dir_test.dart test descrip…

1de792e

…tion (flutter/flutter#149198)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

df64ca0 Change android_plugin_new_output_dir_test.dart test descrip…

d4f4aaf

…tion (flutter/flutter#149198)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change `android_plugin_new_output_dir_test.dart` test description #149198

Change `android_plugin_new_output_dir_test.dart` test description #149198

Uh oh!

gmackall commented May 28, 2024 •

edited

Loading

Uh oh!

loic-sharma commented May 28, 2024

Uh oh!

chunfengyao commented May 29, 2024

Uh oh!

gmackall commented May 29, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Change android_plugin_new_output_dir_test.dart test description #149198

Change android_plugin_new_output_dir_test.dart test description #149198

Uh oh!

Conversation

gmackall commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

loic-sharma commented May 28, 2024

Uh oh!

chunfengyao commented May 29, 2024

Uh oh!

gmackall commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Change `android_plugin_new_output_dir_test.dart` test description #149198

Change `android_plugin_new_output_dir_test.dart` test description #149198

gmackall commented May 28, 2024 •

edited

Loading

gmackall commented May 29, 2024 •

edited

Loading