Skip to content

Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.onDrag for ScrollViewers with Drawer #148948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
May 31, 2024
Merged

Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.onDrag for ScrollViewers with Drawer #148948

auto-submit merged 3 commits into from
May 31, 2024

Conversation

@dawidope
Copy link
Contributor

@dawidope dawidope commented May 23, 2024 •
edited by Piinks
Loading

Fixes #141542
Fixes #103544
Fixes #54277

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels May 23, 2024
@justinmc justinmc requested a review from Piinks May 24, 2024 21:10
@Piinks Piinks force-pushed the fix-listview-ondrag branch from 3f8cc84 to 1fa7a86 Compare May 28, 2024 23:58
Piinks
Piinks approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dawidope welcome! Thank you for contributing! I came across this comment that explained this really nicely. Thanks for finding this and doing to work to resolve it. :)

LGTM, I'll need to find a second reviewer.

@Piinks Piinks added a: text input Entering text in a text field or keyboard related problems f: focus Focus traversal, gaining or losing focus labels May 31, 2024
nate-thegrate
nate-thegrate approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fantastic contribution!

@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label May 31, 2024
@auto-submit auto-submit bot merged commit 84cff31 into flutter:master May 31, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
8cf6d7e 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
6c3cb06 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
8710144 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
17cdfd7 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
b26fbbe 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
b688daf 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
a61d683 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
90c7e1a 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
b0eacc0 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
64b880c 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
ba3836d 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
84cff31 Fix incorrect behavior of ScrollViewKeyboardDismissBehavior.o…
51d25f9 
…nDrag for ScrollViewers with Drawer (flutter/flutter#148948)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

+1 more reviewer

@nate-thegrate nate-thegrate nate-thegrate approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: focus Focus traversal, gaining or losing focus f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

3 participants

@dawidope @nate-thegrate @Piinks