Add feedback for long press on iOS #148922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
justinmc
approved these changes
May 24, 2024
| /// no-op as that platform usually doesn't provide feedback for long presses. | ||
| /// On Android the platform-typical vibration is triggered. On iOS a | ||
| /// heavy-impact haptic feedback is triggered, alongside the click system | ||
| /// sound. |
Contributor
There was a problem hiding this comment.
Nit: "sound, which was observed to be the default behavior on a physical <iPhone version> running <iOS version>."
| /// press. | ||
| /// On Android the platform-typical vibration is triggered. On iOS a | ||
| /// heavy-impact haptic feedback is triggered, alongside the click system | ||
| /// sound. |
Contributor
There was a problem hiding this comment.
Probably also include the iOS device and version here.
victorsanni
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/148922, due to - The status or check suite Linux web_long_running_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
victorsanni
added
the
autosubmit
victorsanni
added a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
Adds the click system sound and heavy-impact haptic feedback to iOS on long presses. Fixes flutter#148391
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the click system sound and heavy-impact haptic feedback to iOS on long presses.
Fixes #148391
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.