Skip to content

Revert "Fix the second TextFormField to trigger onTapOutside" #148909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Renzo-Olivares merged 1 commit into from
May 22, 2024
Merged

Revert "Fix the second TextFormField to trigger onTapOutside" #148909

Renzo-Olivares merged 1 commit into from
May 22, 2024

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented May 22, 2024

Reverts #148206

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels May 22, 2024
@Renzo-Olivares Renzo-Olivares added the revert Autorevert PR (with "Reason for revert:" comment) label May 22, 2024
@gspencergoog
Copy link
Contributor

gspencergoog commented May 22, 2024

What's the reason for the revert?

@Renzo-Olivares
Copy link
Contributor Author

Renzo-Olivares commented May 22, 2024

@gspencergoog This looks like the culprit for the tree being red.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8747210306750076193/+/u/run_test.dart_for_web_canvaskit_tests_shard_and_subshard_1/stdout

05:36 +663 ~89: test/widgets/editable_text_test.dart: keyboard is requested after setEditingState after switching to a new text field
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: [
            'TextInput.clearClient',
            'TextInput.setClient',
            'TextInput.setEditableSizeAndTransform',
            'TextInput.setMarkedTextRect',
            'TextInput.setStyle',
            'TextInput.setEditingState',
            'TextInput.show',
            'TextInput.requestAutofill',
            'TextInput.setCaretRect'
          ]
  Actual: MappedListIterable<MethodCall, String>:[
            'TextInput.clearClient',
            'TextInput.hide',
            'TextInput.setClient',
            'TextInput.setEditableSizeAndTransform',
            'TextInput.setMarkedTextRect',
            'TextInput.setStyle',
            'TextInput.setEditingState',
            'TextInput.show',
            'TextInput.requestAutofill',
            'TextInput.setCaretRect'
          ]
   Which: at location [1] is 'TextInput.hide' instead of 'TextInput.setClient'

@Renzo-Olivares
Copy link
Contributor Author

Renzo-Olivares commented May 22, 2024

cc @wyqlxf

@Renzo-Olivares Renzo-Olivares merged commit b2eda06 into master May 22, 2024
@Renzo-Olivares Renzo-Olivares deleted the revert-148206-fix_127597 branch May 22, 2024 20:41
@wyqlxf
Copy link
Contributor

wyqlxf commented May 23, 2024

@Renzo-Olivares Thank you for your feedback. It will indeed fail on the web platform. I will check again.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
b2eda06 Revert "Fix the second TextFormField to trigger onTapOutside" (…
6ee3957 
…flutter/flutter#148909)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
b2eda06 Revert "Fix the second TextFormField to trigger onTapOutside" (…
8e6bf1a 
…flutter/flutter#148909)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
b2eda06 Revert "Fix the second TextFormField to trigger onTapOutside" (…
35620c0 
…flutter/flutter#148909)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
Roll Flutter from 73bf206 to 8d955cd (24 revisions) (#6786)
1008d9e 
flutter/flutter@73bf206...8d955cd

2024-05-23 [email protected] Update `FocusManager` platform check to include iOS (flutter/flutter#148612)
2024-05-23 [email protected] [iOS] fix hot restart with native assets (flutter/flutter#148752)
2024-05-23 [email protected] Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943)
2024-05-23 [email protected] Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621)
2024-05-23 [email protected] Test raw autocomplete api examples (flutter/flutter#148234)
2024-05-23 [email protected] Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166)
2024-05-23 [email protected] Add tests for restorable_value.0.dart API example. (flutter/flutter#148676)
2024-05-23 [email protected] Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919)
2024-05-22 [email protected] Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897)
2024-05-22 [email protected] 3.22.1 changelog updates (flutter/flutter#148895)
2024-05-22 [email protected] Add frame number and widget location map service extension (flutter/flutter#148702)
2024-05-22 [email protected] Remove an assert with false positives (flutter/flutter#148795)
2024-05-22 [email protected] Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909)
2024-05-22 [email protected] [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782)
2024-05-22 [email protected] Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883)
2024-05-22 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206)
2024-05-22 [email protected] Try removing robolectric from `integration_test` tests (flutter/flutter#148803)
2024-05-22 [email protected] Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160)
2024-05-22 [email protected] [wiki migration] Tool team pages (flutter/flutter#148779)
2024-05-22 [email protected] Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819)
2024-05-22 [email protected] [native_assets] Add support for link hooks (flutter/flutter#148474)
2024-05-22 [email protected] Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864)
2024-05-22 [email protected] Update tokens to 4.0.0 (flutter/flutter#148789)
2024-05-22 [email protected] Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@eyebrowsoffire eyebrowsoffire mentioned this pull request May 23, 2024
Closed
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@Renzo-Olivares @victorsanni
Revert "Fix the second TextFormField to trigger onTapOutside" (flutte…
94b3325 
…r#148909)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
b2eda06 Revert "Fix the second TextFormField to trigger onTapOutside" (…
f782d60 
…flutter/flutter#148909)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@justinmc justinmc Awaiting requested review from justinmc

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Renzo-Olivares @gspencergoog @wyqlxf