update generated localized message files in the stocks test app #148741

andrewkolos · 2024-05-21T05:30:51Z

The stocks test app includes Dart files containing localized messages generated by package:flutter_localizations. However, these files appear to have become out of date. Running pub get in the project will regenerate these files and generate a diff, which can be annoying when working on the repo.

This PR generates the files. ~~It also updates the templates for these files to be compliant with flutter/flutter repo lint rules, including noop_primitive_operations and use_super_parameters.~~ It also adds // ignore_for_file: type=lint to these files to disable linting for these files. This avoids issues like #106150 and this.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

update tests

andrewkolos · 2024-05-31T03:17:10Z

Quick link to output from failing Linux tool_tests_commands check. Of interest is:

01:31 +66 ~1: test/commands.shard/permeable/create_test.dart: can create a skeleton (list/detail) app
Expected: <0>
  Actual: <1>

... <stuff> ...

.dart_tool/flutter_gen/gen_l10n/app_localizations_en.dart:5:23: Error: The 'super-parameters' language feature is disabled for this library.
Try removing the package language version or setting the language version to 2.17 or higher.
  AppLocalizationsEn([super.locale = 'en']);
                      ^^^^^
.dart_tool/flutter_gen/gen_l10n/app_localizations_en.dart:5:3: Error: The superclass, 'AppLocalizations', has no unnamed constructor that takes no arguments.
  AppLocalizationsEn([super.locale = 'en']);
  ^^^^^^^^^^^^^^^^^^

A quick way to repro this issue locally is to checkout this PR branch, clean out any cached tool binaries, and then run flutter create hello_world -t skeleton --implementation-tests followed by flutter test.

It looks like during flutter gen-l10n we generate a "synthetic" package (in .dart_tool/flutter_gen) which contains a folder that contains the generated dart files. The pubspec we generate here is minimalist and doesn't specify a language constraint. Today, I learned that pubspec's aren't required to specify a minimum SDK version. Still, I would expect that, if no constraint is provided, it would be that of the SDK that is processing these dart files, and I'm pretty sure the dart binary I'm using on my machine is >=3.5.0 🤷.

Even if I modify my local branch of flutter to include a constraint in this generated pubspec, I still receive the same compilation error.

This reverts commit 5420640.

andrewkolos · 2024-06-03T18:01:55Z

I've updated this PR (including the description) to leave the code templates untouched except for a new // ignore_for_file: type=lint, which disables linting for these files.

christopherfujino

nice

…pp (flutter/flutter#148741)

…pdate * master: (168 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2353b6 to a6aa5d826649 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558be758 to 60a7bb2353b6 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf635a9f to ea72558be758 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d7459708 to d81edf635a9f (1 revision) (flutter#149468) Roll Flutter Engine from 40b868efcc46 to b0f4d7459708 (1 revision) (flutter#149467) ...

…pdate * master: (181 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2353b6 to a6aa5d826649 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558be758 to 60a7bb2353b6 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf635a9f to ea72558be758 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d7459708 to d81edf635a9f (1 revision) (flutter#149468) Roll Flutter Engine from 40b868efcc46 to b0f4d7459708 (1 revision) (flutter#149467) ...

* master: (181 commits) Fix the scrolling layout deviation of `CupertinoActionSheet` (flutter#149439) Roll Flutter Engine from 60a7bb2353b6 to a6aa5d826649 (2 revisions) (flutter#149627) Roll Flutter Engine from ea72558be758 to 60a7bb2353b6 (2 revisions) (flutter#149623) Place `flutter_gpu` in the package cache. (flutter#149299) Switch to triage-* labels for platform package triage (flutter#149614) Roll pub packages (flutter#149617) Fixes multi line textfield hint text gets ellipsized (flutter#148423) Support failures-only and silent reporters in `flutter test` (flutter#148739) [CupertinoActionSheet] Fix overflow of the overscroll section when the user scrolls far (flutter#149542) Fix InputDecorator.prefixIcon color when disabled (flutter#149595) Added filter callback on dropdown menu (flutter#143939) update generated localized message files in the stocks test app (flutter#148741) Add a simplified SimpleCascadingMenuApp example (flutter#149147) Reland "Prevent LayoutBuilder from rebuilding more than once (flutter#147856)" (flutter#149303) Move some benchmarks from MotoG4 to Mokey (flutter#149567) Roll Packages from d8e8e8c to 11e192a (2 revisions) (flutter#149596) Cleanup triage reports from docs/ (flutter#149545) Roll Flutter Engine from d81edf635a9f to ea72558be758 (1 revision) (flutter#149590) Roll Flutter Engine from b0f4d7459708 to d81edf635a9f (1 revision) (flutter#149468) Roll Flutter Engine from 40b868efcc46 to b0f4d7459708 (1 revision) (flutter#149467) ...

…pp (flutter/flutter#148741)

andrewkolos marked this pull request as ready for review May 21, 2024 05:49

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 21, 2024

andrewkolos force-pushed the update-generated-localization-files branch from d98ea7d to 633bc02 Compare May 21, 2024 20:17

github-actions bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label May 21, 2024

andrewkolos force-pushed the update-generated-localization-files branch from 633bc02 to 12bd344 Compare May 21, 2024 21:08

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 21, 2024

andrewkolos added 3 commits May 30, 2024 19:03

update generated localization class files

67955b6

Update regenerate.md

2b4a019

update templates to be compliant with flutter repo lint rules

5420640

update tests

andrewkolos force-pushed the update-generated-localization-files branch from 12bd344 to 5420640 Compare May 31, 2024 02:03

andrewkolos mentioned this pull request May 31, 2024

The stocks benchmark app includes auto-generated files that are out-of-date #149386

Closed

Revert "update templates to be compliant with flutter repo lint rules"

5566ab6

This reverts commit 5420640.

andrewkolos force-pushed the update-generated-localization-files branch from 2dfbb5b to 30cbf53 Compare June 1, 2024 19:02

disable linting for generated message l10n files

5fc5561

andrewkolos force-pushed the update-generated-localization-files branch from 30cbf53 to 5fc5561 Compare June 1, 2024 19:09

andrewkolos requested a review from christopherfujino June 3, 2024 18:02

christopherfujino approved these changes Jun 3, 2024

View reviewed changes

andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2024

auto-submit bot merged commit be72479 into flutter:master Jun 3, 2024

engine-flutter-autoroll mentioned this pull request Jun 3, 2024

Roll Flutter from b295c86b2e85 to be724796aac6 (55 revisions) flutter/packages#6857

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024

be72479 update generated localized message files in the stocks test a…

6ce7712

…pp (flutter/flutter#148741)

engine-flutter-autoroll mentioned this pull request Jun 3, 2024

Roll Flutter from b295c86b2e85 to a92318dd9822 (56 revisions) flutter/packages#6858

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024

be72479 update generated localized message files in the stocks test a…

67cf313

…pp (flutter/flutter#148741)

engine-flutter-autoroll mentioned this pull request Jun 3, 2024

Roll Flutter from b295c86b2e85 to e02d29d52ed9 (57 revisions) flutter/packages#6859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024

be72479 update generated localized message files in the stocks test a…

d32fb60

…pp (flutter/flutter#148741)

engine-flutter-autoroll mentioned this pull request Jun 3, 2024

Manual roll Flutter from c85fa6abf4ff to 4cad9fde6791 (83 revisions) flutter/packages#6861

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024

be72479 update generated localized message files in the stocks test a…

db9cdba

…pp (flutter/flutter#148741)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

be72479 update generated localized message files in the stocks test a…

2ca2d1e

…pp (flutter/flutter#148741)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update generated localized message files in the stocks test app #148741

update generated localized message files in the stocks test app #148741

Uh oh!

andrewkolos commented May 21, 2024 •

edited

Loading

Uh oh!

andrewkolos commented May 31, 2024

Uh oh!

andrewkolos commented Jun 3, 2024

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

update generated localized message files in the stocks test app #148741

update generated localized message files in the stocks test app #148741

Uh oh!

Conversation

andrewkolos commented May 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

andrewkolos commented May 31, 2024

Uh oh!

andrewkolos commented Jun 3, 2024

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andrewkolos commented May 21, 2024 •

edited

Loading