Skip to content

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented May 21, 2024

Skipping for #148704

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 21, 2024
@zanderso zanderso requested a review from jason-simmons May 21, 2024 15:30
@jmagman
Copy link
Member

jmagman commented May 21, 2024

Merging to open the tree

@jmagman jmagman merged commit b6bed5a into master May 21, 2024
@jmagman jmagman deleted the zanderso-patch-2 branch May 21, 2024 15:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 23, 2024
flutter/flutter@d02292d...73bf206

2024-05-22 [email protected] `CupertinoDialogRoute` leak fix (flutter/flutter#148774)
2024-05-22 [email protected] Marks Windows plugin_test to be flaky (flutter/flutter#148835)
2024-05-22 [email protected] Add tests for actions.0.dart API example. (flutter/flutter#148678)
2024-05-22 [email protected] Introduce `WidgetStateBorderSide.lerp` (flutter/flutter#148122)
2024-05-22 [email protected] add `default-flavor` field to flutter pubspec, which will be used as the flavor in `flutter build/run` if `--flavor` is not provided (flutter/flutter#147968)
2024-05-22 [email protected] [wiki migration] Pages under docs/postmortems/ (flutter/flutter#148798)
2024-05-22 [email protected] Roll Flutter Engine from e5a73e520e89 to c89defa55801 (2 revisions) (flutter/flutter#148812)
2024-05-22 [email protected] Make hover tests functional and cleanup mouse pointers in Material toggleables (flutter/flutter#148808)
2024-05-21 [email protected] Fix two dimensional viewport unexpected null exception when no child is laid out (flutter/flutter#148256)
2024-05-21 [email protected] Roll Flutter Engine from bc1345b6b50a to e5a73e520e89 (3 revisions) (flutter/flutter#148807)
2024-05-21 [email protected] Add test for undo_history_controller.0.dart (flutter/flutter#148205)
2024-05-21 [email protected] Roll Flutter Engine from a8872c8915a2 to bc1345b6b50a (6 revisions) (flutter/flutter#148802)
2024-05-21 [email protected] Fix test that leaks images. (flutter/flutter#148494)
2024-05-21 [email protected] Fix warnings in `dependency_version_checker.gradle.kts` (flutter/flutter#148699)
2024-05-21 [email protected] [wiki migration] Android team pages (flutter/flutter#148585)
2024-05-21 [email protected] Fix leaky test. (flutter/flutter#148788)
2024-05-21 [email protected] Add DropdownButton.menuWidth (flutter/flutter#148125)
2024-05-21 [email protected] Add test for focus example 2 (flutter/flutter#147624)
2024-05-21 [email protected] Add a migrator to remove `FlutterMultiDexApplication.java` (flutter/flutter#148515)
2024-05-21 [email protected] [wiki migration] Infra team pages (flutter/flutter#148718)
2024-05-21 [email protected] Roll Flutter Engine from 8a352f01e503 to a8872c8915a2 (1 revision) (flutter/flutter#148776)
2024-05-21 [email protected] Fix the output of the CDN test. (flutter/flutter#148730)
2024-05-21 [email protected] [wiki migration] Release team pages (flutter/flutter#148723)
2024-05-21 [email protected] Remove hidden dependencies on LocalProcessManager (flutter/flutter#148096)
2024-05-21 [email protected] Adds Missing `onHover` & `onFocusChange` for `OutlinedButton.icon` (flutter/flutter#144374)
2024-05-21 [email protected] Adds tests to NestedScrollView examples (flutter/flutter#148170)
2024-05-21 [email protected] Roll Flutter Engine from c2ef01f6f1ab to 8a352f01e503 (18 revisions) (flutter/flutter#148766)
2024-05-21 [email protected] `switch` expressions: finale (flutter/flutter#148711)
2024-05-21 [email protected] [iOS] specify minimum os version for native asset frameworks (flutter/flutter#148504)
2024-05-21 [email protected] Removed brand references from MenuAnchor.dart (flutter/flutter#148760)
2024-05-21 [email protected] Skip flaky test in expression_evaluation_test.dart (flutter/flutter#148737)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
goderbauer added a commit that referenced this pull request May 28, 2024
DanTup added a commit to DanTup/flutter that referenced this pull request May 29, 2024
This test was skipped in flutter#148737 because it had became flaky because instances created in expression evaluation were being collected quickly. The change in dart-lang/sdk@ffbbdb5 prevents things in the VM Service's ring buffer from being GC'd which should resolve the issue.

I am unable to reproduce this test flaking locally on latest code.

Fixes flutter#148704
@DanTup DanTup mentioned this pull request May 29, 2024
9 tasks
DanTup added a commit that referenced this pull request May 29, 2024
This test was skipped in #148737
because it had became flaky because instances created in expression
evaluation were being collected quickly. The change in
dart-lang/sdk@ffbbdb5
prevents things in the VM Service's ring buffer from being GC'd which
should resolve the issue.

I am unable to reproduce this test flaking locally on latest code.

Fixes #148704



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
This test was skipped in flutter#148737
because it had became flaky because instances created in expression
evaluation were being collected quickly. The change in
dart-lang/sdk@ffbbdb5
prevents things in the VM Service's ring buffer from being GC'd which
should resolve the issue.

I am unable to reproduce this test flaking locally on latest code.

Fixes flutter#148704



## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants