Add frame number and widget location map service extension #148702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
| registerExtension: registerExtension, | ||
| ); | ||
|
|
||
| _registerSignalServiceExtension( |
Member
There was a problem hiding this comment.
should this be using registerServiceExtension instead of _registerSignalServiceExtension?
Member
Author
There was a problem hiding this comment.
I'm not sure, as I copied and pasted this - it looks like _registerSignalServiceExtension just calls registerServiceExtension but wraps the result properly, so I figured it's a convenience function. Do you know more about what a "signal service" should be?
Member
There was a problem hiding this comment.
sg to use _registerSignalServiceExtension then
| <String, String>{}, | ||
| ))! as Map<String, Object?>; | ||
|
|
||
| final Map<String, Object?> widgetTestLocations = locationMapJson[file]! as Map<String, Object?>; |
Member
There was a problem hiding this comment.
will the content of this map be stable? If so, can we just assert the raw content of the map is what we expect?
Member
Author
There was a problem hiding this comment.
There's some content in here that depends on specific locations related to the sample ClockDemo code (e.g. lines and columns are literally locations in the test file and dependent widgets), so they could change as the test file changes. I think just verifying that counts match up and a few widget names match is good enough to validate the format of the map.
Member
Author
|
Hmm any advice on how to resolve the tests? The details don't seem to explain what's wrong, and I'm not sure if this link (https://github.com/flutter/flutter/wiki/Understanding-a-LUCI-build-failure) is relevant. |
christopherfujino
requested review from
andrewkolos
and removed request for
christopherfujino
Contributor
|
@andrewkolos PTAL |
kenzieschmoll
approved these changes
May 22, 2024
kenzieschmoll
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 23, 2024
flutter/flutter@73bf206...8d955cd 2024-05-23 [email protected] Update `FocusManager` platform check to include iOS (flutter/flutter#148612) 2024-05-23 [email protected] [iOS] fix hot restart with native assets (flutter/flutter#148752) 2024-05-23 [email protected] Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943) 2024-05-23 [email protected] Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621) 2024-05-23 [email protected] Test raw autocomplete api examples (flutter/flutter#148234) 2024-05-23 [email protected] Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166) 2024-05-23 [email protected] Add tests for restorable_value.0.dart API example. (flutter/flutter#148676) 2024-05-23 [email protected] Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919) 2024-05-22 [email protected] Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897) 2024-05-22 [email protected] 3.22.1 changelog updates (flutter/flutter#148895) 2024-05-22 [email protected] Add frame number and widget location map service extension (flutter/flutter#148702) 2024-05-22 [email protected] Remove an assert with false positives (flutter/flutter#148795) 2024-05-22 [email protected] Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909) 2024-05-22 [email protected] [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782) 2024-05-22 [email protected] Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883) 2024-05-22 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206) 2024-05-22 [email protected] Try removing robolectric from `integration_test` tests (flutter/flutter#148803) 2024-05-22 [email protected] Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160) 2024-05-22 [email protected] [wiki migration] Tool team pages (flutter/flutter#148779) 2024-05-22 [email protected] Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819) 2024-05-22 [email protected] [native_assets] Add support for link hooks (flutter/flutter#148474) 2024-05-22 [email protected] Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864) 2024-05-22 [email protected] Update tokens to 4.0.0 (flutter/flutter#148789) 2024-05-22 [email protected] Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kenzieschmoll
added
the
cp: beta
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
May 30, 2024
…48702) This helps us add widget rebuild counts to the DevTools performance page: flutter/devtools#4564
5 tasks
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…48702) This helps us add widget rebuild counts to the DevTools performance page: flutter/devtools#4564
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
#149345) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? DevTools release 2.36.0: https://dart-review.googlesource.com/c/sdk/+/368762 ### Changelog Description: This change adds a service extension that DevTools uses to support a "Track widget build counts" feature. This feature is first included in DevTools 2.36.0. ### Impact Description: This service extension is required for DevTools 2.36.0, which needs to be [cherry-picked](https://dart-review.googlesource.com/c/sdk/+/368762) into the Dart SDK. This beta release of DevTools missed the code cutoff because we were targeting the date listed on go/dash-team-releases (5/29). Since the beta release went out early, we missed the cut off and need to cherry-pick. Since this DevTools release depended on the changes from #148702, we also need to cherry pick those changes into the flutter beta channel. ### Workaround: No. This is required for DevTools 2.36.0 to work properly: https://dart-review.googlesource.com/c/sdk/+/368762. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? With this change, a flutter app connecting to DevTools 2.36.0 (already on the Dart SDK main branch and trying to CP into the Dart SDK beta branch) will be able to use the "Track widget build counts" feature in DevTools.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us add widget rebuild counts to the DevTools performance page: flutter/devtools#4564
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.