Fix DecoratedSliver sample code to reflect the description #148621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
framework
huynguyennovem
force-pushed
the
fix-decoratedsliver-example
branch
2 times, most recently
from
7ed9c6c to
2601097
Compare
bleroux
requested changes
May 20, 2024
Contributor
bleroux
left a comment
bleroux
left a comment
There was a problem hiding this comment.
Minor changes requested.
Also consider splitting the tests, for instance instead of one big tests containing comments to separate various cases, you can define three tests with the corresponding description: “Verify the texts are displayed” (to check both text), “Verify the sliver with key ‘radial-gradient’ has a RadialGradient” and “Verify the sliver with key ‘linear-gradient’ has a LinearGradient”.
huynguyennovem
force-pushed
the
fix-decoratedsliver-example
branch
from
2601097 to
59ded3c
Compare
Member
Author
|
Thank @bleroux for reviewing this. I solved all |
bleroux
approved these changes
May 20, 2024
Contributor
bleroux
left a comment
bleroux
left a comment
There was a problem hiding this comment.
LGTM!
Considering removing the comments I pointed out.
Can you also rebased your PR? We will see if it fixes the failing CI check.
huynguyennovem
force-pushed
the
fix-decoratedsliver-example
branch
from
59ded3c to
6e76630
Compare
Contributor
|
@huycozy To fix the 'Linux analyze' failure you have to update the file 'dev/bots/check_code_samples.dart' and remove the line to the sample for which you added a test. |
huynguyennovem
force-pushed
the
fix-decoratedsliver-example
branch
from
6e76630 to
93f53e7
Compare
Member
Author
|
oh right, I forgot this. Thanks for reminding me :-) |
bleroux
force-pushed
the
fix-decoratedsliver-example
branch
from
93f53e7 to
76c319d
Compare
huynguyennovem
force-pushed
the
fix-decoratedsliver-example
branch
from
76c319d to
cc49ce1
Compare
Signed-off-by: huycozy <[email protected]>
bleroux
force-pushed
the
fix-decoratedsliver-example
branch
from
cc49ce1 to
b6d0fe3
Compare
huycozy
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 23, 2024
flutter/flutter@73bf206...8d955cd 2024-05-23 [email protected] Update `FocusManager` platform check to include iOS (flutter/flutter#148612) 2024-05-23 [email protected] [iOS] fix hot restart with native assets (flutter/flutter#148752) 2024-05-23 [email protected] Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943) 2024-05-23 [email protected] Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621) 2024-05-23 [email protected] Test raw autocomplete api examples (flutter/flutter#148234) 2024-05-23 [email protected] Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166) 2024-05-23 [email protected] Add tests for restorable_value.0.dart API example. (flutter/flutter#148676) 2024-05-23 [email protected] Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919) 2024-05-22 [email protected] Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897) 2024-05-22 [email protected] 3.22.1 changelog updates (flutter/flutter#148895) 2024-05-22 [email protected] Add frame number and widget location map service extension (flutter/flutter#148702) 2024-05-22 [email protected] Remove an assert with false positives (flutter/flutter#148795) 2024-05-22 [email protected] Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909) 2024-05-22 [email protected] [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782) 2024-05-22 [email protected] Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883) 2024-05-22 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206) 2024-05-22 [email protected] Try removing robolectric from `integration_test` tests (flutter/flutter#148803) 2024-05-22 [email protected] Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160) 2024-05-22 [email protected] [wiki migration] Tool team pages (flutter/flutter#148779) 2024-05-22 [email protected] Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819) 2024-05-22 [email protected] [native_assets] Add support for link hooks (flutter/flutter#148474) 2024-05-22 [email protected] Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864) 2024-05-22 [email protected] Update tokens to 4.0.0 (flutter/flutter#148789) 2024-05-22 [email protected] Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…48621) ### Demo screenshot  ### Related issue - Fixes flutter#145935 - Add test for `examples/api/test/widgets/sliver/decorated_sliver.0_test.dart` as a part of flutter#130459.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo screenshot
Related issue
DecoratedSliverDocs Sample #145935examples/api/test/widgets/sliver/decorated_sliver.0_test.dartas a part of Many API Examples are missing tests #130459.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.