Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented May 17, 2024

Part of #145009
This is part one of the wiki migration.
This moves all wiki pages wholesale into the new docs directory with no changes.
Follow up PRs will sort them, updating breadcrumbs and links.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 17, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Piinks Piinks added the d: docs/ flutter/flutter/docs, for contributors label May 17, 2024
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks
Copy link
Contributor Author

Piinks commented May 17, 2024

I'm going to need to change some file names to make CI happy. Will do that after lunch.

@Piinks
Copy link
Contributor Author

Piinks commented May 17, 2024

@Hixie
Copy link
Contributor

Hixie commented May 17, 2024

test-exempt: documentation

@Piinks
Copy link
Contributor Author

Piinks commented May 17, 2024

Ok next, I will need to make some edits. There are some links I need to fix to pass analysis, along with some trailing white space. I will not edit anything else, pinky promise. :)

@Piinks
Copy link
Contributor Author

Piinks commented May 17, 2024

Actually, I may have a better idea, I am going to edit analyze.dart to make only docs/unsorted immune. The primary issues (of which there are a ton) are

  • links that reference the master branch and
  • links to file issues that do not fit expected templates

Since this initial move is meant to change as little as possible, I think exempting only the unsorted directory is pretty straightforward. As we move pages out of unsorted, we can fix all of these links then.

@Piinks Piinks changed the title Migrate the flutter/flutter wiki to docs/unsorted Migrate the flutter/flutter wiki to docs/unsorted_wiki May 17, 2024
@Piinks
Copy link
Contributor Author

Piinks commented May 17, 2024

Last commit is just copying over a coincidentally timed update to the Setting up the Framework Development Environment from @goderbauer 😉

Should be able to merge after CI passes before any other changes are introduced.

When sorting pages into subdirs in follow up PRs, I'll circle back to the original wiki page, check that there weren't additional changes, and update the page to point to the new location.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented May 17, 2024

auto label is removed for flutter/flutter/148562, due to - The status or check suite Windows build_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2024
@auto-submit auto-submit bot merged commit ed8eaf1 into flutter:master May 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 19, 2024
flutter/flutter@00425ef...adf279f

2024-05-18 [email protected] Fix template manifest test (flutter/flutter#148616)
2024-05-18 [email protected] Disable shuffling in the flutter_tools create_test suite (flutter/flutter#148619)
2024-05-18 [email protected] Move `Feedback` to widgets layer (flutter/flutter#148523)
2024-05-18 [email protected] Roll Flutter Engine from 93f1b5a146ed to 552a965b707b (4 revisions) (flutter/flutter#148595)
2024-05-18 [email protected] Swap crash reporting with unified analytics (flutter/flutter#148525)
2024-05-17 [email protected] Roll Flutter Engine from 5b3bf9a950b2 to 93f1b5a146ed (3 revisions) (flutter/flutter#148581)
2024-05-17 [email protected] Migrate the flutter/flutter wiki to docs/unsorted_wiki (flutter/flutter#148562)
2024-05-17 [email protected] Roll Flutter Engine from 17decdf12557 to 5b3bf9a950b2 (3 revisions) (flutter/flutter#148567)
2024-05-17 [email protected] Shift a test on MotoG4 to staging, add it on Mokey (flutter/flutter#148552)
2024-05-17 [email protected] Revert "`if` chains â�� `switch` expressions" (flutter/flutter#148556)
2024-05-17 [email protected] Roll Packages from 87a02e3 to ae4dd32 (9 revisions) (flutter/flutter#148555)
2024-05-17 [email protected] Roll Flutter Engine from 7d244ab0348a to 17decdf12557 (1 revision) (flutter/flutter#148549)
2024-05-17 [email protected] Roll Flutter Engine from a19d3722922d to 7d244ab0348a (4 revisions) (flutter/flutter#148546)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@00425ef...adf279f

2024-05-18 [email protected] Fix template manifest test (flutter/flutter#148616)
2024-05-18 [email protected] Disable shuffling in the flutter_tools create_test suite (flutter/flutter#148619)
2024-05-18 [email protected] Move `Feedback` to widgets layer (flutter/flutter#148523)
2024-05-18 [email protected] Roll Flutter Engine from 93f1b5a146ed to 552a965b707b (4 revisions) (flutter/flutter#148595)
2024-05-18 [email protected] Swap crash reporting with unified analytics (flutter/flutter#148525)
2024-05-17 [email protected] Roll Flutter Engine from 5b3bf9a950b2 to 93f1b5a146ed (3 revisions) (flutter/flutter#148581)
2024-05-17 [email protected] Migrate the flutter/flutter wiki to docs/unsorted_wiki (flutter/flutter#148562)
2024-05-17 [email protected] Roll Flutter Engine from 17decdf12557 to 5b3bf9a950b2 (3 revisions) (flutter/flutter#148567)
2024-05-17 [email protected] Shift a test on MotoG4 to staging, add it on Mokey (flutter/flutter#148552)
2024-05-17 [email protected] Revert "`if` chains â�� `switch` expressions" (flutter/flutter#148556)
2024-05-17 [email protected] Roll Packages from 87a02e3 to ae4dd32 (9 revisions) (flutter/flutter#148555)
2024-05-17 [email protected] Roll Flutter Engine from 7d244ab0348a to 17decdf12557 (1 revision) (flutter/flutter#148549)
2024-05-17 [email protected] Roll Flutter Engine from a19d3722922d to 7d244ab0348a (4 revisions) (flutter/flutter#148546)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: docs/ flutter/flutter/docs, for contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants