Revert "if chains → switch expressions"
#148556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
Member
Author
|
There was also a mysterious improvement in the benchmark on this PR, which probably should have been investigated (by me, who was the sheriff) at the time it was flagged: https://flutter-flutter-perf.skia.org/e/?begin=1714012040&end=1715961341&keys=Xb1179d25dd833c9f199aaa30b3009890&requestType=0&selected=commit%3D40745%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253Dmokey%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253Dworst_frame_rasterizer_time_millis%252Ctest%253Dnew_gallery__transition_perf%252C&xbaroffset=40745 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 19, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 19, 2024
flutter/flutter@00425ef...adf279f 2024-05-18 [email protected] Fix template manifest test (flutter/flutter#148616) 2024-05-18 [email protected] Disable shuffling in the flutter_tools create_test suite (flutter/flutter#148619) 2024-05-18 [email protected] Move `Feedback` to widgets layer (flutter/flutter#148523) 2024-05-18 [email protected] Roll Flutter Engine from 93f1b5a146ed to 552a965b707b (4 revisions) (flutter/flutter#148595) 2024-05-18 [email protected] Swap crash reporting with unified analytics (flutter/flutter#148525) 2024-05-17 [email protected] Roll Flutter Engine from 5b3bf9a950b2 to 93f1b5a146ed (3 revisions) (flutter/flutter#148581) 2024-05-17 [email protected] Migrate the flutter/flutter wiki to docs/unsorted_wiki (flutter/flutter#148562) 2024-05-17 [email protected] Roll Flutter Engine from 17decdf12557 to 5b3bf9a950b2 (3 revisions) (flutter/flutter#148567) 2024-05-17 [email protected] Shift a test on MotoG4 to staging, add it on Mokey (flutter/flutter#148552) 2024-05-17 [email protected] Revert "`if` chains � `switch` expressions" (flutter/flutter#148556) 2024-05-17 [email protected] Roll Packages from 87a02e3 to ae4dd32 (9 revisions) (flutter/flutter#148555) 2024-05-17 [email protected] Roll Flutter Engine from 7d244ab0348a to 17decdf12557 (1 revision) (flutter/flutter#148549) 2024-05-17 [email protected] Roll Flutter Engine from a19d3722922d to 7d244ab0348a (4 revisions) (flutter/flutter#148546) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
May 20, 2024
I did a goof a while back:  Now that [the bug is fixed](e9d4035), I think we're good to re-implement the if-chains cleanup! Related: - #147793 - #148556 - #148548
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@00425ef...adf279f 2024-05-18 [email protected] Fix template manifest test (flutter/flutter#148616) 2024-05-18 [email protected] Disable shuffling in the flutter_tools create_test suite (flutter/flutter#148619) 2024-05-18 [email protected] Move `Feedback` to widgets layer (flutter/flutter#148523) 2024-05-18 [email protected] Roll Flutter Engine from 93f1b5a146ed to 552a965b707b (4 revisions) (flutter/flutter#148595) 2024-05-18 [email protected] Swap crash reporting with unified analytics (flutter/flutter#148525) 2024-05-17 [email protected] Roll Flutter Engine from 5b3bf9a950b2 to 93f1b5a146ed (3 revisions) (flutter/flutter#148581) 2024-05-17 [email protected] Migrate the flutter/flutter wiki to docs/unsorted_wiki (flutter/flutter#148562) 2024-05-17 [email protected] Roll Flutter Engine from 17decdf12557 to 5b3bf9a950b2 (3 revisions) (flutter/flutter#148567) 2024-05-17 [email protected] Shift a test on MotoG4 to staging, add it on Mokey (flutter/flutter#148552) 2024-05-17 [email protected] Revert "`if` chains � `switch` expressions" (flutter/flutter#148556) 2024-05-17 [email protected] Roll Packages from 87a02e3 to ae4dd32 (9 revisions) (flutter/flutter#148555) 2024-05-17 [email protected] Roll Flutter Engine from 7d244ab0348a to 17decdf12557 (1 revision) (flutter/flutter#148549) 2024-05-17 [email protected] Roll Flutter Engine from a19d3722922d to 7d244ab0348a (4 revisions) (flutter/flutter#148546) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #147793
Introduced #148548.