[iOS] specify minimum os version for native asset frameworks #148504

knopp · 2024-05-16T18:30:26Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-05-16T18:30:29Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

knopp · 2024-05-16T18:32:15Z

@dcharkes is the plist file tested anywhere? Also the approach here is a bit ugly, the issue is that the plist key is different for macOS and iOS, and also as far as I can tell it is not mandatory.

flutter-dashboard · 2024-05-16T18:42:01Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

dcharkes · 2024-05-16T18:46:19Z

packages/flutter_tools/lib/src/isolated/native_assets/ios/native_assets.dart

I believe this value should come from somewhere.

(Also this value should be passed into the BuildConfig so that the build hook can fail if it cannot produce a dylib with the right iOS version (dart-lang/native#1133). This can be done in a separate PR though.)

dcharkes · 2024-05-16T18:47:48Z

Do we have the minimum iOS version that the app we're building is targeting somewhere? See the code that does the same for minimum android version: #148044 (comment)

dcharkes · 2024-05-16T18:50:34Z

@dcharkes is the plist file tested anywhere?

No. You could add it here:

flutter/packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart

Lines 314 to 348 in 6b38361

    
           void expectDylibIsBundledMacOS(Directory appDirectory, String buildMode) { 
        
             final Directory appBundle = appDirectory.childDirectory('build/$hostOs/Build/Products/${buildMode.upperCaseFirst()}/$exampleAppName.app'); 
        
             expect(appBundle, exists); 
        
             final Directory frameworksFolder = 
        
                 appBundle.childDirectory('Contents/Frameworks'); 
        
             expect(frameworksFolder, exists); 
        
             // MyFramework.framework/ 
        
             //   MyFramework  -> Versions/Current/MyFramework 
        
             //   Resources    -> Versions/Current/Resources 
        
             //   Versions/ 
        
             //     A/ 
        
             //       MyFramework 
        
             //       Resources/ 
        
             //         Info.plist 
        
             //     Current  -> A 
        
             const String frameworkName = packageName; 
        
             final Directory frameworkDir = 
        
                 frameworksFolder.childDirectory('$frameworkName.framework'); 
        
             final Directory versionsDir = frameworkDir.childDirectory('Versions'); 
        
             final Directory versionADir = versionsDir.childDirectory('A'); 
        
             final Directory resourcesDir = versionADir.childDirectory('Resources'); 
        
             expect(resourcesDir, exists); 
        
             final File dylibFile = versionADir.childFile(frameworkName); 
        
             expect(dylibFile, exists); 
        
             final Link currentLink = versionsDir.childLink('Current'); 
        
             expect(currentLink, exists); 
        
             expect(currentLink.resolveSymbolicLinksSync(), versionADir.path); 
        
             final Link resourcesLink = frameworkDir.childLink('Resources'); 
        
             expect(resourcesLink, exists); 
        
             expect(resourcesLink.resolveSymbolicLinksSync(), resourcesDir.path); 
        
             final Link dylibLink = frameworkDir.childLink(frameworkName); 
        
             expect(dylibLink, exists); 
        
             expect(dylibLink.resolveSymbolicLinksSync(), dylibFile.path); 
        
           }

knopp · 2024-05-16T18:52:28Z

Do we have the minimum iOS version that the app we're building is targeting somewhere? See the code that does the same for minimum android version: #148044 (comment)

I think this is right now hardcoded to 12.0 for App.framework inside AppFrameworkInfo.plist. There is also IPHONEOS_DEPLOYMENT_TARGET set by xcode during build that contains project deployment target. But I think the plugin should be able to specify own deployment target, that seems like the cleanest way.

dcharkes · 2024-05-16T18:55:59Z

I think this is right now hardcoded to 12.0 for App.framework inside AppFrameworkInfo.plist. There is also IPHONEOS_DEPLOYMENT_TARGET set by xcode during build that contains project deployment target. But I think the plugin should be able to specify own deployment target, that seems like the cleanest way.

cc @vashworth and @jmagman What is the interplay between XCode and a Flutter app on the minimal iOS version?

jmagman · 2024-05-16T19:57:08Z

What is the interplay between XCode and a Flutter app on the minimal iOS version?

The target version is the minimum support by latest Xcode. https://flutter.dev/go/match-xcode-deployment-range

This document proposes that Flutter’s supported deployment platform versions be updated when Xcode is released annually to match its deployment versions. Versions lower than the Xcode range will become unsupported.

Right now it's set in the tool in a bunch of places, see #140823 for the last time we had to bump it (note the changes in dev and example weren't manually updated, those are automatically migrated example/test apps).

@vashworth filed #145104 to make this settable in fewer places.

dcharkes · 2024-05-17T06:10:17Z

Thanks @jmagman!

Then I'm fine landing as is once we added a test. And maybe leave a comment on #145104 so that it doesn't get forgotten.

knopp · 2024-05-20T09:48:49Z

@dcharkes, I added test and a TODO to wire things once hook can specify deployment target. There is another issue - the bundle identifier must not contain underscores, we should replace them by - probably. Should that be part of this PR or should I make separate PR for it?

knopp · 2024-05-20T10:01:49Z

Sanitizing the bundle identifier seems like a tiny change, I added it to this PR.

knopp · 2024-05-20T14:47:50Z

@dcharkes, just a heads up, with this PR we have been able to get an app uploaded through AppStore connect.

dcharkes

Thanks so much for triaging and supplying a PR @knopp! ❤️ LGTM! 🚀

…lutter/flutter#148504)

flutter/flutter@d02292d...73bf206 2024-05-22 [email protected] `CupertinoDialogRoute` leak fix (flutter/flutter#148774) 2024-05-22 [email protected] Marks Windows plugin_test to be flaky (flutter/flutter#148835) 2024-05-22 [email protected] Add tests for actions.0.dart API example. (flutter/flutter#148678) 2024-05-22 [email protected] Introduce `WidgetStateBorderSide.lerp` (flutter/flutter#148122) 2024-05-22 [email protected] add `default-flavor` field to flutter pubspec, which will be used as the flavor in `flutter build/run` if `--flavor` is not provided (flutter/flutter#147968) 2024-05-22 [email protected] [wiki migration] Pages under docs/postmortems/ (flutter/flutter#148798) 2024-05-22 [email protected] Roll Flutter Engine from e5a73e520e89 to c89defa55801 (2 revisions) (flutter/flutter#148812) 2024-05-22 [email protected] Make hover tests functional and cleanup mouse pointers in Material toggleables (flutter/flutter#148808) 2024-05-21 [email protected] Fix two dimensional viewport unexpected null exception when no child is laid out (flutter/flutter#148256) 2024-05-21 [email protected] Roll Flutter Engine from bc1345b6b50a to e5a73e520e89 (3 revisions) (flutter/flutter#148807) 2024-05-21 [email protected] Add test for undo_history_controller.0.dart (flutter/flutter#148205) 2024-05-21 [email protected] Roll Flutter Engine from a8872c8915a2 to bc1345b6b50a (6 revisions) (flutter/flutter#148802) 2024-05-21 [email protected] Fix test that leaks images. (flutter/flutter#148494) 2024-05-21 [email protected] Fix warnings in `dependency_version_checker.gradle.kts` (flutter/flutter#148699) 2024-05-21 [email protected] [wiki migration] Android team pages (flutter/flutter#148585) 2024-05-21 [email protected] Fix leaky test. (flutter/flutter#148788) 2024-05-21 [email protected] Add DropdownButton.menuWidth (flutter/flutter#148125) 2024-05-21 [email protected] Add test for focus example 2 (flutter/flutter#147624) 2024-05-21 [email protected] Add a migrator to remove `FlutterMultiDexApplication.java` (flutter/flutter#148515) 2024-05-21 [email protected] [wiki migration] Infra team pages (flutter/flutter#148718) 2024-05-21 [email protected] Roll Flutter Engine from 8a352f01e503 to a8872c8915a2 (1 revision) (flutter/flutter#148776) 2024-05-21 [email protected] Fix the output of the CDN test. (flutter/flutter#148730) 2024-05-21 [email protected] [wiki migration] Release team pages (flutter/flutter#148723) 2024-05-21 [email protected] Remove hidden dependencies on LocalProcessManager (flutter/flutter#148096) 2024-05-21 [email protected] Adds Missing `onHover` & `onFocusChange` for `OutlinedButton.icon` (flutter/flutter#144374) 2024-05-21 [email protected] Adds tests to NestedScrollView examples (flutter/flutter#148170) 2024-05-21 [email protected] Roll Flutter Engine from c2ef01f6f1ab to 8a352f01e503 (18 revisions) (flutter/flutter#148766) 2024-05-21 [email protected] `switch` expressions: finale (flutter/flutter#148711) 2024-05-21 [email protected] [iOS] specify minimum os version for native asset frameworks (flutter/flutter#148504) 2024-05-21 [email protected] Removed brand references from MenuAnchor.dart (flutter/flutter#148760) 2024-05-21 [email protected] Skip flaky test in expression_evaluation_test.dart (flutter/flutter#148737) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Pass in the minimum iOS and MacOS version. Roll dart-lang/native deps. Related issues: * #145104 * Relevant discussion: #148504

…lutter/flutter#148504)

tnarik · 2025-11-24T22:19:36Z

I've been trying to build and release via TestFlight an app using Thermion (which requires iOS 13.0).
The library suggests an override of the MinimumOSVersion via a scripts (as in https://thermion.dev/ios ), but I was checking and apparently this could be supported within Flutter, right?

This commit adds the capability to provide the version from the script and the only thing missing (if I understood the conversation) is ensuring a value passed via configuration is used here. I think that part was pending on dart-lang/native#1133 ? correct, @knopp ?

It seems closed now. Is there something I could do to help?

dcharkes · 2025-11-25T09:24:24Z

@tnarik This works the other way around, the end user specifies the minimum iOS version in their app. Then this version is passed into the build hook and is available as in https://pub.dev/documentation/code_assets/latest/code_assets/IOSCodeConfig/targetVersion.html.

You should then throw an UnsupportedError in your build hook if the iOS version is not supported.

tnarik · 2025-11-25T12:56:58Z

I see, so this would be for the package to support that hook? should I let the developer of Thermion know?

apologies if I am asking nonsensical questions, I've been playing aroudn with Flutter, but I don't understand fully the build process. I only noticed that the native assets (Thermion ones at least) are set to 12.0, while everything else I have seen as a result of 'flutter build ios' is 13.0, and the minimum iOS version for the default App is 13.0 (but I still see that 12.0 in flutter_tools, which is confusing me).

edit: or, let's see if I get it: what this and dart-lang/native#1133 add is to allow the hook to fail if the package would not be compatible with that target version, BUT it has nothing to do with the fact that the generated Info.plist will have a

        <key>MinimumOSVersion</key>
	<string>12.0</string>

, because that is what the native_assets script uses in order to generate the Info.plist?

dcharkes · 2025-11-25T14:15:00Z

Then this version is passed into the build hook and is available as in https://pub.dev/documentation/code_assets/latest/code_assets/IOSCodeConfig/targetVersion.html.

This is not true. (I would like it to be true, but we don't read the cocoapods specs to fish out the number.) It's a hardcoded number right now. Bumping it from 12 to 13 to align with the Flutter supported lowest version:

[native assets] Bump minimum iOS version from 12 to 13 #179079

@tnarik, since Flutter only supports 13 and up, it should probably be fine as long as the Flutter SDK lower bound on your package is the that moved the lowest supported version up to 13.

@tnarik

We don't have a single place to update the minimum iOS version in the code base: * #145104 So, when the minimum version was bumped, one place was missed. Thanks for reporting @tnarik! (#148504 (comment))

@tnarik

We don't have a single place to update the minimum iOS version in the code base: * flutter#145104 So, when the minimum version was bumped, one place was missed. Thanks for reporting @tnarik! (flutter#148504 (comment))

@tnarik

We don't have a single place to update the minimum iOS version in the code base: * flutter#145104 So, when the minimum version was bumped, one place was missed. Thanks for reporting @tnarik! (flutter#148504 (comment))

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels May 16, 2024

knopp marked this pull request as draft May 16, 2024 18:38

dcharkes reviewed May 16, 2024

View reviewed changes

knopp marked this pull request as ready for review May 20, 2024 10:07

knopp added 3 commits May 20, 2024 16:46

[iOS] specify minimum os version for native asset frameworks

fd9bc8b

Test and TODO comment

d914bff

Sanitize CFBundleIdentifier

2237e92

knopp force-pushed the native_assets_specify_min_ios_version branch from e33408b to 2237e92 Compare May 20, 2024 14:46

dcharkes approved these changes May 21, 2024

View reviewed changes

knopp added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2024

auto-submit bot merged commit 454dd7e into flutter:master May 21, 2024

engine-flutter-autoroll mentioned this pull request May 22, 2024

Roll Flutter from d02292dbc409 to 73bf206f35e7 (31 revisions) flutter/packages#6780

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2024

454dd7e [iOS] specify minimum os version for native asset frameworks (f…

e4f82df

…lutter/flutter#148504)

knopp mentioned this pull request Jun 10, 2024

[native_assets] There's two errors thrown by Xcode 15.3 when submitting Flutter apps built with native_assets to the App Store. #148044

Closed

dcharkes mentioned this pull request Jul 8, 2024

[deps] Roll dart-lang/native packages #151403

Merged

9 tasks

auto-submit bot pushed a commit that referenced this pull request Jul 9, 2024

[deps] Roll dart-lang/native packages (#151403)

9ab8b6e

Pass in the minimum iOS and MacOS version. Roll dart-lang/native deps. Related issues: * #145104 * Relevant discussion: #148504

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

454dd7e [iOS] specify minimum os version for native asset frameworks (f…

7624224

…lutter/flutter#148504)

dcharkes mentioned this pull request Nov 25, 2025

[native assets] Bump minimum iOS version from 12 to 13 #179079

Merged

[iOS] specify minimum os version for native asset frameworks #148504

[iOS] specify minimum os version for native asset frameworks #148504

Uh oh!

Conversation

knopp commented May 16, 2024

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 16, 2024

Uh oh!

knopp commented May 16, 2024

Uh oh!

flutter-dashboard bot commented May 16, 2024

Uh oh!

dcharkes May 16, 2024

Choose a reason for hiding this comment

Uh oh!

dcharkes commented May 16, 2024

Uh oh!

dcharkes commented May 16, 2024

Uh oh!

knopp commented May 16, 2024

Uh oh!

dcharkes commented May 16, 2024

Uh oh!

jmagman commented May 16, 2024

Uh oh!

dcharkes commented May 17, 2024

Uh oh!

knopp commented May 20, 2024

Uh oh!

knopp commented May 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

knopp commented May 20, 2024

Uh oh!

dcharkes left a comment

Choose a reason for hiding this comment

Uh oh!

tnarik commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcharkes commented Nov 25, 2025

Uh oh!

tnarik commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcharkes commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

knopp commented May 20, 2024 •

edited

Loading

tnarik commented Nov 24, 2025 •

edited

Loading

tnarik commented Nov 25, 2025 •

edited

Loading

dcharkes commented Nov 25, 2025 •

edited

Loading