Add test for future_builder.0.dart #148453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
ValentinVignal
force-pushed
the
flutter/api/example/Add-test-to-future-builder
branch
from
5975ab7 to
567a259
Compare
TahaTesser
requested changes
May 20, 2024
Member
TahaTesser
left a comment
TahaTesser
left a comment
There was a problem hiding this comment.
test_log.txt file doesn't seem to belong in this PR
…/Add-test-to-future-builder # Conflicts: # dev/bots/check_code_samples.dart
Contributor
Author
Oops very sorry about that! This should be good now |
TahaTesser
approved these changes
May 27, 2024
TahaTesser
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 27, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 27, 2024
flutter/flutter@6564471...0b31ffc 2024-05-27 [email protected] Roll Flutter Engine from 451480f2bf66 to dcc063c8deae (1 revision) (flutter/flutter#149125) 2024-05-27 [email protected] Roll Flutter Engine from 76f5849eec5d to 451480f2bf66 (1 revision) (flutter/flutter#149123) 2024-05-27 [email protected] Roll Flutter Engine from 2b92f87cb5c1 to 76f5849eec5d (1 revision) (flutter/flutter#149121) 2024-05-27 [email protected] Add test for future_builder.0.dart (flutter/flutter#148453) 2024-05-27 [email protected] Roll Flutter Engine from 469193ef0e9a to 2b92f87cb5c1 (1 revision) (flutter/flutter#149119) 2024-05-27 [email protected] Roll Flutter Engine from e91fbacde56d to 469193ef0e9a (1 revision) (flutter/flutter#149114) 2024-05-27 [email protected] Roll Flutter Engine from f3025ae1511b to e91fbacde56d (1 revision) (flutter/flutter#149101) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
Contributes to flutter#130459 It adds a test for - `examples/api/lib/widgets/async/future_builder.0.dart`
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/lib/widgets/async/future_builder.0.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.