Skip to content

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented May 15, 2024

Fix #147600

internal GAR issue: b/316933135

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 15, 2024
@hannah-hyj hannah-hyj requested a review from chunhtai May 15, 2024 22:33
@hannah-hyj hannah-hyj changed the title Slide should respect bold text setting [a11y] Slide should respect bold text setting May 15, 2024
@hannah-hyj hannah-hyj changed the title [a11y] Slide should respect bold text setting [a11y] Slider should respect bold text setting May 15, 2024
@hannah-hyj hannah-hyj requested a review from TahaTesser May 21, 2024 19:38
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@hannah-hyj hannah-hyj requested a review from TahaTesser May 22, 2024 19:04
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented May 23, 2024

auto label is removed for flutter/flutter/148435, Failed to merge flutter/flutter/148435 with Pull request flutter/flutter/148435 could not be merged: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information..

@hannah-hyj
Copy link
Member Author

The PR should be merging into flutter:master instead of flutter:main , reopening it as #149053, @TahaTesser can you review it again?

auto-submit bot pushed a commit that referenced this pull request May 24, 2024
Fix #147600

internal GAR issue: b/316933135

reopen from #148435
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants