ThemeData minor spring cleaning
#148408
Merged
ThemeData minor spring cleaning
#148408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do a bit of sprucing up of `ThemeData` in anticipation of future work
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
framework
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
test-exempt: code cleanup! |
Member
Author
|
thanks! |
guidezpl
added
the
autosubmit
guidezpl
changed the title
ThemeData minor spring cleaning
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 16, 2024
flutter/flutter@39651e8...0d22d91 2024-05-16 [email protected] fixes `DialogRoute` memory leak (flutter/flutter#147816) 2024-05-16 [email protected] Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476) 2024-05-16 [email protected] Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469) 2024-05-16 [email protected] Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465) 2024-05-16 [email protected] ThemeData minor spring cleaning (flutter/flutter#148408) 2024-05-16 [email protected] Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403) 2024-05-16 [email protected] plugin_ffi template comment fix (flutter/flutter#148378) 2024-05-16 [email protected] Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455) 2024-05-16 [email protected] Reland fix TextField helper top padding on M3 (flutter/flutter#146754) 2024-05-16 [email protected] Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281) 2024-05-16 [email protected] Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450) 2024-05-16 [email protected] Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448) 2024-05-16 [email protected] Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445) 2024-05-16 [email protected] Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441) 2024-05-15 [email protected] Fix leaky tests. (flutter/flutter#148434) 2024-05-15 [email protected] Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430) 2024-05-15 [email protected] Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428) 2024-05-15 [email protected] Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter/flutter#147901) 2024-05-15 [email protected] Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373) 2024-05-15 [email protected] Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061) 2024-05-15 [email protected] Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265) 2024-05-15 [email protected] Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419) 2024-05-15 [email protected] Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@39651e8...0d22d91 2024-05-16 [email protected] fixes `DialogRoute` memory leak (flutter/flutter#147816) 2024-05-16 [email protected] Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476) 2024-05-16 [email protected] Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469) 2024-05-16 [email protected] Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465) 2024-05-16 [email protected] ThemeData minor spring cleaning (flutter/flutter#148408) 2024-05-16 [email protected] Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403) 2024-05-16 [email protected] plugin_ffi template comment fix (flutter/flutter#148378) 2024-05-16 [email protected] Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455) 2024-05-16 [email protected] Reland fix TextField helper top padding on M3 (flutter/flutter#146754) 2024-05-16 [email protected] Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281) 2024-05-16 [email protected] Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450) 2024-05-16 [email protected] Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448) 2024-05-16 [email protected] Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445) 2024-05-16 [email protected] Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441) 2024-05-15 [email protected] Fix leaky tests. (flutter/flutter#148434) 2024-05-15 [email protected] Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430) 2024-05-15 [email protected] Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428) 2024-05-15 [email protected] Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter/flutter#147901) 2024-05-15 [email protected] Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373) 2024-05-15 [email protected] Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061) 2024-05-15 [email protected] Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265) 2024-05-15 [email protected] Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419) 2024-05-15 [email protected] Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a bit of sprucing up of
ThemeDatain anticipation of future workRelated: #91772
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.