Reverts "Reland Native ios context menu (#143002) (#148238)" #148254

auto-submit · 2024-05-13T20:49:04Z

Initiated by: zanderso

Reason for reverting: Failures in post submit https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748025189669617649/+/u/run_test.dart_for_web_canvaskit_tests_shard_and_subshard_3/stdout

Original PR Author: justinmc

Reviewed By: {hellohuanlin}

This change reverts the following previous change:
Reland of #143002, which was reverted in #148237 due to unresolved docs references. Not sure why those weren't caught in presubmit.

dartdoc:stdout: Generating docs for package flutter...
dartdoc:stderr:   error: unresolved doc reference [TextInput.showSystemContextMenu]
dartdoc:stderr:     from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr:     in documentation inherited from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr:   error: unresolved doc reference [showSystemContextMenu]
dartdoc:stderr:     from services.SystemContextMenuController.hide: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2554:16)
dartdoc:stderr:   error: unresolved doc reference [hideSystemContextMenu]
dartdoc:stderr:     from services.SystemContextMenuController.show: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2509:16)

This reverts commit 42b3d9e.

…148254)" This reverts commit 45e80fd.

…lutter/flutter#148254)

flutter/flutter@1255435...d2da1b2 2024-05-14 [email protected] Roll Flutter Engine from 491f460a25fb to 7bf865774d06 (1 revision) (flutter/flutter#148325) 2024-05-14 [email protected] Roll Packages from 1412041 to fd714bd (1 revision) (flutter/flutter#148324) 2024-05-14 [email protected] Roll Flutter Engine from c381b852605f to 491f460a25fb (1 revision) (flutter/flutter#148319) 2024-05-14 [email protected] Roll Flutter Engine from b4b798d2e706 to c381b852605f (1 revision) (flutter/flutter#148303) 2024-05-14 [email protected] Roll Flutter Engine from 0de6701b537a to b4b798d2e706 (2 revisions) (flutter/flutter#148299) 2024-05-14 [email protected] Roll Flutter Engine from 764c33c3c773 to 0de6701b537a (2 revisions) (flutter/flutter#148297) 2024-05-14 [email protected] Roll Flutter Engine from 797eab742925 to 764c33c3c773 (1 revision) (flutter/flutter#148290) 2024-05-14 [email protected] Roll Flutter Engine from 84687fe0f199 to 797eab742925 (1 revision) (flutter/flutter#148288) 2024-05-14 [email protected] Roll Flutter Engine from bee398d95abe to 84687fe0f199 (3 revisions) (flutter/flutter#148282) 2024-05-14 [email protected] Roll Flutter Engine from a1cdcb6a6687 to bee398d95abe (2 revisions) (flutter/flutter#148280) 2024-05-14 [email protected] Roll Flutter Engine from 13a561cb6d5a to a1cdcb6a6687 (1 revision) (flutter/flutter#148276) 2024-05-14 [email protected] Roll Flutter Engine from 7dcbd93e5c1a to 13a561cb6d5a (6 revisions) (flutter/flutter#148274) 2024-05-13 [email protected] Roll Flutter Engine from aeff9b174c84 to 7dcbd93e5c1a (1 revision) (flutter/flutter#148266) 2024-05-13 [email protected] Mark platform_views_scroll_perf_ad_banners__timeline_summary not flaky (flutter/flutter#148263) 2024-05-13 [email protected] add more print traces in hot runner workflow (flutter/flutter#148258) 2024-05-13 [email protected] Refactors page API (flutter/flutter#137792) 2024-05-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.3 to 3.25.5 (flutter/flutter#148262) 2024-05-13 [email protected] Roll Flutter Engine from 11502404a52a to aeff9b174c84 (2 revisions) (flutter/flutter#148260) 2024-05-13 [email protected] Use super.key instead of manually passing the Key parameter to the parent class (flutter/flutter#147621) 2024-05-13 [email protected] Try fix module test (flutter/flutter#147934) 2024-05-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Native ios context menu (#143002) (#148238)" (flutter/flutter#148254) 2024-05-13 [email protected] Reland Native ios context menu (#143002) (flutter/flutter#148238) 2024-05-13 [email protected] Roll Flutter Engine from 636374fd00ee to 11502404a52a (1 revision) (flutter/flutter#148242) 2024-05-13 [email protected] Roll Packages from 6c4482a to 1412041 (16 revisions) (flutter/flutter#148239) 2024-05-13 [email protected] Roll Flutter Engine from 0050bf9a8094 to 636374fd00ee (1 revision) (flutter/flutter#148216) 2024-05-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Native ios context menu (#143002)" (flutter/flutter#148237) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/flutter#148254)

Revert "Reland Native ios context menu (#143002) (#148238)"

69cd8a0

This reverts commit 42b3d9e.

auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label May 13, 2024

auto-submit bot assigned zanderso May 13, 2024

fluttergithubbot approved these changes May 13, 2024

View reviewed changes

auto-submit bot merged commit 45e80fd into master May 13, 2024

auto-submit bot deleted the revert_42b3d9eb7f363026c74ca0b1cd0d204fe5bb4651 branch May 13, 2024 20:50

justinmc added a commit that referenced this pull request May 13, 2024

Revert "Reverts "Reland Native ios context menu (#143002) (#148238)" (#…

bc890c4

…148254)" This reverts commit 45e80fd.

engine-flutter-autoroll mentioned this pull request May 14, 2024

Roll Flutter from 125543505d26 to cb656c21f082 (23 revisions) flutter/packages#6726

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

45e80fd Reverts "Reland Native ios context menu (#143002) (#148238)" (f…

66d37b4

…lutter/flutter#148254)

engine-flutter-autoroll mentioned this pull request May 14, 2024

Roll Flutter from 125543505d26 to a39555d4fe89 (24 revisions) flutter/packages#6728

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

45e80fd Reverts "Reland Native ios context menu (#143002) (#148238)" (f…

dd3423a

…lutter/flutter#148254)

engine-flutter-autoroll mentioned this pull request May 14, 2024

Roll Flutter from 125543505d26 to d2da1b280b51 (26 revisions) flutter/packages#6729

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

45e80fd Reverts "Reland Native ios context menu (#143002) (#148238)" (f…

4ba2f39

…lutter/flutter#148254)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

45e80fd Reverts "Reland Native ios context menu (#143002) (#148238)" (f…

c7a139e

…lutter/flutter#148254)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reverts "Reland Native ios context menu (#143002) (#148238)" #148254

Reverts "Reland Native ios context menu (#143002) (#148238)" #148254

Uh oh!

auto-submit bot commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reverts "Reland Native ios context menu (#143002) (#148238)" #148254

Reverts "Reland Native ios context menu (#143002) (#148238)" #148254

Uh oh!

Conversation

auto-submit bot commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants