Fix the second TextFormField to trigger onTapOutside #148206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
Contributor
|
Hey @wyqlxf is this implementing the suggestion in #148112 (comment)? |
Contributor
Author
Yes, this is in response to the suggestion (comment) in execution #148112, Provide a separate click area groupId object for each text field, Thank you very much to @gspencergoog for the suggestion. |
github-actions
bot
added
the
f: cupertino
gspencergoog
approved these changes
May 17, 2024
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
justinmc
approved these changes
May 20, 2024
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM with nits 👍
And I have one more nit about the test organization for you. It feels backwards to me. I would think that the tests in editable_text_test that just expect that groupId is set would be on TextField, TextFormField, and CupertinoTextField, expecting that they have passed the groupId down to their EditableTexts. Similarly, I would do the test that you currently have on CupertinoTextField and TextFormField in editable_text_test instead, so that the functionality is tested once there.
added 7 commits
May 22, 2024 15:41
Renzo-Olivares
added a commit
that referenced
this pull request
May 22, 2024
This reverts commit 9acbc1d.
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
May 23, 2024
…ps://github.com/hello-coder-xu/flutter into fix/_floatingActionButtonVisibilityValue-update * 'fix/_floatingActionButtonVisibilityValue-update' of https://github.com/hello-coder-xu/flutter: fix: update _floatingActionButtonVisibility only if floatingActionButton is not null [wiki migration] Remaining pages under docs/about/ (flutter#148782) Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter#148883) Fix the second TextFormField to trigger onTapOutside (flutter#148206) Try removing robolectric from `integration_test` tests (flutter#148803) Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter#147160) [wiki migration] Tool team pages (flutter#148779) Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter#148819) [native_assets] Add support for link hooks (flutter#148474) Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter#148864) Update tokens to 4.0.0 (flutter#148789) Move Linux web_long_running_tests_2_5 to bringup (flutter#148854) `CupertinoDialogRoute` leak fix (flutter#148774) Marks Windows plugin_test to be flaky (flutter#148835)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 23, 2024
flutter/flutter@73bf206...8d955cd 2024-05-23 [email protected] Update `FocusManager` platform check to include iOS (flutter/flutter#148612) 2024-05-23 [email protected] [iOS] fix hot restart with native assets (flutter/flutter#148752) 2024-05-23 [email protected] Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943) 2024-05-23 [email protected] Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621) 2024-05-23 [email protected] Test raw autocomplete api examples (flutter/flutter#148234) 2024-05-23 [email protected] Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166) 2024-05-23 [email protected] Add tests for restorable_value.0.dart API example. (flutter/flutter#148676) 2024-05-23 [email protected] Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919) 2024-05-22 [email protected] Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897) 2024-05-22 [email protected] 3.22.1 changelog updates (flutter/flutter#148895) 2024-05-22 [email protected] Add frame number and widget location map service extension (flutter/flutter#148702) 2024-05-22 [email protected] Remove an assert with false positives (flutter/flutter#148795) 2024-05-22 [email protected] Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909) 2024-05-22 [email protected] [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782) 2024-05-22 [email protected] Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883) 2024-05-22 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206) 2024-05-22 [email protected] Try removing robolectric from `integration_test` tests (flutter/flutter#148803) 2024-05-22 [email protected] Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160) 2024-05-22 [email protected] [wiki migration] Tool team pages (flutter/flutter#148779) 2024-05-22 [email protected] Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819) 2024-05-22 [email protected] [native_assets] Add support for link hooks (flutter/flutter#148474) 2024-05-22 [email protected] Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864) 2024-05-22 [email protected] Update tokens to 4.0.0 (flutter/flutter#148789) 2024-05-22 [email protected] Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
This PR attempts to fix flutter#127597
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #127597
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.