Add test for tab_controller.1.dart API example. #148189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #148189 at sha ae4187cfdb4a7a1f21a2410607dd7c480406456f |
bleroux
approved these changes
May 20, 2024
Contributor
bleroux
left a comment
bleroux
left a comment
There was a problem hiding this comment.
LGTM! It is great to have an example that demonstrates good practice on how to properly clean listeners 🙏 .
ksokolovskyi
force-pushed
the
add-tab-controller-example-tests
branch
from
29161d7 to
6cb58f7
Compare
bleroux
added
the
autosubmit
Contributor
Author
|
@bleroux @TahaTesser thanks a lot for the review and merge! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 20, 2024
flutter/flutter@adf279f...02a6c91 2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497) 2024-05-20 [email protected] Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679) 2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189) 2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178) 2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637) 2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654) 2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652) 2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@adf279f...02a6c91 2024-05-20 [email protected] Add test for image.error_builder.0.dart API example. (flutter/flutter#148497) 2024-05-20 [email protected] Roll Packages from ae4dd32 to ba19b24 (3 revisions) (flutter/flutter#148679) 2024-05-20 [email protected] Add test for tab_controller.1.dart API example. (flutter/flutter#148189) 2024-05-20 [email protected] Add test for fade_transition.0.dart API example. (flutter/flutter#148178) 2024-05-20 [email protected] Add tests for scaffold.of.#.dart API examples. (flutter/flutter#147637) 2024-05-20 [email protected] Roll Flutter Engine from 9d00f77f243f to c6fecf65fbf3 (1 revision) (flutter/flutter#148654) 2024-05-20 [email protected] Roll Flutter Engine from 426dbb125861 to 9d00f77f243f (1 revision) (flutter/flutter#148652) 2024-05-19 [email protected] Roll Flutter Engine from 552a965b707b to 426dbb125861 (2 revisions) (flutter/flutter#148630) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #130459
Description
examples/api/lib/material/tab_controller/tab_controller.1.dartto properly remove the listener from theTabControllerexamples/api/lib/material/tab_controller/tab_controller.1.dartPre-launch Checklist
///).