Add test for scaffold.0.dart and scaffold.2.dart #148166

ValentinVignal · 2024-05-11T08:19:02Z

Contributes to #130459

It adds test for

examples/api/lib/material/scaffold/scaffold.0.dart
examples/api/lib/material/scaffold/scaffold.2.dart

It also modifies the scaffold.1_test.dart because the only difference with scaffold 0 is the background color, so I figured the test should include it

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-05-11T09:01:11Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #148166 at sha 631e3cfd01a49e0652315ce1a9e197fe2a148d87

flutter-dashboard · 2024-05-11T15:50:13Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #148166 at sha 2456f13bdbbf816b41bd0175aa87cbbcee6b98b3

ValentinVignal · 2024-05-14T06:51:58Z

I don't understand this comment about the changing goldens. the tests I modified / created don't contain any golden match, and I didn't modify any flutter code.
What am I supposed to do/not do ?

goderbauer · 2024-05-14T22:16:28Z

That message about the golden images is probably a flake. I am going to rebase this to see if it goes away.

bleroux

LGTM! Thanks for the contribution.
I just left one comment related to an extra line.

bleroux · 2024-05-20T08:30:03Z

examples/api/test/material/scaffold/scaffold.2_test.dart

Consider removing this empty line.

TahaTesser

LGTM with nit

examples/api/test/material/scaffold/scaffold.2_test.dart

auto-submit · 2024-05-20T08:40:59Z

auto label is removed for flutter/flutter/148166, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tter#148166)

flutter/flutter@73bf206...8d955cd 2024-05-23 [email protected] Update `FocusManager` platform check to include iOS (flutter/flutter#148612) 2024-05-23 [email protected] [iOS] fix hot restart with native assets (flutter/flutter#148752) 2024-05-23 [email protected] Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943) 2024-05-23 [email protected] Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621) 2024-05-23 [email protected] Test raw autocomplete api examples (flutter/flutter#148234) 2024-05-23 [email protected] Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166) 2024-05-23 [email protected] Add tests for restorable_value.0.dart API example. (flutter/flutter#148676) 2024-05-23 [email protected] Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919) 2024-05-22 [email protected] Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897) 2024-05-22 [email protected] 3.22.1 changelog updates (flutter/flutter#148895) 2024-05-22 [email protected] Add frame number and widget location map service extension (flutter/flutter#148702) 2024-05-22 [email protected] Remove an assert with false positives (flutter/flutter#148795) 2024-05-22 [email protected] Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909) 2024-05-22 [email protected] [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782) 2024-05-22 [email protected] Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883) 2024-05-22 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206) 2024-05-22 [email protected] Try removing robolectric from `integration_test` tests (flutter/flutter#148803) 2024-05-22 [email protected] Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160) 2024-05-22 [email protected] [wiki migration] Tool team pages (flutter/flutter#148779) 2024-05-22 [email protected] Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819) 2024-05-22 [email protected] [native_assets] Add support for link hooks (flutter/flutter#148474) 2024-05-22 [email protected] Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864) 2024-05-22 [email protected] Update tokens to 4.0.0 (flutter/flutter#148789) 2024-05-22 [email protected] Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Contributes to flutter#130459 It adds test for - `examples/api/lib/material/scaffold/scaffold.0.dart` - `examples/api/lib/material/scaffold/scaffold.2.dart` It also modifies the `scaffold.1_test.dart` because the only difference with scaffold 0 is the background color, so I figured the test should include it

…tter#148166)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 11, 2024

flutter-dashboard bot added the will affect goldens Changes to golden files label May 11, 2024

ValentinVignal force-pushed the Add-test-to-scaffold-0 branch from 631e3cf to 2456f13 Compare May 11, 2024 15:04

goderbauer force-pushed the Add-test-to-scaffold-0 branch from 2456f13 to 6974612 Compare May 14, 2024 22:16

goderbauer requested review from TahaTesser and bleroux May 14, 2024 22:16

bleroux approved these changes May 20, 2024

View reviewed changes

examples/api/test/material/scaffold/scaffold.2_test.dart Outdated

Copy link

Contributor

bleroux May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing this empty line.

TahaTesser approved these changes May 20, 2024

View reviewed changes

examples/api/test/material/scaffold/scaffold.2_test.dart Outdated Show resolved Hide resolved

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

bleroux force-pushed the Add-test-to-scaffold-0 branch from 501d835 to 199ae84 Compare May 21, 2024 18:58

ValentinVignal and others added 2 commits May 22, 2024 10:20

test: Add test for scaffold.0 and scaffold.2

5806f4f

Update examples/api/test/material/scaffold/scaffold.2_test.dart

b035785

TahaTesser force-pushed the Add-test-to-scaffold-0 branch from 199ae84 to b035785 Compare May 22, 2024 07:20

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024

auto-submit bot merged commit 84876e5 into flutter:master May 23, 2024

engine-flutter-autoroll mentioned this pull request May 23, 2024

Roll Flutter from 73bf206f35e7 to c14d55c4d225 (22 revisions) flutter/packages#6783

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024

84876e5 Add test for scaffold.0.dart and scaffold.2.dart (flutter/flu…

385813c

…tter#148166)

engine-flutter-autoroll mentioned this pull request May 23, 2024

Roll Flutter from 73bf206f35e7 to 02d5286e02e4 (23 revisions) flutter/packages#6785

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024

84876e5 Add test for scaffold.0.dart and scaffold.2.dart (flutter/flu…

cef471c

…tter#148166)

engine-flutter-autoroll mentioned this pull request May 23, 2024

Roll Flutter from 73bf206f35e7 to 8d955cdd644e (24 revisions) flutter/packages#6786

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024

84876e5 Add test for scaffold.0.dart and scaffold.2.dart (flutter/flu…

aa1cff2

…tter#148166)

Piinks mentioned this pull request May 31, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

84876e5 Add test for scaffold.0.dart and scaffold.2.dart (flutter/flu…

739fced

…tter#148166)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add test for scaffold.0.dart and scaffold.2.dart #148166

Add test for scaffold.0.dart and scaffold.2.dart #148166

Uh oh!

ValentinVignal commented May 11, 2024

Uh oh!

flutter-dashboard bot commented May 11, 2024

Uh oh!

flutter-dashboard bot commented May 11, 2024

Uh oh!

ValentinVignal commented May 14, 2024

Uh oh!

goderbauer commented May 14, 2024

Uh oh!

bleroux left a comment

Uh oh!

bleroux May 20, 2024

Uh oh!

TahaTesser left a comment

Uh oh!

Uh oh!

auto-submit bot commented May 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add test for scaffold.0.dart and scaffold.2.dart #148166

Add test for scaffold.0.dart and scaffold.2.dart #148166

Uh oh!

Conversation

ValentinVignal commented May 11, 2024

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented May 11, 2024

Uh oh!

flutter-dashboard bot commented May 11, 2024

Uh oh!

ValentinVignal commented May 14, 2024

Uh oh!

goderbauer commented May 14, 2024

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux May 20, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented May 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants