Skip to content

Don't pin package:macros #148087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 3 commits into from
May 9, 2024
Merged

Don't pin package:macros #148087

christopherfujino merged 3 commits into from
May 9, 2024

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented May 9, 2024

Full context #148004

TL;DR

  1. Because package:macros depends on package:_macros via a Dart SDK dependency; and
  2. package:macros exactly pins package:_macros; and
  3. Each new version of package:macros will increment its exact pin of package:_macros (comment); and
  4. The flutter/flutter repository exactly pins the Dart SDK (via its exact pin on the flutter/engine repository

Therefore, the flutter/flutter repository effectively pins both package:macros and package:_macros already (as in, there exists only a single version of each that pub will successfully be able to solve within the context of a particular Flutter SDK).

Therefore, it is safe for flutter/flutter repository to not pin package:macros, which will allow engine -> framework rolls that contain a new Dart SDK that contains a new package:_macros version to land automatically, provided all tests pass.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels May 9, 2024
@christopherfujino christopherfujino marked this pull request as draft May 9, 2024 20:29
@christopherfujino christopherfujino changed the title Don't pin package:macros Don't pin package:macros DO NOT MERGE May 9, 2024
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label May 9, 2024
@christopherfujino
Copy link
Contributor Author

christopherfujino commented May 9, 2024 •
edited
Loading

For science, I pushed the commit 58a3acd, which rolls the engine to an older roll that failed CI in #148008, because pub was not able to solve successfully with the exact pins of package:macros. If CI passes on that commit, I will revert it and land this change without it, and then re-enable the dart -> engine roller (FYI @rmacnak-google)

@christopherfujino
Copy link
Contributor Author

christopherfujino commented May 9, 2024 •
edited
Loading

For science, I pushed the commit 58a3acd, which rolls the engine to an older roll that failed CI in #148008, because pub was not able to solve successfully with the exact pins of package:macros. If CI passes on that commit, I will revert it and land this change without it, and then re-enable the dart -> engine roller (FYI @rmacnak-google)

All presubmits passed except for two integration test flakes unrelated to pub solving package:macros, so I will call this a successful test: https://github.com/flutter/flutter/pull/148087/checks?check_run_id=24794486500

Reverted the engine revision change in 17d5dc5

@github-actions github-actions bot removed the engine flutter/engine related. See also e: labels. label May 9, 2024
@christopherfujino christopherfujino requested a review from zanderso May 9, 2024 22:07
@christopherfujino christopherfujino marked this pull request as ready for review May 9, 2024 22:07
@christopherfujino christopherfujino changed the title Don't pin package:macros DO NOT MERGE Don't pin package:macros May 9, 2024
@christopherfujino
Copy link
Contributor Author

christopherfujino commented May 9, 2024

Merging manually because autosubmit bot is broken: #148092

@christopherfujino christopherfujino merged commit 730d6d4 into flutter:master May 9, 2024
@christopherfujino christopherfujino deleted the dont-pin-macros branch May 9, 2024 23:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2024
@engine-flutter-autoroll
730d6d4 Don't pin package:macros (flutter/flutter#148087)
bad3a55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 11, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2024
@engine-flutter-autoroll
730d6d4 Don't pin package:macros (flutter/flutter#148087)
13b0a60
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 11, 2024
@engine-flutter-autoroll
Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (#6713)
29dbf53 
flutter/flutter@2bfb1b0...2aa05c1

2024-05-11 [email protected] Roll Flutter Engine from fad88cb16d03 to 558a81dd8b08 (3 revisions) (flutter/flutter#148163)
2024-05-11 [email protected] Roll Flutter Engine from ba8e0d3e2f23 to fad88cb16d03 (9 revisions) (flutter/flutter#148156)
2024-05-11 [email protected] Add test for scaffold.1.dart (flutter/flutter#147966)
2024-05-10 [email protected] Fix `MaterialStateBorderSide` lerp in the `Checkbox` and chips (flutter/flutter#148124)
2024-05-10 [email protected] Docs on TextField disposed by a scrollable (flutter/flutter#148149)
2024-05-10 [email protected] Roll Flutter Engine from d4f705ccb695 to ba8e0d3e2f23 (8 revisions) (flutter/flutter#148147)
2024-05-10 [email protected] Roll pub packages (flutter/flutter#148148)
2024-05-10 [email protected] Add `clipBehavior` to `DialogTheme` (flutter/flutter#147635)
2024-05-10 [email protected] bump cupertino_icons to 1.08 (flutter/flutter#146806)
2024-05-10 [email protected] Add test for animated_size.0.dart API example. (flutter/flutter#147828)
2024-05-10 [email protected] Fix `DropdownMenu` keyboard navigation (flutter/flutter#147294)
2024-05-10 [email protected] Add test for draggable.0.dart API example. (flutter/flutter#147941)
2024-05-10 [email protected] Update TESTOWNERS (flutter/flutter#148108)
2024-05-10 [email protected] Add tests for stream_builder.0.dart API example. (flutter/flutter#147832)
2024-05-10 [email protected] Roll Flutter Engine from 1ccd0c308b3a to d4f705ccb695 (2 revisions) (flutter/flutter#148142)
2024-05-10 [email protected] Roll Packages from 8de142d to 6c4482a (8 revisions) (flutter/flutter#148079)
2024-05-10 [email protected] Roll Flutter Engine from c0917b14fc36 to 1ccd0c308b3a (10 revisions) (flutter/flutter#148137)
2024-05-10 [email protected] `if` chains â�� `switch` expressions (flutter/flutter#147793)
2024-05-10 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/flutter#148091)
2024-05-10 [email protected] Reland "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#148086)
2024-05-10 [email protected] Update dependabot reviewers (flutter/flutter#148101)
2024-05-10 [email protected] Roll Flutter Engine from 6e722ae213bd to c0917b14fc36 (1 revision) (flutter/flutter#148084)
2024-05-09 [email protected] Don't pin package:macros (flutter/flutter#148087)
2024-05-09 [email protected] Remove hidden dependencies on the default LocalPlatform (flutter/flutter#147342)
2024-05-09 [email protected] Getting rid of containers (flutter/flutter#147432)
2024-05-09 [email protected] Roll Flutter Engine from c0fd3386d018 to 6e722ae213bd (2 revisions) (flutter/flutter#148070)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@LimaneGaya LimaneGaya mentioned this pull request May 20, 2024
Closed
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 2bfb1b0 to 2aa05c1 (26 revisions) (flutter#6713)
adf54b6 
flutter/flutter@2bfb1b0...2aa05c1

2024-05-11 [email protected] Roll Flutter Engine from fad88cb16d03 to 558a81dd8b08 (3 revisions) (flutter/flutter#148163)
2024-05-11 [email protected] Roll Flutter Engine from ba8e0d3e2f23 to fad88cb16d03 (9 revisions) (flutter/flutter#148156)
2024-05-11 [email protected] Add test for scaffold.1.dart (flutter/flutter#147966)
2024-05-10 [email protected] Fix `MaterialStateBorderSide` lerp in the `Checkbox` and chips (flutter/flutter#148124)
2024-05-10 [email protected] Docs on TextField disposed by a scrollable (flutter/flutter#148149)
2024-05-10 [email protected] Roll Flutter Engine from d4f705ccb695 to ba8e0d3e2f23 (8 revisions) (flutter/flutter#148147)
2024-05-10 [email protected] Roll pub packages (flutter/flutter#148148)
2024-05-10 [email protected] Add `clipBehavior` to `DialogTheme` (flutter/flutter#147635)
2024-05-10 [email protected] bump cupertino_icons to 1.08 (flutter/flutter#146806)
2024-05-10 [email protected] Add test for animated_size.0.dart API example. (flutter/flutter#147828)
2024-05-10 [email protected] Fix `DropdownMenu` keyboard navigation (flutter/flutter#147294)
2024-05-10 [email protected] Add test for draggable.0.dart API example. (flutter/flutter#147941)
2024-05-10 [email protected] Update TESTOWNERS (flutter/flutter#148108)
2024-05-10 [email protected] Add tests for stream_builder.0.dart API example. (flutter/flutter#147832)
2024-05-10 [email protected] Roll Flutter Engine from 1ccd0c308b3a to d4f705ccb695 (2 revisions) (flutter/flutter#148142)
2024-05-10 [email protected] Roll Packages from 8de142d to 6c4482a (8 revisions) (flutter/flutter#148079)
2024-05-10 [email protected] Roll Flutter Engine from c0917b14fc36 to 1ccd0c308b3a (10 revisions) (flutter/flutter#148137)
2024-05-10 [email protected] `if` chains â�� `switch` expressions (flutter/flutter#147793)
2024-05-10 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/flutter#148091)
2024-05-10 [email protected] Reland "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#148086)
2024-05-10 [email protected] Update dependabot reviewers (flutter/flutter#148101)
2024-05-10 [email protected] Roll Flutter Engine from 6e722ae213bd to c0917b14fc36 (1 revision) (flutter/flutter#148084)
2024-05-09 [email protected] Don't pin package:macros (flutter/flutter#148087)
2024-05-09 [email protected] Remove hidden dependencies on the default LocalPlatform (flutter/flutter#147342)
2024-05-09 [email protected] Getting rid of containers (flutter/flutter#147432)
2024-05-09 [email protected] Roll Flutter Engine from c0fd3386d018 to 6e722ae213bd (2 revisions) (flutter/flutter#148070)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
730d6d4 Don't pin package:macros (flutter/flutter#148087)
68dcf65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @zanderso