Skip to content

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented May 9, 2024

This reverts commit 706f39b.

Relanding the original PR with no code changes. Running partial TGP now (couldn't run full TGP because of throttling).
Fixes #71687

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label May 9, 2024
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review May 9, 2024 20:20
@LongCatIsLooong LongCatIsLooong requested a review from goderbauer May 9, 2024 20:24
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
@LongCatIsLooong LongCatIsLooong merged commit 1b0e86c into flutter:master May 10, 2024
@LongCatIsLooong LongCatIsLooong deleted the reland-146260 branch May 10, 2024 03:20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 11, 2024
flutter/flutter@2bfb1b0...2aa05c1

2024-05-11 [email protected] Roll Flutter Engine from fad88cb16d03 to 558a81dd8b08 (3 revisions) (flutter/flutter#148163)
2024-05-11 [email protected] Roll Flutter Engine from ba8e0d3e2f23 to fad88cb16d03 (9 revisions) (flutter/flutter#148156)
2024-05-11 [email protected] Add test for scaffold.1.dart (flutter/flutter#147966)
2024-05-10 [email protected] Fix `MaterialStateBorderSide` lerp in the `Checkbox` and chips (flutter/flutter#148124)
2024-05-10 [email protected] Docs on TextField disposed by a scrollable (flutter/flutter#148149)
2024-05-10 [email protected] Roll Flutter Engine from d4f705ccb695 to ba8e0d3e2f23 (8 revisions) (flutter/flutter#148147)
2024-05-10 [email protected] Roll pub packages (flutter/flutter#148148)
2024-05-10 [email protected] Add `clipBehavior` to `DialogTheme` (flutter/flutter#147635)
2024-05-10 [email protected] bump cupertino_icons to 1.08 (flutter/flutter#146806)
2024-05-10 [email protected] Add test for animated_size.0.dart API example. (flutter/flutter#147828)
2024-05-10 [email protected] Fix `DropdownMenu` keyboard navigation (flutter/flutter#147294)
2024-05-10 [email protected] Add test for draggable.0.dart API example. (flutter/flutter#147941)
2024-05-10 [email protected] Update TESTOWNERS (flutter/flutter#148108)
2024-05-10 [email protected] Add tests for stream_builder.0.dart API example. (flutter/flutter#147832)
2024-05-10 [email protected] Roll Flutter Engine from 1ccd0c308b3a to d4f705ccb695 (2 revisions) (flutter/flutter#148142)
2024-05-10 [email protected] Roll Packages from 8de142d to 6c4482a (8 revisions) (flutter/flutter#148079)
2024-05-10 [email protected] Roll Flutter Engine from c0917b14fc36 to 1ccd0c308b3a (10 revisions) (flutter/flutter#148137)
2024-05-10 [email protected] `if` chains â�� `switch` expressions (flutter/flutter#147793)
2024-05-10 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/flutter#148091)
2024-05-10 [email protected] Reland "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#148086)
2024-05-10 [email protected] Update dependabot reviewers (flutter/flutter#148101)
2024-05-10 [email protected] Roll Flutter Engine from 6e722ae213bd to c0917b14fc36 (1 revision) (flutter/flutter#148084)
2024-05-09 [email protected] Don't pin package:macros (flutter/flutter#148087)
2024-05-09 [email protected] Remove hidden dependencies on the default LocalPlatform (flutter/flutter#147342)
2024-05-09 [email protected] Getting rid of containers (flutter/flutter#147432)
2024-05-09 [email protected] Roll Flutter Engine from c0fd3386d018 to 6e722ae213bd (2 revisions) (flutter/flutter#148070)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@2bfb1b0...2aa05c1

2024-05-11 [email protected] Roll Flutter Engine from fad88cb16d03 to 558a81dd8b08 (3 revisions) (flutter/flutter#148163)
2024-05-11 [email protected] Roll Flutter Engine from ba8e0d3e2f23 to fad88cb16d03 (9 revisions) (flutter/flutter#148156)
2024-05-11 [email protected] Add test for scaffold.1.dart (flutter/flutter#147966)
2024-05-10 [email protected] Fix `MaterialStateBorderSide` lerp in the `Checkbox` and chips (flutter/flutter#148124)
2024-05-10 [email protected] Docs on TextField disposed by a scrollable (flutter/flutter#148149)
2024-05-10 [email protected] Roll Flutter Engine from d4f705ccb695 to ba8e0d3e2f23 (8 revisions) (flutter/flutter#148147)
2024-05-10 [email protected] Roll pub packages (flutter/flutter#148148)
2024-05-10 [email protected] Add `clipBehavior` to `DialogTheme` (flutter/flutter#147635)
2024-05-10 [email protected] bump cupertino_icons to 1.08 (flutter/flutter#146806)
2024-05-10 [email protected] Add test for animated_size.0.dart API example. (flutter/flutter#147828)
2024-05-10 [email protected] Fix `DropdownMenu` keyboard navigation (flutter/flutter#147294)
2024-05-10 [email protected] Add test for draggable.0.dart API example. (flutter/flutter#147941)
2024-05-10 [email protected] Update TESTOWNERS (flutter/flutter#148108)
2024-05-10 [email protected] Add tests for stream_builder.0.dart API example. (flutter/flutter#147832)
2024-05-10 [email protected] Roll Flutter Engine from 1ccd0c308b3a to d4f705ccb695 (2 revisions) (flutter/flutter#148142)
2024-05-10 [email protected] Roll Packages from 8de142d to 6c4482a (8 revisions) (flutter/flutter#148079)
2024-05-10 [email protected] Roll Flutter Engine from c0917b14fc36 to 1ccd0c308b3a (10 revisions) (flutter/flutter#148137)
2024-05-10 [email protected] `if` chains â�� `switch` expressions (flutter/flutter#147793)
2024-05-10 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/flutter#148091)
2024-05-10 [email protected] Reland "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#148086)
2024-05-10 [email protected] Update dependabot reviewers (flutter/flutter#148101)
2024-05-10 [email protected] Roll Flutter Engine from 6e722ae213bd to c0917b14fc36 (1 revision) (flutter/flutter#148084)
2024-05-09 [email protected] Don't pin package:macros (flutter/flutter#148087)
2024-05-09 [email protected] Remove hidden dependencies on the default LocalPlatform (flutter/flutter#147342)
2024-05-09 [email protected] Getting rid of containers (flutter/flutter#147432)
2024-05-09 [email protected] Roll Flutter Engine from c0fd3386d018 to 6e722ae213bd (2 revisions) (flutter/flutter#148070)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[regression] TextField in a Wrap in AlertDialog crash

2 participants