-
Notifications
You must be signed in to change notification settings - Fork 29.7k
allow changing textAlign of TextField in DropdownMenu #148074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
As90909w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angelocordero Can you add a test? I think just something that verifies that it was passed through is probably fine if that's easiest.
|
@justinmc done adding a test and fixed the default value |
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @angelocordero thanks for contributing! LGTM with a few nits
|
auto label is removed for flutter/flutter/148074, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
@angelocordero Can you push a merge commit? Not sure why the ci.yaml validation is failing. |
|
auto label is removed for flutter/flutter/148074, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
The Google testing failure here was an infrastructure issue, the tests were not able to run. I have rebased this to give the bots a kick, hopefully everything will pass this run. :) |
|
auto label is removed for flutter/flutter/148074, due to - The status or check suite Windows build_tests_2_7 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
PR for #147991
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.