Skip to content

Conversation

@huycozy
Copy link
Member

@huycozy huycozy commented May 9, 2024

Demo screenshot

Screenshot 2024-05-09 at 18 47 21

Related issue

Fixes #144336

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 9, 2024
@huycozy huycozy requested review from HansMuller and TahaTesser May 9, 2024 12:12
@huycozy huycozy self-assigned this May 9, 2024
@huynguyennovem huynguyennovem force-pushed the add-badge-example branch 2 times, most recently from 548571f to e61789d Compare May 9, 2024 12:31
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! With minor nits

@TahaTesser TahaTesser requested review from QuncCccccc and removed request for HansMuller May 9, 2024 12:53
Signed-off-by: huycozy <[email protected]>
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:) Thanks!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2024
@auto-submit auto-submit bot merged commit bd44399 into flutter:master May 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 9, 2024
@huycozy huycozy deleted the add-badge-example branch May 10, 2024 03:09
bparrishMines pushed a commit to flutter/packages that referenced this pull request May 10, 2024
flutter/flutter@00f4066...2bfb1b0

2024-05-09 [email protected] Bump flutter_lints to 4.0
(flutter/flutter#148020)
2024-05-09 [email protected] Add Badge example
(flutter/flutter#148053)
2024-05-09 [email protected] Fix ExpandIcon color when
ExpansionPanel.canTapOnHeader true (#147097) (flutter/flutter#147098)
2024-05-09 [email protected] Roll Flutter Engine from
c2e874fdc164 to c0fd3386d018 (1 revision) (flutter/flutter#148040)
2024-05-09 [email protected] Roll Flutter Engine from
fe08238f5a52 to c2e874fdc164 (1 revision) (flutter/flutter#148038)
2024-05-09 [email protected] Roll Flutter Engine from
69f2d9610a18 to fe08238f5a52 (1 revision) (flutter/flutter#148034)
2024-05-09 [email protected]
Roll pub packages (flutter/flutter#148011)
2024-05-09 [email protected] Roll Flutter Engine from
bd58d2b2d655 to 69f2d9610a18 (7 revisions) (flutter/flutter#148030)
2024-05-09 [email protected] [web] Update wasm CLI details
to be clear JavaScript is ALSO compiled (flutter/flutter#147944)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected]
on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@00f4066...2bfb1b0

2024-05-09 [email protected] Bump flutter_lints to 4.0
(flutter/flutter#148020)
2024-05-09 [email protected] Add Badge example
(flutter/flutter#148053)
2024-05-09 [email protected] Fix ExpandIcon color when
ExpansionPanel.canTapOnHeader true (#147097) (flutter/flutter#147098)
2024-05-09 [email protected] Roll Flutter Engine from
c2e874fdc164 to c0fd3386d018 (1 revision) (flutter/flutter#148040)
2024-05-09 [email protected] Roll Flutter Engine from
fe08238f5a52 to c2e874fdc164 (1 revision) (flutter/flutter#148038)
2024-05-09 [email protected] Roll Flutter Engine from
69f2d9610a18 to fe08238f5a52 (1 revision) (flutter/flutter#148034)
2024-05-09 [email protected]
Roll pub packages (flutter/flutter#148011)
2024-05-09 [email protected] Roll Flutter Engine from
bd58d2b2d655 to 69f2d9610a18 (7 revisions) (flutter/flutter#148030)
2024-05-09 [email protected] [web] Update wasm CLI details
to be clear JavaScript is ALSO compiled (flutter/flutter#147944)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected]
on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Badge usage example

3 participants