It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

test-exempt: This only updates package:args --help.

I could only find 1 example of any test in flutter_tools that asserts the contents of flutter * --help, and see this is a net-positive contribution to the codebase, so LGTM.

There are a variety of tests that check the help text, the main one is in general.shard/args_test.dart. Help text is not one of the items listed on our wiki for reasons a patch could be test exempt.

@Hixie I checked this branch out to see if I could add a new test, but it seems the args_test.dart is automatically picking all the commands + options and testing them against a set of rules for validity?

I can see several instances of the wasm parameter being tested amongst others, for example:

Command "test", parameters: branch-coverage, concurrency, coverage, coverage-package, coverage-path, dart-define, dart-define-from-file, dds, dds-port, device-user, disable-dds, disable-service-auth-codes, enable-experiment, enable-impeller, enable-vmservice, exclude-tags, experimental-faster-testing, fatal-warnings, file-reporter, flavor, frontend-server-starter-path, help, ipv6, machine, merge-coverage, name, null-assertions, plain-name, platform, pub, reporter, run-skipped, serve-observatory, shard-index, sound-null-safety, start-paused, tags, test-assets, test-randomize-ordering-seed, timeout, total-shards, track-widget-creation, update-goldens, wasm, web-renderer

(This looks to be already tested, but this PR didn't need to modify any test file for tests to run. I don't think we have any place with "expected option values" (just an idea), so this could be very well reverted without having to touch (m)any tests, of course).

auto label is removed for flutter/flutter/147944, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

The way I usually land PRs like this is to find something that isn't tested yet, and test that. That way the test coverage gets better, and we have fewer regressions later. So for example, we could test that newlines in help text aren't preceded by spaces, or that all the FlutterOptions.kWebWasmFlag options have the same help text (including any future ones), or that FlutterOptions.kWebWasmFlag has the value we expect (so we don't accidentally break everyone by changing that constant), or that the option is in the right place in the list relative to other ones (maybe coming up with a standard order that we can apply uniformly), etc.

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

auto label is removed for flutter/flutter/147944, due to - The status or check suite Windows tool_integration_tests_4_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto label is removed for flutter/flutter/147944, due to - The status or check suite Windows build_tests_2_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.