Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not #147901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
framework
chunhtai
reviewed
May 7, 2024
Contributor
There was a problem hiding this comment.
is there a lint that suggests this? seems a bit weird...
Member
Author
There was a problem hiding this comment.
yes _handleCommitBackGesture is a Future<void> and handlePopRoute is a Future<bool> here
Contributor
There was a problem hiding this comment.
Just a heads up. This may potentially be a breaking change.
Contributor
There was a problem hiding this comment.
Do we have test for handled cases?
Member
Author
There was a problem hiding this comment.
yes the existing tests on Line 275 and line 297 returns true for the result. they are handled cases.
Contributor
There was a problem hiding this comment.
oh i missed the diff above. Thanks
chunhtai
approved these changes
May 7, 2024
Contributor
There was a problem hiding this comment.
oh i missed the diff above. Thanks
Contributor
There was a problem hiding this comment.
additional space between return and semicolon
This was referenced May 8, 2024
Merged
hannah-hyj
force-pushed
the
2405pushRouteMessage
branch
from
143f304 to
c6275f7
Compare
hannah-hyj
added
the
autosubmit
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
May 16, 2024
* master: (2580 commits) plugin_ffi template comment fix (flutter#148378) Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter#148455) Reland fix TextField helper top padding on M3 (flutter#146754) Removing duplicate assert on `VisualDensity` constructor (flutter#148281) Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter#148450) Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter#148448) Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter#148445) Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter#148441) Fix leaky tests. (flutter#148434) Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter#148430) Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter#148428) Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter#147901) Fix memory leaks in `_PopupMenuRoute` (flutter#148373) Add `clipBehavior` to `DrawerThemeData` (flutter#148061) Reland Native ios context menu (flutter#143002) (flutter#148238) (flutter#148265) Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter#148419) Stop running module_test_ios in devicelab and x64 Macs (flutter#148264) Roll Flutter Engine from d35a1a603c80 to bf1c6da0dd31 (1 revision) (flutter#148369) Roll Flutter Engine from 55c62ff82c7e to d35a1a603c80 (4 revisions) (flutter#148367) Roll Flutter Engine from a1d930a3a84d to 55c62ff82c7e (3 revisions) (flutter#148365) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2024
…e whether any of the observer has handled the route or not (flutter/flutter#147901)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2024
…e whether any of the observer has handled the route or not (flutter/flutter#147901)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 16, 2024
flutter/flutter@39651e8...0d22d91 2024-05-16 [email protected] fixes `DialogRoute` memory leak (flutter/flutter#147816) 2024-05-16 [email protected] Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476) 2024-05-16 [email protected] Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469) 2024-05-16 [email protected] Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465) 2024-05-16 [email protected] ThemeData minor spring cleaning (flutter/flutter#148408) 2024-05-16 [email protected] Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403) 2024-05-16 [email protected] plugin_ffi template comment fix (flutter/flutter#148378) 2024-05-16 [email protected] Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455) 2024-05-16 [email protected] Reland fix TextField helper top padding on M3 (flutter/flutter#146754) 2024-05-16 [email protected] Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281) 2024-05-16 [email protected] Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450) 2024-05-16 [email protected] Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448) 2024-05-16 [email protected] Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445) 2024-05-16 [email protected] Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441) 2024-05-15 [email protected] Fix leaky tests. (flutter/flutter#148434) 2024-05-15 [email protected] Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430) 2024-05-15 [email protected] Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428) 2024-05-15 [email protected] Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter/flutter#147901) 2024-05-15 [email protected] Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373) 2024-05-15 [email protected] Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061) 2024-05-15 [email protected] Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265) 2024-05-15 [email protected] Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419) 2024-05-15 [email protected] Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@39651e8...0d22d91 2024-05-16 [email protected] fixes `DialogRoute` memory leak (flutter/flutter#147816) 2024-05-16 [email protected] Roll Flutter Engine from 9bc449ee2e8b to 460df6caef0e (1 revision) (flutter/flutter#148476) 2024-05-16 [email protected] Roll Flutter Engine from 1ebad3a6179d to 9bc449ee2e8b (1 revision) (flutter/flutter#148469) 2024-05-16 [email protected] Roll Flutter Engine from 9e17588b330c to 1ebad3a6179d (1 revision) (flutter/flutter#148465) 2024-05-16 [email protected] ThemeData minor spring cleaning (flutter/flutter#148408) 2024-05-16 [email protected] Marks Mac_pixel_7pro native_assets_android to be flaky (flutter/flutter#148403) 2024-05-16 [email protected] plugin_ffi template comment fix (flutter/flutter#148378) 2024-05-16 [email protected] Roll Flutter Engine from 942d7c35de75 to 9e17588b330c (2 revisions) (flutter/flutter#148455) 2024-05-16 [email protected] Reland fix TextField helper top padding on M3 (flutter/flutter#146754) 2024-05-16 [email protected] Removing duplicate assert on `VisualDensity` constructor (flutter/flutter#148281) 2024-05-16 [email protected] Roll Flutter Engine from 65ac4bf96ed7 to 942d7c35de75 (1 revision) (flutter/flutter#148450) 2024-05-16 [email protected] Roll Flutter Engine from c11d64be5102 to 65ac4bf96ed7 (3 revisions) (flutter/flutter#148448) 2024-05-16 [email protected] Roll Flutter Engine from f6195e9d4b4b to c11d64be5102 (1 revision) (flutter/flutter#148445) 2024-05-16 [email protected] Roll Flutter Engine from cd150986ae63 to f6195e9d4b4b (2 revisions) (flutter/flutter#148441) 2024-05-15 [email protected] Fix leaky tests. (flutter/flutter#148434) 2024-05-15 [email protected] Roll Flutter Engine from 41b86b59f0ab to cd150986ae63 (2 revisions) (flutter/flutter#148430) 2024-05-15 [email protected] Roll Flutter Engine from bf1c6da0dd31 to 41b86b59f0ab (15 revisions) (flutter/flutter#148428) 2024-05-15 [email protected] Update _handlePushRouteInformation to Future<bool> to indicate whether any of the observer has handled the route or not (flutter/flutter#147901) 2024-05-15 [email protected] Fix memory leaks in `_PopupMenuRoute` (flutter/flutter#148373) 2024-05-15 [email protected] Add `clipBehavior` to `DrawerThemeData` (flutter/flutter#148061) 2024-05-15 [email protected] Reland Native ios context menu (#143002) (#148238) (flutter/flutter#148265) 2024-05-15 [email protected] Roll Packages from fd714bd to 87a02e3 (8 revisions) (flutter/flutter#148419) 2024-05-15 [email protected] Stop running module_test_ios in devicelab and x64 Macs (flutter/flutter#148264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hannah-hyj
added a commit
to flutter/engine
that referenced
this pull request
Jul 2, 2024
…mework (#52643) follow up on comments on #52350 framework pr : flutter/flutter#147901 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
…e whether any of the observer has handled the route or not (flutter/flutter#147901)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up on comments on flutter/engine#52350
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.