fixes SearchAnchor leak [prod-leak-fix]
#147652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
Contributor
Author
|
cc: @polina-c Linux docs_test seems to be failing i saw logs it seems to be for generating docs? i don't have idea about this perhaps re-running test would fix this? let me know if it has something to do with PR changes. |
Contributor
|
Yes, let's start with just restarting. |
Contributor
Author
|
And now it seems like a bunch of are failing as-well Can't find anything useful on the log |
Contributor
|
Flutter-tree went red recently: https://flutter-dashboard.appspot.com/#/build |
Contributor
Author
|
Looks like it's fixed ✨👀 |
polina-c
reviewed
May 2, 2024
| animation: animation, | ||
| builder: (BuildContext context, Widget? child) { | ||
| final Animation<double> curvedAnimation = CurvedAnimation( | ||
| curvedAnimation ??= CurvedAnimation( |
Contributor
There was a problem hiding this comment.
Remove extra space in front of curvedAnimation
polina-c
reviewed
May 2, 2024
|
|
||
| return FadeTransition( | ||
| opacity: CurvedAnimation( | ||
| viewFadeOnIntervalCurve ??= CurvedAnimation( |
Contributor
There was a problem hiding this comment.
It seems there are indentation issues here.
Contributor
Author
|
@polina-c Thanks for review, fixed indentation issue and removed space |
polina-c
approved these changes
May 3, 2024
polina-c
added
the
a: leak tracking
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 6, 2024
flutter/flutter@f1037a0...04424e1 2024-05-06 [email protected] Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (flutter/flutter#147865) 2024-05-06 [email protected] Fix Tooltip.decoration comment (flutter/flutter#147858) 2024-05-06 [email protected] Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (flutter/flutter#147854) 2024-05-06 [email protected] Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (flutter/flutter#147853) 2024-05-06 [email protected] Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (flutter/flutter#147852) 2024-05-05 [email protected] Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (flutter/flutter#147845) 2024-05-05 [email protected] Roll Flutter Engine from 9080957cd6a0 to 900322f23375 (1 revision) (flutter/flutter#147842) 2024-05-05 [email protected] Roll Flutter Engine from 66d08d55d788 to 9080957cd6a0 (1 revision) (flutter/flutter#147841) 2024-05-05 [email protected] Fix test. (flutter/flutter#147813) 2024-05-05 [email protected] Fix memory leaks in `CupertinoSwitch` (flutter/flutter#147821) 2024-05-05 [email protected] Reland fix memory leaks for tab selector (flutter/flutter#147689) 2024-05-05 [email protected] Fix memory leak in ExpansionTile. (flutter/flutter#147596) 2024-05-04 [email protected] Roll Flutter Engine from 135acd5a689a to 66d08d55d788 (2 revisions) (flutter/flutter#147834) 2024-05-04 [email protected] Roll Flutter Engine from c937a02c6eb0 to 135acd5a689a (2 revisions) (flutter/flutter#147818) 2024-05-04 [email protected] Roll Flutter Engine from 1d484e57ce2c to c937a02c6eb0 (2 revisions) (flutter/flutter#147812) 2024-05-03 [email protected] Roll Flutter Engine from 2561636602ed to 1d484e57ce2c (1 revision) (flutter/flutter#147808) 2024-05-03 [email protected] Roll Flutter Engine from 484574426120 to 2561636602ed (1 revision) (flutter/flutter#147805) 2024-05-03 [email protected] Roll Flutter Engine from d701f407c8ea to 484574426120 (1 revision) (flutter/flutter#147802) 2024-05-03 [email protected] Roll Flutter Engine from 250536888a91 to d701f407c8ea (2 revisions) (flutter/flutter#147800) 2024-05-03 [email protected] Roll Flutter Engine from 3eadfd5284c0 to 250536888a91 (1 revision) (flutter/flutter#147796) 2024-05-03 [email protected] Roll Flutter Engine from 837914f3788b to 3eadfd5284c0 (1 revision) (flutter/flutter#147791) 2024-05-03 [email protected] fixes `SearchAnchor` leak (flutter/flutter#147652) 2024-05-03 [email protected] Roll Flutter Engine from 8cce00433073 to 837914f3788b (1 revision) (flutter/flutter#147780) 2024-05-03 [email protected] Roll Packages from aea93d2 to f4719ca (5 revisions) (flutter/flutter#147782) 2024-05-03 [email protected] Always relies on floatingLabelStyle when FloatingLabelBehavior.always (flutter/flutter#147374) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@f1037a0...04424e1 2024-05-06 [email protected] Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (flutter/flutter#147865) 2024-05-06 [email protected] Fix Tooltip.decoration comment (flutter/flutter#147858) 2024-05-06 [email protected] Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (flutter/flutter#147854) 2024-05-06 [email protected] Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (flutter/flutter#147853) 2024-05-06 [email protected] Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (flutter/flutter#147852) 2024-05-05 [email protected] Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (flutter/flutter#147845) 2024-05-05 [email protected] Roll Flutter Engine from 9080957cd6a0 to 900322f23375 (1 revision) (flutter/flutter#147842) 2024-05-05 [email protected] Roll Flutter Engine from 66d08d55d788 to 9080957cd6a0 (1 revision) (flutter/flutter#147841) 2024-05-05 [email protected] Fix test. (flutter/flutter#147813) 2024-05-05 [email protected] Fix memory leaks in `CupertinoSwitch` (flutter/flutter#147821) 2024-05-05 [email protected] Reland fix memory leaks for tab selector (flutter/flutter#147689) 2024-05-05 [email protected] Fix memory leak in ExpansionTile. (flutter/flutter#147596) 2024-05-04 [email protected] Roll Flutter Engine from 135acd5a689a to 66d08d55d788 (2 revisions) (flutter/flutter#147834) 2024-05-04 [email protected] Roll Flutter Engine from c937a02c6eb0 to 135acd5a689a (2 revisions) (flutter/flutter#147818) 2024-05-04 [email protected] Roll Flutter Engine from 1d484e57ce2c to c937a02c6eb0 (2 revisions) (flutter/flutter#147812) 2024-05-03 [email protected] Roll Flutter Engine from 2561636602ed to 1d484e57ce2c (1 revision) (flutter/flutter#147808) 2024-05-03 [email protected] Roll Flutter Engine from 484574426120 to 2561636602ed (1 revision) (flutter/flutter#147805) 2024-05-03 [email protected] Roll Flutter Engine from d701f407c8ea to 484574426120 (1 revision) (flutter/flutter#147802) 2024-05-03 [email protected] Roll Flutter Engine from 250536888a91 to d701f407c8ea (2 revisions) (flutter/flutter#147800) 2024-05-03 [email protected] Roll Flutter Engine from 3eadfd5284c0 to 250536888a91 (1 revision) (flutter/flutter#147796) 2024-05-03 [email protected] Roll Flutter Engine from 837914f3788b to 3eadfd5284c0 (1 revision) (flutter/flutter#147791) 2024-05-03 [email protected] fixes `SearchAnchor` leak (flutter/flutter#147652) 2024-05-03 [email protected] Roll Flutter Engine from 8cce00433073 to 837914f3788b (1 revision) (flutter/flutter#147780) 2024-05-03 [email protected] Roll Packages from aea93d2 to f4719ca (5 revisions) (flutter/flutter#147782) 2024-05-03 [email protected] Always relies on floatingLabelStyle when FloatingLabelBehavior.always (flutter/flutter#147374) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
polina-c
changed the title
SearchAnchor leakSearchAnchor leak [prod-leak-fix]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to #141198
SearchAnchorPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.