Skip to content

Fix memory leak in ExpansionTile. [prod-leak-fix] #147596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 2 commits into from
May 5, 2024
Merged

Fix memory leak in ExpansionTile. [prod-leak-fix] #147596

polina-c merged 2 commits into from
May 5, 2024

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Apr 30, 2024

This PR contributes to #141198

Description

  • Adds disposal of the CurvedAnimation in the ExpansionTile widget
  • Updates expansion_tile_test.dart to ensure CurvedAnimation is disposed

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 30, 2024
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Apr 30, 2024

cc @polina-c

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Apr 30, 2024
@ksokolovskyi ksokolovskyi force-pushed the fix-leak-in-expansion-tile branch from 850c1bf to 61d8077 Compare May 1, 2024 05:56
@ksokolovskyi ksokolovskyi requested a review from polina-c May 4, 2024 06:22
@polina-c polina-c merged commit 145e940 into flutter:master May 5, 2024
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented May 5, 2024

@polina-c thanks for the review and merge!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2024
@engine-flutter-autoroll
145e940 Fix memory leak in ExpansionTile. (flutter/flutter#147596)
fe9ba38
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2024
@engine-flutter-autoroll
145e940 Fix memory leak in ExpansionTile. (flutter/flutter#147596)
3fb4e7f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2024
@engine-flutter-autoroll
145e940 Fix memory leak in ExpansionTile. (flutter/flutter#147596)
5b8b0b1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2024
@engine-flutter-autoroll
145e940 Fix memory leak in ExpansionTile. (flutter/flutter#147596)
5b093f0
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 6, 2024
@engine-flutter-autoroll
Roll Flutter from f1037a0 to 04424e1 (25 revisions) (#6674)
c4843a7 
flutter/flutter@f1037a0...04424e1

2024-05-06 [email protected] Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (flutter/flutter#147865)
2024-05-06 [email protected] Fix Tooltip.decoration comment (flutter/flutter#147858)
2024-05-06 [email protected] Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (flutter/flutter#147854)
2024-05-06 [email protected] Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (flutter/flutter#147853)
2024-05-06 [email protected] Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (flutter/flutter#147852)
2024-05-05 [email protected] Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (flutter/flutter#147845)
2024-05-05 [email protected] Roll Flutter Engine from 9080957cd6a0 to 900322f23375 (1 revision) (flutter/flutter#147842)
2024-05-05 [email protected] Roll Flutter Engine from 66d08d55d788 to 9080957cd6a0 (1 revision) (flutter/flutter#147841)
2024-05-05 [email protected] Fix test. (flutter/flutter#147813)
2024-05-05 [email protected] Fix memory leaks in `CupertinoSwitch` (flutter/flutter#147821)
2024-05-05 [email protected] Reland fix memory leaks for tab selector (flutter/flutter#147689)
2024-05-05 [email protected] Fix memory leak in ExpansionTile. (flutter/flutter#147596)
2024-05-04 [email protected] Roll Flutter Engine from 135acd5a689a to 66d08d55d788 (2 revisions) (flutter/flutter#147834)
2024-05-04 [email protected] Roll Flutter Engine from c937a02c6eb0 to 135acd5a689a (2 revisions) (flutter/flutter#147818)
2024-05-04 [email protected] Roll Flutter Engine from 1d484e57ce2c to c937a02c6eb0 (2 revisions) (flutter/flutter#147812)
2024-05-03 [email protected] Roll Flutter Engine from 2561636602ed to 1d484e57ce2c (1 revision) (flutter/flutter#147808)
2024-05-03 [email protected] Roll Flutter Engine from 484574426120 to 2561636602ed (1 revision) (flutter/flutter#147805)
2024-05-03 [email protected] Roll Flutter Engine from d701f407c8ea to 484574426120 (1 revision) (flutter/flutter#147802)
2024-05-03 [email protected] Roll Flutter Engine from 250536888a91 to d701f407c8ea (2 revisions) (flutter/flutter#147800)
2024-05-03 [email protected] Roll Flutter Engine from 3eadfd5284c0 to 250536888a91 (1 revision) (flutter/flutter#147796)
2024-05-03 [email protected] Roll Flutter Engine from 837914f3788b to 3eadfd5284c0 (1 revision) (flutter/flutter#147791)
2024-05-03 [email protected] fixes `SearchAnchor` leak (flutter/flutter#147652)
2024-05-03 [email protected] Roll Flutter Engine from 8cce00433073 to 837914f3788b (1 revision) (flutter/flutter#147780)
2024-05-03 [email protected] Roll Packages from aea93d2 to f4719ca (5 revisions) (flutter/flutter#147782)
2024-05-03 [email protected] Always relies on floatingLabelStyle when FloatingLabelBehavior.always (flutter/flutter#147374)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from f1037a0 to 04424e1 (25 revisions) (flutter#6674)
72dd009 
flutter/flutter@f1037a0...04424e1

2024-05-06 [email protected] Roll Flutter Engine from f2bfea5fdecd to a30ae7729c95 (1 revision) (flutter/flutter#147865)
2024-05-06 [email protected] Fix Tooltip.decoration comment (flutter/flutter#147858)
2024-05-06 [email protected] Roll Flutter Engine from e2b828f368f6 to f2bfea5fdecd (1 revision) (flutter/flutter#147854)
2024-05-06 [email protected] Roll Flutter Engine from c73fd390d10e to e2b828f368f6 (1 revision) (flutter/flutter#147853)
2024-05-06 [email protected] Roll Flutter Engine from 624dcb987f39 to c73fd390d10e (1 revision) (flutter/flutter#147852)
2024-05-05 [email protected] Roll Flutter Engine from 900322f23375 to 624dcb987f39 (1 revision) (flutter/flutter#147845)
2024-05-05 [email protected] Roll Flutter Engine from 9080957cd6a0 to 900322f23375 (1 revision) (flutter/flutter#147842)
2024-05-05 [email protected] Roll Flutter Engine from 66d08d55d788 to 9080957cd6a0 (1 revision) (flutter/flutter#147841)
2024-05-05 [email protected] Fix test. (flutter/flutter#147813)
2024-05-05 [email protected] Fix memory leaks in `CupertinoSwitch` (flutter/flutter#147821)
2024-05-05 [email protected] Reland fix memory leaks for tab selector (flutter/flutter#147689)
2024-05-05 [email protected] Fix memory leak in ExpansionTile. (flutter/flutter#147596)
2024-05-04 [email protected] Roll Flutter Engine from 135acd5a689a to 66d08d55d788 (2 revisions) (flutter/flutter#147834)
2024-05-04 [email protected] Roll Flutter Engine from c937a02c6eb0 to 135acd5a689a (2 revisions) (flutter/flutter#147818)
2024-05-04 [email protected] Roll Flutter Engine from 1d484e57ce2c to c937a02c6eb0 (2 revisions) (flutter/flutter#147812)
2024-05-03 [email protected] Roll Flutter Engine from 2561636602ed to 1d484e57ce2c (1 revision) (flutter/flutter#147808)
2024-05-03 [email protected] Roll Flutter Engine from 484574426120 to 2561636602ed (1 revision) (flutter/flutter#147805)
2024-05-03 [email protected] Roll Flutter Engine from d701f407c8ea to 484574426120 (1 revision) (flutter/flutter#147802)
2024-05-03 [email protected] Roll Flutter Engine from 250536888a91 to d701f407c8ea (2 revisions) (flutter/flutter#147800)
2024-05-03 [email protected] Roll Flutter Engine from 3eadfd5284c0 to 250536888a91 (1 revision) (flutter/flutter#147796)
2024-05-03 [email protected] Roll Flutter Engine from 837914f3788b to 3eadfd5284c0 (1 revision) (flutter/flutter#147791)
2024-05-03 [email protected] fixes `SearchAnchor` leak (flutter/flutter#147652)
2024-05-03 [email protected] Roll Flutter Engine from 8cce00433073 to 837914f3788b (1 revision) (flutter/flutter#147780)
2024-05-03 [email protected] Roll Packages from aea93d2 to f4719ca (5 revisions) (flutter/flutter#147782)
2024-05-03 [email protected] Always relies on floatingLabelStyle when FloatingLabelBehavior.always (flutter/flutter#147374)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
145e940 Fix memory leak in ExpansionTile. (flutter/flutter#147596)
c9ea4e7
@polina-c polina-c changed the title Fix memory leak in ExpansionTile. Fix memory leak in ExpansionTile. [prod-leak-fix] Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c Awaiting requested review from polina-c

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ksokolovskyi @polina-c