Fix _RenderValueIndicator leak [prod-leak-fix]
#147451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
framework
Contributor
Author
|
cc: @polina-c |
polina-c
approved these changes
Apr 28, 2024
polina-c
added
the
a: leak tracking
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 28, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 29, 2024
flutter/flutter@f9933b6...db8c475 2024-04-28 [email protected] Roll Flutter Engine from 5c6d4ffb66bd to 752b146df767 (2 revisions) (flutter/flutter#147487) 2024-04-28 [email protected] Roll Flutter Engine from 20fb62ba1455 to 5c6d4ffb66bd (2 revisions) (flutter/flutter#147480) 2024-04-28 [email protected] Fix `_RenderValueIndicator` leak (flutter/flutter#147451) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@f9933b6...db8c475 2024-04-28 [email protected] Roll Flutter Engine from 5c6d4ffb66bd to 752b146df767 (2 revisions) (flutter/flutter#147487) 2024-04-28 [email protected] Roll Flutter Engine from 20fb62ba1455 to 5c6d4ffb66bd (2 revisions) (flutter/flutter#147480) 2024-04-28 [email protected] Fix `_RenderValueIndicator` leak (flutter/flutter#147451) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
polina-c
changed the title
_RenderValueIndicator leak_RenderValueIndicator leak [prod-leak-fix]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #141198
Fixes memory leak on
_RenderValueIndicatorPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.