Skip to content

Conversation

@zanderso
Copy link
Member

No description provided.

Copy link
Contributor

@yusuf-goog yusuf-goog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

timeout: 60
properties:
tags: >
["devicelab", "android", "linux", "mokey"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tags are going to be the same for all linux_mokey builds ? Can they live in the linux_mokey section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know how the .ci.yaml file is supposed to work, and I'm just following suit with every other build. If putting the common tags under the linux_mokey section is expected to work, I can try that cleanup for the whole file in a separate PR.

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 24, 2024

auto label is removed for flutter/flutter/147339, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2024
@zanderso zanderso merged commit 6c5606b into master Apr 24, 2024
@zanderso zanderso deleted the zanderso-patch-1 branch April 24, 2024 23:33
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 25, 2024
flutter/flutter@dba4f77...5d3bca4

2024-04-25 [email protected] Roll Flutter Engine from 6b33890a4701 to 674890ce7141 (1 revision) (flutter/flutter#147365)
2024-04-25 [email protected] [native_assets] Use kernel concatenation (flutter/flutter#147158)
2024-04-25 [email protected] Roll Flutter Engine from ccd57f5a4bc4 to 6b33890a4701 (2 revisions) (flutter/flutter#147359)
2024-04-25 [email protected] Roll Flutter Engine from 9de649ed2926 to ccd57f5a4bc4 (1 revision) (flutter/flutter#147356)
2024-04-25 [email protected] Roll Flutter Engine from 2f48456a425a to 9de649ed2926 (2 revisions) (flutter/flutter#147354)
2024-04-25 [email protected] Roll Flutter Engine from f48f3b6a0172 to 2f48456a425a (1 revision) (flutter/flutter#147351)
2024-04-25 [email protected] Roll Flutter Engine from b30c0a765680 to f48f3b6a0172 (8 revisions) (flutter/flutter#147348)
2024-04-25 [email protected] Allow the SceneBuilder, PictureRecord, and Canvas constructor calls from the rendering layer to be hooked (flutter/flutter#147271)
2024-04-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.3 to 4.1.4 (flutter/flutter#147334)
2024-04-24 [email protected] Fix filled color is wrong for a focused and hovered TextField (flutter/flutter#146976)
2024-04-24 [email protected] Roll Flutter Engine from b5d5832f7144 to b30c0a765680 (14 revisions) (flutter/flutter#147336)
2024-04-24 [email protected] Run new_gallery__transition_perf on mokey in staging (flutter/flutter#147339)
2024-04-24 [email protected] Remove hidden dependencies on the default goldenFileComparator. (flutter/flutter#146956)
2024-04-24 [email protected] Add create app and plugin templates for Swift Package Manager (flutter/flutter#147082)
2024-04-24 [email protected] Add support for overriding `reverseCurve` with `ExpansionTile.expansionAnimationStyle` (flutter/flutter#147103)
2024-04-24 [email protected] Mark firebase tests as `bringup: true` (flutter/flutter#147338)
2024-04-24 [email protected] Add Valentin Vignal to AUTHORS (flutter/flutter#147314)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@dba4f77...5d3bca4

2024-04-25 [email protected] Roll Flutter Engine from 6b33890a4701 to 674890ce7141 (1 revision) (flutter/flutter#147365)
2024-04-25 [email protected] [native_assets] Use kernel concatenation (flutter/flutter#147158)
2024-04-25 [email protected] Roll Flutter Engine from ccd57f5a4bc4 to 6b33890a4701 (2 revisions) (flutter/flutter#147359)
2024-04-25 [email protected] Roll Flutter Engine from 9de649ed2926 to ccd57f5a4bc4 (1 revision) (flutter/flutter#147356)
2024-04-25 [email protected] Roll Flutter Engine from 2f48456a425a to 9de649ed2926 (2 revisions) (flutter/flutter#147354)
2024-04-25 [email protected] Roll Flutter Engine from f48f3b6a0172 to 2f48456a425a (1 revision) (flutter/flutter#147351)
2024-04-25 [email protected] Roll Flutter Engine from b30c0a765680 to f48f3b6a0172 (8 revisions) (flutter/flutter#147348)
2024-04-25 [email protected] Allow the SceneBuilder, PictureRecord, and Canvas constructor calls from the rendering layer to be hooked (flutter/flutter#147271)
2024-04-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.3 to 4.1.4 (flutter/flutter#147334)
2024-04-24 [email protected] Fix filled color is wrong for a focused and hovered TextField (flutter/flutter#146976)
2024-04-24 [email protected] Roll Flutter Engine from b5d5832f7144 to b30c0a765680 (14 revisions) (flutter/flutter#147336)
2024-04-24 [email protected] Run new_gallery__transition_perf on mokey in staging (flutter/flutter#147339)
2024-04-24 [email protected] Remove hidden dependencies on the default goldenFileComparator. (flutter/flutter#146956)
2024-04-24 [email protected] Add create app and plugin templates for Swift Package Manager (flutter/flutter#147082)
2024-04-24 [email protected] Add support for overriding `reverseCurve` with `ExpansionTile.expansionAnimationStyle` (flutter/flutter#147103)
2024-04-24 [email protected] Mark firebase tests as `bringup: true` (flutter/flutter#147338)
2024-04-24 [email protected] Add Valentin Vignal to AUTHORS (flutter/flutter#147314)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants