Swap crash reporting with unified analytics #147296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
9 tasks
| logger = BufferLogger.test(); | ||
| fs = MemoryFileSystem.test(); | ||
| testUsage = TestUsage(); | ||
| fakeAnalytics = getInitializedFakeAnalyticsInstance( |
Contributor
There was a problem hiding this comment.
What about instead we just use our own implementation of this class, such as:
class FakeAnalytics extends Fake implements Analytics {
const FakeAnalytics({this.okToSend = true});
@override
bool okToSend;
@override
void suppressTelemetry() => okToSend = false;
}
Contributor
There was a problem hiding this comment.
I haven't done a deep dive on getInitializedFakeAnalyticsInstance, but I am inclined to agree with this suggestion. Speaking generally, I think it's good for a test to fake as little as needed so that it's more clear as to what that test depends upon.
Contributor
|
We should land this before GA3 is taken offline |
Contributor
|
I'll be remaking this PR since the cla/google check is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
package:unified_analyticsto decide if we should send a crash report #147260Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.